From: Andrew Morton <akpm@linux-foundation.org>
To: <wang.yaxin@zte.com.cn>
Cc: <fan.yu9@zte.com.cn>, <yang.yang29@zte.com.cn>, <corbet@lwn.net>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<xu.xin16@zte.com.cn>
Subject: Re: [PATCH 1/3] delaytop: add delay max for delaytop
Date: Thu, 2 Jul 2026 15:58:28 -0700 [thread overview]
Message-ID: <20260702155828.3b641339840e94917c165bd6@linux-foundation.org> (raw)
In-Reply-To: <202607022058152607Y25X-YgssuvncpVNHljz@zte.com.cn>
On Thu, 2 Jul 2026 20:58:15 +0800 (CST) <wang.yaxin@zte.com.cn> wrote:
> From: Wang Yaxin <wang.yaxin@zte.com.cn>
>
> Previously delaytop only showed average delays. Add delay_max fields to
> track the maximum delay value for each delay type (cpu, blkio, irq, swapin,
> freepages, thrashing, compact, wpcopy) per task.
>
> This provides a global view of all tasks' delay spikes, which is essential
> for identifying processes that experienced brief but significant latency
> events that would be hidden by average-only metrics.
>
> The -t/--type option displays only the specified delay type with avg/max
> values side by side, allowing focused analysis:
> delaytop -t cpu # Show only CPU delay with avg/max
> delaytop -t wpcopy # Show Copy-on-Write delay with avg/max
>
> ...
>
> total1 = *(unsigned long long *)((char *)t1 + cfg.sort_field->total_offset);
The code does this pointer operation in many places. Is there a better
way? Should all those `unsigned long long' fields in `struct
task_info' be in an array, something like that?
next prev parent reply other threads:[~2026-07-02 22:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 12:57 [PATCH 0/3 v3] delaytop: add delay max, timestamp and sorting for top latency analysis wang.yaxin
2026-07-02 12:58 ` [PATCH 1/3] delaytop: add delay max for delaytop wang.yaxin
2026-07-02 22:58 ` Andrew Morton [this message]
2026-07-02 12:58 ` [PATCH 2/3] delaytop: add timestamp of delay max wang.yaxin
2026-07-02 23:01 ` Andrew Morton
2026-07-02 13:00 ` [PATCH 3/3] delaytop: sort by max delay to highlight top latency processes wang.yaxin
2026-07-02 23:01 ` [PATCH 0/3 v3] delaytop: add delay max, timestamp and sorting for top latency analysis Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2026-05-30 3:16 [PATCH 0/3 v2] " wang.yaxin
2026-05-30 3:17 ` [PATCH 1/3] delaytop: add delay max for delaytop wang.yaxin
2026-05-27 13:55 [PATCH 0/3] delaytop: add delay max, timestamp and sorting for top latency analysis wang.yaxin
2026-05-27 13:57 ` [PATCH 1/3] delaytop: add delay max for delaytop wang.yaxin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260702155828.3b641339840e94917c165bd6@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=fan.yu9@zte.com.cn \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wang.yaxin@zte.com.cn \
--cc=xu.xin16@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox