From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F14B24314AC for ; Mon, 6 Jul 2026 13:23:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783344230; cv=none; b=UDUFMENXt1gz+7ItNKWTPktP6M/nSb1flK8DPo7DTGAUUud1svHYTK0JJKhsZymliNnLCTSK90yPxHNhUgMN2oCe+MsWc8KX75MFsLHFIaKjkZr692iJAs2GkQjDm5ZDxPkT2zhhlyfSWJ7lvfXRVqnThH22yIr6zIc2FS3+sj4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783344230; c=relaxed/simple; bh=N0QGuvm6HyGdu49K4Td11hFP4tn89+ZNKW65vJ51WLo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AWm8DLMkU/yyTHhvYX+eKjg48YUrPA7CWVvpc+dWjwUAnF6aQZMWo6eBs7hFUwxnBOYsZRB3gRDcm0PXWQRNUQ0AcNEnkf/oZ8ccKJPf9QFrUneuklklC3V9bC1GWTr0Kego0XxO2v2QBJv+mO9CqOebYwClCG575Xst2ak6Aa0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=O5S+1vau; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=gr4VmvyM; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="O5S+1vau"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="gr4VmvyM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783344228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xwaVaSQ5TrM+UFp0WZFnLdkXUL3cYc/gcLsGvJWd3Uc=; b=O5S+1vauKA7+XQ9M1GRiTlre7jtnaOtLM4/5Y49GQXcgE0fQRCK1ob/y4gyy3zxKf3oKrv /TbuuE4aT+XE+fsiiD8iRqFTPj8hbAKqUumFwYTDYVS6XCx47g6L0ExJUri7m+YpBwz+RT ogCAug1EChPZr33tueeYWX3RY/MUFag= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-21-C4EJjxP6Mv-f2qhQl0Euqw-1; Mon, 06 Jul 2026 09:23:46 -0400 X-MC-Unique: C4EJjxP6Mv-f2qhQl0Euqw-1 X-Mimecast-MFC-AGG-ID: C4EJjxP6Mv-f2qhQl0Euqw_1783344225 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4629f312a67so2802735f8f.2 for ; Mon, 06 Jul 2026 06:23:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783344225; x=1783949025; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xwaVaSQ5TrM+UFp0WZFnLdkXUL3cYc/gcLsGvJWd3Uc=; b=gr4VmvyMrtRLBnl5WQXAhAg4GBCKakKO/7NFJYJoCN49Im7ZcfvUA9hq4KLZJS9Cgd 9DwMj9+rcsbBUNtb2Ca38dTpUcvNvcgpMDwvYJDm8toHIPJNAXYMK5oe+qQG30wPQia8 Am1G9XrgAtUeIZmo1q/B8IU0KlyxvNkKkjWDJkwpVHuCFSMXrwwwEvzDfTbwZKKJ4J/a nOIuTDV31bsIB4NPZdLA2YwuhYhew0vzKkzN2hl36cjSIbDqCCsj3um1QiZn1x8cWSmd Iwsog+XOMWZkUtu0wcTdRqjnirm8jTo1lm1yDyW0YN6YgjUgE7rNmpH6FGFUgBk0K3mH HtpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783344225; x=1783949025; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xwaVaSQ5TrM+UFp0WZFnLdkXUL3cYc/gcLsGvJWd3Uc=; b=ZwIfzIks3jqksv7OVDE1Vmsa0mxcAa88+MuTvb5RZGHoJbZ6xffAyZ7V3gY6DzNczY VVxZ2Gt18MAxokJywpoiUV9iR5QDjjV2yY0GxGCahkFaJLlcjX4h2/1OkawSNrs//GHb tBBA9o2ZCUssueSKOIMca/biOljGnAgqlr/LqmZcq8qYxW3Ujsmf+BiTvPpO+yLrbSmw YEsQt+ZGNQQe76kRsdwDQszSbMCoTCLiHs7X97WWWGQhI88MT14K6qUCwOHtna8uFHkG hiST/f6btPRsQxs+uY98CRFubes9+6WcSs9xrPKjcAbxF9y2me9sVt57p7Iy1BpjnAk4 5zvA== X-Forwarded-Encrypted: i=1; AHgh+Rrhkhs3DHZ+bZX9XzKuXxn3UMgYbm924SaUQCiEx+OWufT+1K3sFmhhPEnUc6vzDojVnoUenGvpBIw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1Ct76NKOQCrUcEiHY8OelTR1FvvlHoTccIlIvdD22hm+Lv5/p O5zBDym7eFA1uHUJIP2a1E9DzclCGBIMYNhCHxrkAYoMDN12GYWgsXEAgOvOl8GLMT0xDkWlpLP DoymTe6idIgU5+u4Mn/Dnq6xZ5QkEZqdfhZ+mBEanAk9dEdpLqVDH4JN3WRSqTQ== X-Gm-Gg: AfdE7cm0oPUBmn8sL1ZCtTtIYaXnoNIeD8fycEkjHdi/238g70wrwEmHioIrVvPN5dO FiUsjefyb4EscVgGjDpl/jH9d6vLQXKS7V5s+c5VBx2PPHgBtqXBD5rxzEtNZK7XLJ9dN0vUe2k rXmeAc4nO6QSnahmVCRpKfAt/1ixpFVXr0nu8jKGnt7c7Cwa4WkQ1UqN+ria9iDlDbV+jddSmuO +qlK6FQpjnP6flPUnFEniSEcPu4TPH2UUeUlxKEnKD8OtK+8JnBQU4XBDi/jOuiYwDtv0k8Ee3+ y2r7sY3IEFJVDRg32gKtZxe4CMr+aEf/+dvS1XeVGIJSe4tEFhp1LaDuzpKlE5N/TcowpBTDRS9 3oJjUbG+vkgbCgFxHiKSVJDWlZWmjCts0 X-Received: by 2002:a05:6000:82:b0:472:90af:e406 with SMTP id ffacd0b85a97d-47de66ce06dmr154900f8f.37.1783344225267; Mon, 06 Jul 2026 06:23:45 -0700 (PDT) X-Received: by 2002:a05:6000:82:b0:472:90af:e406 with SMTP id ffacd0b85a97d-47de66ce06dmr154861f8f.37.1783344224726; Mon, 06 Jul 2026 06:23:44 -0700 (PDT) Received: from redhat.com (IGLD-80-230-68-31.inter.net.il. [80.230.68.31]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9e4d7801sm25370218f8f.16.2026.07.06.06.23.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 06:23:44 -0700 (PDT) Date: Mon, 6 Jul 2026 09:23:40 -0400 From: "Michael S. Tsirkin" To: Brett A C Sheffield Cc: Simon Schippers , Willem de Bruijn , Jason Wang , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Simon Horman , Jonathan Corbet , Shuah Khan , Andrew Lunn , Tim Gebauer , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] tun/tap & vhost-net: make qdisc backpressure opt-in via IFF_BACKPRESSURE Message-ID: <20260706091706-mutt-send-email-mst@kernel.org> References: <20260706094242.115992-1-simon.schippers@tu-dortmund.de> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jul 06, 2026 at 12:11:15PM +0200, Brett A C Sheffield wrote: > On 2026-07-06 11:42, Simon Schippers wrote: > > Commit 1d6e569b7d0c ("tun/tap & vhost-net: avoid ptr_ring tail-drop > > when a qdisc is present") did not show a relevant performance regression > > in my testing but on Brett Sheffield's librecast testbed it shows a > > significant performance drop in a IPv6 multicast testcase. The regression > > can be pinpointed when multiple iperf3 UDP threads are sending. For 8 > > threads the performance dropped from 13.5 Gbit/s to 9.13 Gbit/s. This is > > the reason why this patch makes the qdisc backpressure behavior opt-in. > > Your v1 commit message was correct. The iperf3 tests were TCP, not UDP. > > The original failing test that alerted me to the problem was IPv6 multicast > (UDP), but the reproducer tests I provided stats for in the regression report > were TCP "To eliminate my code and any multicast weirdness" and also to verify > that this also affected TCP. > > Sorry for the confusion. The command lines used are in the regression report. > > I've tested the v2 patch (with IPv6 multicast), and verified the > previously failing test passes. > > Tested-by: Brett A C Sheffield > > Cheers, Just to clarify, it's more of a work-around, not a fix. It's not really great to have a flag that says "change something opaque in the internals of the device, it affects performance in some way, we can't predict how". So maybe we really should revert for now, and work on something more coherent for the next linux. > > Brett > -- > Brett Sheffield (he/him) > Librecast - Decentralising the Internet with Multicast > https://librecast.net/ > https://blog.brettsheffield.com/