From: Conor Dooley <conor@kernel.org>
To: rodrigo.alencar@analog.com
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-hardening@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Subject: Re: [PATCH v7 09/17] dt-bindings: iio: frequency: add ad9910
Date: Tue, 7 Jul 2026 17:11:37 +0100 [thread overview]
Message-ID: <20260707-frays-backtrack-2de75efdf7be@spud> (raw)
In-Reply-To: <20260707-ad9910-iio-driver-v7-9-a4ec30f63700@analog.com>
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
On Tue, Jul 07, 2026 at 03:04:30PM +0100, Rodrigo Alencar via B4 Relay wrote:
> + adi,pll-enable:
> + type: boolean
> + description:
> + Indicates that a loop filter is connected and the internal PLL is enabled.
Is this wording correct? Does the PLL come on automatically or is it
turned on by hardware? If the property means that the driver must turn
on the PLL, the wording should be adjusted.
Otherwise, I think this looks okay.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable
> + Often used when the reference clock is provided by a crystal or by a
> + single-ended on-board oscillator.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-07-07 16:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 14:04 [PATCH v7 00/17] AD9910 Direct Digital Synthesizer Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 01/17] iio: ABI: add attributes for altcurrent channels Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 02/17] iio: ABI: scale and offset for frequency/phase channels Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 03/17] iio: ABI: add parent entry for iio channels Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 04/17] iio: add IIO_FREQUENCY channel type Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 05/17] iio: core: support 64-bit register through debugfs Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 06/17] iio: core: create local __iio_chan_prefix_emit() for reuse Rodrigo Alencar via B4 Relay
2026-07-07 15:58 ` Andy Shevchenko
2026-07-07 14:04 ` [PATCH v7 07/17] iio: test: add kunit tests for channel prefix naming generation Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 08/17] iio: core: add hierarchical channel relationships Rodrigo Alencar via B4 Relay
2026-07-07 16:00 ` Andy Shevchenko
2026-07-07 14:04 ` [PATCH v7 09/17] dt-bindings: iio: frequency: add ad9910 Rodrigo Alencar via B4 Relay
2026-07-07 16:11 ` Conor Dooley [this message]
2026-07-07 16:13 ` Conor Dooley
2026-07-07 14:04 ` [PATCH v7 10/17] iio: frequency: ad9910: initial driver implementation Rodrigo Alencar via B4 Relay
2026-07-08 9:04 ` Uwe Kleine-König
2026-07-07 14:04 ` [PATCH v7 11/17] iio: frequency: ad9910: add basic parallel port support Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 12/17] iio: frequency: ad9910: add digital ramp generator support Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 13/17] iio: frequency: ad9910: add RAM mode support Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 14/17] iio: frequency: ad9910: add output shift keying support Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 15/17] iio: frequency: ad9910: show channel priority in debugfs Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 16/17] iio: ABI: add docs for ad9910 sysfs and debugfs entries Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 17/17] docs: iio: add documentation for ad9910 driver Rodrigo Alencar via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260707-frays-backtrack-2de75efdf7be@spud \
--to=conor@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=gustavoars@kernel.org \
--cc=jic23@kernel.org \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=rodrigo.alencar@analog.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox