From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF8443783B5 for ; Sat, 18 Jul 2026 23:36:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784417768; cv=none; b=S9T/pLEYx1a6QSIxaKvzjzf4Xowe7s2/HZxW/2AnNEB/UCQrI+UGR3p5qwRB9hnin/aUMPnwgLeZt2e/qMROblqBQwpizNOQBNBpTe+kM4nPkIa6hMm36z18/73X9fYgWJFMBhASjUQ8I3aUho/58JlaarsPtYShhWjcn95/PV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784417768; c=relaxed/simple; bh=ZH81L3uHWN97/YC8FIR37Q/EWDlCtHMgy9u61P6CSM8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bEDosuoX2AlqAcp9EA6KDScQvxdAUszKzYANBPE8LwaHKxsPw4uU1fi6k0L0C2vbkSjcX7ojJVqcSpJ0G1z3mf+vNTrP82RmoSkLfWaJg1rkGk7FoBkiO2eolnxQfxWEH+GTqrdt2aajEaZ5gYOIuR+h1PpzO5OdvKIz+gXnNdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G4j7j0h6; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G4j7j0h6" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-49558ce01afso912065e9.1 for ; Sat, 18 Jul 2026 16:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784417765; x=1785022565; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oxJhJqOvpAaSiQeGabxE955gR5KY+0a4asEx/JWs7Lo=; b=G4j7j0h6e915Ylzf8+u87qu55Lx+dwUsTf4WeGBevTmLmpqd3bmiWSyzp/MxhzVsjx av/Wx4aGeGCxhHUfJihyH3PwSbCRmeiD38x3rRQmPs7RZ7RVP/a7+cK5Uc5kf1B5NxH+ nkdL4RuccpbutFS31tl441qFYmCVaAg1GWvJPefGg50SCzoB3gR+ChwVBcmhy+I+J162 dsqpRawUrAs9gn5VG10wtGyi0On0eKFvDmm6XDrptf38xbBePepFcCLmEF4EkKb8R+cS FIVmdB4Mbr1vmDhwalszC+lrMYJTmLmuxtNHZ7Bf72ipzQnGny1GjYFpAr4q+uwGb9wt wDIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784417765; x=1785022565; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=oxJhJqOvpAaSiQeGabxE955gR5KY+0a4asEx/JWs7Lo=; b=mGqEQ+OvARwtD0TPCwBHIPxqjducQVDCofXhcvSwBiSI0/rMhbqZrbQkMczQx/y/tX Ew75g7ys5Q0ym/TtVX3guH2TfP4LeE2vWWnkLvsir1JkTCayzgCyWXGVgkE/30UozwdW I7/taq5gkDxTpVIg+edd2UOGNHfIcZdx+6Ca8WGftORFhcmR8EiZsLIxAbejQFiKkSzq ANicBPCr3kIQtUCaAfX8+jdO8xZgRESPz2m/tVIlu2AGBOO6r/HEuEZEgrY84/EwFFgh yWgcTqS29q5Ssfrk7v9Xyhh/fDDQ85BXB58VAXrrDxP52lbzmx1TtZpYMfovOC08hfh5 7OfA== X-Forwarded-Encrypted: i=1; AHgh+RrUogKxAQDO7Nwk/yPESk77PPCtc8Q20y8OF4VSPC3HvHch87hMLBp+03HIVp41lYnIilMUOP8abZ4=@vger.kernel.org X-Gm-Message-State: AOJu0Ywai0V7QyDepqhGZLBL5bY7BbXgc5/IxzqSBMZoM+x6EzT2RhFE NhWJxVhad8zOjPtKzqSwoncoVmHSwVWTRc572ZP+cYlkDQXfbP0aHDkC X-Gm-Gg: AfdE7clLgNe9ZLE4nHxrqdbH8NfiMkVSQO29rCesV49pO0NTOMF/UeEsPB+31xQ9sgH rIOfOYnBGEmMLAAvPP8iOrwMmqrP1gcR3Tm24ThtKrInT321BwJHeom37bpVGXH4vSBUfKt0c+d LCRarGzKJiQOATIDxVbp4kFgmFcmedTqvP0eW2kF/uJRTi/wGRfTanO0Lbsr9uOrjU/UU76M9dg CAZiXCK1/CyjEsswhKAZ8kBvPiVF4zp6zYeUG2s97QLuSbROSbORjjPCcyjC4x1jvg6N6DBkMd4 6LwKtI5jGlG7y7zXi3kmk0cVosAXX4xzz67UMJrDK3ssSlVTlbn8SZF5uFuL6N4wH09SfFCjKH5 yvH+GM380L8z+ua9Vujf4gMwwe3DiIOo18oKdgR5/5J37tBzzS5313sa9WNLw8gXBapWoP+uEoL wzSdZXb6Iasw== X-Received: by 2002:a05:600c:4ec6:b0:495:4d5c:903e with SMTP id 5b1f17b1804b1-4954d5c913dmr76289525e9.7.1784417764814; Sat, 18 Jul 2026 16:36:04 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:645b:9e5c:7fe3:c09f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2a24b6sm160964675e9.3.2026.07.18.16.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 16:36:04 -0700 (PDT) From: Diogo Silva Date: Sun, 19 Jul 2026 01:35:33 +0200 Subject: [PATCH 02/15] drm/xlnx/zynqmp_dpsub: remove dependency on DRM simple helpers Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260719-drm_simple_encoder_init-v1-2-a78c509e3062@gmail.com> References: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> In-Reply-To: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Also check the return value from drm_encoder_init() to avoid silent failures. Signed-off-by: Diogo Silva --- drivers/gpu/drm/xlnx/zynqmp_kms.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c index d5f922450565..1d194c2824e3 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c @@ -30,7 +30,6 @@ #include #include #include -#include #include #include @@ -417,6 +416,10 @@ static const struct drm_driver zynqmp_dpsub_drm_driver = { .minor = 0, }; +static const struct drm_encoder_funcs zynqmp_dpsub_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static int zynqmp_dpsub_kms_init(struct zynqmp_dpsub *dpsub) { struct drm_encoder *encoder = &dpsub->drm->encoder; @@ -436,7 +439,13 @@ static int zynqmp_dpsub_kms_init(struct zynqmp_dpsub *dpsub) /* Create the encoder and attach the bridge. */ encoder->possible_crtcs |= drm_crtc_mask(&dpsub->drm->crtc); - drm_simple_encoder_init(&dpsub->drm->dev, encoder, DRM_MODE_ENCODER_NONE); + ret = drm_encoder_init(&dpsub->drm->dev, encoder, + &zynqmp_dpsub_encoder_funcs, + DRM_MODE_ENCODER_NONE, NULL); + if (ret) { + dev_err(dpsub->dev, "failed to initialize encoder\n"); + return ret; + } ret = drm_bridge_attach(encoder, dpsub->bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR); -- 2.54.0