From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C674481AB3 for ; Mon, 20 Jul 2026 19:35:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784576131; cv=none; b=CBTU+1G261AXhLAtSUtpLmI52WPWm1c3MNn80lvODaRLMiYjO4fP14CFrIaQZ4c+F9e6iyzL8//7Mg1rlF7sxTNiiFmpPiellm1Gy6V3QHuiwYWZFVsFoA3rNTgKNhwq3uUoxnaHrIt9aMxsOskoPt1VrjDDrlF/MeIPVi8dX7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784576131; c=relaxed/simple; bh=di7fIfxF7ozb/zDn5Ysl3z+j036+4RO+ucFlAFRHfuQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mchO6Nku6zCGKaer/LM9BBA0geLJnCZMukuapcogh2s5LmyeLMyBTwOqqyGO1wk2qFEWIDWPBaLejeGMRbeBqv7EGk1OolQu0P6EzPuIV9pvvB3hBIrxrszIV9C26vzX0/U4HmF/prCO+S5r2VP9wwDQhZCDVBeOygdWXHZIfho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=JSKEdj1s; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="JSKEdj1s" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-92e602d2c0fso380133985a.0 for ; Mon, 20 Jul 2026 12:35:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1784576125; x=1785180925; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wWSndD15nfA3ulYoFeibVziNkAccxURrSPvFkTAURcI=; b=JSKEdj1sd5bwDdBC10wiOM5dTGvPWr1yHnxMeDmOaJ+51wGUTpa3aapxVQ4uz1yTKq WY7kUXcLpEqZ9FD88SFmyoDP43tH00wY3jy7/I9FqW3LpMRxnId9rFrdxo3T1ongr6d4 /AVrPVYNAbWx6uqxL0UcR72MsHkhc7vx7WA4svqIiMbjwlh07JQ5z+gNyNnS+YbWzjv3 lDeyRVPdHZPfBOgCw/Xay0rYURJAGp9c06A5Z7+NSiDbuWq6cXteYNMP0d9BrS1zEHPF 0O1PUWaQPd29TNUtzlrggsyXChoBqQsUgJZ74w89h85HNrN1ho+G2UTxY7qoIS4cHvUA +I3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784576125; x=1785180925; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=wWSndD15nfA3ulYoFeibVziNkAccxURrSPvFkTAURcI=; b=arQkcqOZG5NerwQVA+v/nSYkcp4x+hW+WZpvtDrPICWTBnKzWxJJ5QYIKac3Ya7zpx r8EjvPQwyHHx1/V5gP3/l0REO/nJsIJso6yCBPec8esekq79Y5OGyw9tvzsw3axih037 VOxRZNSNe0h87JAOObU5EsnfJuhga54Z2G5XdhdEWLMXktiAZzx7qKs14hMx+5a4VKv8 +QfzBDSP5a/VLkjp23d8iRmCZeV1d6Vu4WFe5kAbWkwERVqxvTa3MHzrG86T9ZLg1Ijq gY8idGseJ2T620cEIlJ4DpoGkTL+oxFkeA3zNUGc+DKD/62JBOC25j9TuEKkSv+h7wAm CvUw== X-Forwarded-Encrypted: i=1; AHgh+RoBs1rvAD6wJ999+gd6g4GZsKNZItP4/lIIG8aKdh9k0oIQZFm2Vo3SwVnMvn9gkhxF+hPELlwNdlg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9Q3YWcQDIEQWqaNaIwthrAMr+I47mI56Ro3s7SJlamwX35J+6 JT3ScVoPzvmplhSVgDyLWF2bQb/J+Q47fkcOd/d5vBG2/NBa+FRApDcOjdvhkG9y98U= X-Gm-Gg: AfdE7cmOmuHZEh5Ka/AjK0aXhMofqjbBPbpV2Km6y7ZYGz7Tdh2nck2yLZ2bPWeAuJG lhv2fYvQnnbE+PRZ+heDz8/ttRZvNP/mNfJeYgr1imu9vW6ci4FySjUsBs0fpxp2aaUyoWoixaC MnT4Q9xTV4pu55G6dni/8q0O1adnxbTPYHhWATcLV6v/ys5YPOuCa9k4MicJEe5Mq4H0zz9rcg7 1FTTfQ3l5JqmSWJGBFr5LkaDmKgg1+mdHTGnMOmh/WgK7zF6Pqy9ApUSNJy/Spns2nXJsAvOxo0 urzxl1ie1+o8ZQNCzMJuNMnWxav/Jzsi8WLnUr/qcfaJv7AJgptWPmB4euH1uD8sdrcxcvEtCLH wBeww1Lb0Dmeq0rYiT6X0JRaLsoV2En6FHrZFgMdRpGWA1Jg8AxCI4NEWIQY1CKVC/UfrXt0BBf okq2NCW94iJecqvsfBmLb1OxEJK+iYxFpahNyTPJITJ4wjQr9eD8scGvHVePums9w= X-Received: by 2002:a05:620a:2913:b0:92e:f2cf:56f9 with SMTP id af79cd13be357-930b4830467mr1569223785a.9.1784576125333; Mon, 20 Jul 2026 12:35:25 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F.lan (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id af79cd13be357-930b545e47bsm957792285a.35.2026.07.20.12.35.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 12:35:24 -0700 (PDT) From: Gregory Price To: linux-mm@kvack.org Cc: Zhigang.Luo@amd.com, arun.george@samsung.com, balbirs@nvidia.com, brendan.jackman@linux.dev, yuzenghui@huawei.com, apopple@nvidia.com, alucerop@amd.com, matthew.brost@intel.com, akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, corbet@lwn.net, skhan@linuxfoundation.org, gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org, djbw@kernel.org, vishal.l.verma@intel.com, dave.jiang@intel.com, alison.schofield@intel.com, osandov@osandov.com, jannh@google.com, pfalcato@suse.de, jackmanb@google.com, hannes@cmpxchg.org, ziy@nvidia.com, pbonzini@redhat.com, osalvador@suse.de, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com, kasong@tencent.com, qi.zheng@linux.dev, shakeel.butt@linux.dev, baohua@kernel.org, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, yury.norov@gmail.com, linux@rasmusvillemoes.dk, longman@redhat.com, ridong.chen@linux.dev, tj@kernel.org, mkoutny@suse.com, sj@kernel.org, jgg@ziepe.ca, jhubbard@nvidia.com, peterx@redhat.com, baolin.wang@linux.alibaba.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, lance.yang@linux.dev, usama.arif@linux.dev, xu.xin16@zte.com.cn, chengming.zhou@linux.dev, roman.gushchin@linux.dev, muchun.song@linux.dev, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, driver-core@lists.linux.dev, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-debuggers@vger.kernel.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, cgroups@vger.kernel.org, damon@lists.linux.dev, linux-kselftest@vger.kernel.org, kernel-team@meta.com Subject: [PATCH v5 18/36] mm/gup: disallow longterm pin of private node folios Date: Mon, 20 Jul 2026 15:34:12 -0400 Message-ID: <20260720193431.3841992-19-gourry@gourry.net> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260720193431.3841992-1-gourry@gourry.net> References: <20260720193431.3841992-1-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit FOLL_LONGTERM on a N_MEMORY_PRIVATE node folio is wrong both ways the GUP longterm path resolves it: a ZONE_NORMAL folio would be pinned in place a ZONE_MOVABLE folio would be migrated off first A private node folio should do neither - the pin should fail in place. Add folio_longterm_pin_forbidden() (true for any private node folio) and reject such a pin in check_and_migrate_movable_pages_or_folios() before any isolation, so nothing is migrated. The gup-fast path defers a private folio to the slow path via folio_allows_longterm_pin(). Signed-off-by: Gregory Price --- mm/gup.c | 27 +++++++++++++++++++++++++-- mm/internal.h | 25 +++++++++++++++++++++++++ 2 files changed, 50 insertions(+), 2 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index 1d32e9a3dc79c..a7d4de223785c 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -547,10 +547,10 @@ static struct folio *try_grab_folio_fast(struct page *page, int refs, /* * Can't do FOLL_LONGTERM + FOLL_PIN gup fast path if not in a * right zone, so fail and let the caller fall back to the slow - * path. + * path. Fail for private-node folios here so slow path rejects. */ if (unlikely((flags & FOLL_LONGTERM) && - !folio_is_longterm_pinnable(folio))) { + !folio_allows_longterm_pin(folio))) { folio_put_refs(folio, refs); return NULL; } @@ -2389,12 +2389,35 @@ migrate_longterm_unpinnable_folios(struct list_head *movable_folio_list, return ret; } +/* + * True if any folio sits on a private node whose folios may not be longterm + * pinned. Such folios can neither be pinned nor migrated, so the whole pin + * must fail before migration. Checked before any isolation occurs. + */ +static bool pofs_has_ltpin_forbidden(struct pages_or_folios *pofs) +{ + struct folio *folio; + long i = 0; + + for (folio = pofs_get_folio(pofs, i); folio; + folio = pofs_next_folio(folio, pofs, &i)) { + if (folio_longterm_pin_forbidden(folio)) + return true; + } + return false; +} + static long check_and_migrate_movable_pages_or_folios(struct pages_or_folios *pofs) { LIST_HEAD(movable_folio_list); unsigned long collected; + if (pofs_has_ltpin_forbidden(pofs)) { + pofs_unpin(pofs); + return -EFAULT; + } + collected = collect_longterm_unpinnable_folios(&movable_folio_list, pofs); if (!collected) diff --git a/mm/internal.h b/mm/internal.h index cb9f4a8342e32..85c460296cea1 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -110,6 +110,31 @@ static inline bool page_is_private_managed(struct page *page) return folio_is_private_managed(page_folio(page)); } +/* + * folio_allows_longterm_pin() - may this folio be long-term GUP-pinned? + * + * checks folio_is_longterm_pinnable() rules plus private node permissions. + * private node permission is checked here to resolve circular header + * dependencies in folio_is_longterm_pinnable. + */ +static inline bool folio_allows_longterm_pin(struct folio *folio) +{ + return folio_is_longterm_pinnable(folio) && + !folio_is_private_node(folio); +} + +/* + * folio_longterm_pin_forbidden() - must a longterm pin of this folio fail + * outright (neither pinned in place nor migrated off the node)? + * + * True for any folio on a private node: such memory can be neither pinned + * nor migrated, so the pin must be rejected with the folio left in place. + */ +static inline bool folio_longterm_pin_forbidden(struct folio *folio) +{ + return folio_is_private_node(folio); +} + /* * Maintains state across a page table move. The operation assumes both source * and destination VMAs already exist and are specified by the user. -- 2.53.0-Meta