Re: [PATCH net-next 8/9] selftests: net: RFC6724 rule 5.5 tests

[Simon Horman <horms@kernel.org>]

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
https://sashiko.dev/#/patchset/20260714094030.136317-2-equinox@diac24.net?part=8
---
--- Patch [8]: [PATCH net-next 8/9] selftests: net: RFC6724 rule 5.5 tests ---
commit ae975bc04160e9173acb7759f9db7580aa0ca14e
Author: David 'equinox' Lamparter <equinox@diac24.net>

selftests: net: RFC6724 rule 5.5 tests

This commit introduces a new Python-based test script to verify IPv6 source
address selection logic, focusing on RFC6724 rule 5.5. It also enables
CONFIG_IPV6_SUBTREES in the net selftests config and wires up the script in
the Makefile.

> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> index 708d960ae07d5..c07d2aebad695 100644
> --- a/tools/testing/selftests/net/Makefile
> +++ b/tools/testing/selftests/net/Makefile
> @@ -53,6 +53,7 @@ TEST_PROGS := \
>  	ipv6_flowlabel.sh \
>  	ipv6_force_forwarding.sh \
>  	ipv6_route_update_soft_lockup.sh \
> +	ipv6_saddr_rfc6724rule5p5.py \
>  	ipvtap_test.sh \

[ ... ]

> diff --git a/tools/testing/selftests/net/ipv6_saddr_rfc6724rule5p5.py b/tools/testing/selftests/net/ipv6_saddr_rfc6724rule5p5.py
> new file mode 100644

[Severity: Medium]
Since ipv6_saddr_rfc6724rule5p5.py is added to TEST_PROGS in the Makefile,
the kselftest framework expects it to be directly executable. However, it is
being created with mode 100644 instead of 100755. 

Will this cause the test runner to skip the script or fail to execute it
during automated testing?

> index 0000000000000..682b39ba991da
> --- /dev/null
> +++ b/tools/testing/selftests/net/ipv6_saddr_rfc6724rule5p5.py
> @@ -0,0 +1,231 @@
> +#!/usr/bin/env python3