From: Andrew Morton <akpm@linux-foundation.org>
To: Ye Liu <ye.liu@linux.dev>
Cc: Ye Liu <liuye@kylinos.cn>, David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-mm@kvack.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] tools/mm/page_owner_sort: fix --sort, add module filter, improve usage
Date: Wed, 22 Jul 2026 17:01:02 -0700 [thread overview]
Message-ID: <20260722170102.43620a3d4bec61e738018a82@linux-foundation.org> (raw)
In-Reply-To: <20260722023726.600200-1-ye.liu@linux.dev>
On Wed, 22 Jul 2026 10:37:23 +0800 Ye Liu <ye.liu@linux.dev> wrote:
> This series improves the page_owner_sort tool with a bug fix, a new
> module-name feature, and better usage text.
>
> Patch 1 fixes a long-standing bug where --sort was silently ignored
> when used without a short option (-a, -m, -p, etc.). The COMP_NO_FLAG
> case fell through to COMP_NUM and overwrote the sort conditions
> configured by parse_sort_args().
>
> Patch 2 adds kernel module name support for sort, cull, and filter
> operations. Page owner stack traces already contain module names in
> the [module] format produced by %pS, but page_owner_sort had no way
> to use them. Records without module frames are assigned "vmlinux".
>
> # Aggregate page usage per module
> ./page_owner_sort input.txt output.txt --cull=mod
>
> # Filter to records from xfs module only
> ./page_owner_sort input.txt output.txt --module xfs
>
> # Sort by module name, then by pid descending
> ./page_owner_sort input.txt output.txt --sort=mod,-pid
>
> Patch 3 lists all available sort keys with abbreviations and examples
> directly in the --sort help section so users no longer need to read
> the source to discover valid keys.
Thanks, these sound like nice changes.
AI review mentioned a couple of things, at least one of which appears legit:
https://sashiko.dev/#/patchset/20260722023726.600200-1-ye.liu@linux.dev
next prev parent reply other threads:[~2026-07-23 0:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 2:37 [PATCH 0/3] tools/mm/page_owner_sort: fix --sort, add module filter, improve usage Ye Liu
2026-07-22 2:37 ` [PATCH 2/3] tools/mm/page_owner_sort: add module name sort/cull/filter support Ye Liu
2026-07-23 0:01 ` Andrew Morton [this message]
2026-07-23 8:59 ` [PATCH 0/3] tools/mm/page_owner_sort: fix --sort, add module filter, improve usage Vlastimil Babka (SUSE)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722170102.43620a3d4bec61e738018a82@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=david@kernel.org \
--cc=liam@infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuye@kylinos.cn \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ye.liu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox