From: Andy Chung <Andy.Chung@amd.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-hwmon@vger.kernel.org>, <linux-doc@vger.kernel.org>,
Andy Chung <Andy.Chung@amd.com>
Subject: Re: [PATCH v3 3/4] hwmon: (kb9002) Add driver for Kandou KB9002 retimer
Date: Fri, 24 Jul 2026 13:25:30 +0800 [thread overview]
Message-ID: <20260724052530.2808587-1-Andy.Chung@amd.com> (raw)
In-Reply-To: <3c287fdd-a32d-448b-af04-4d03f895e618@roeck-us.net>
On Tue, 21 Jul 2026 07:43:11 -0700, Guenter Roeck wrote:
> Doesn't this depend on controller PEC support (I2C_FUNC_SMBUS_PEC) ?
> Also, the driver depends on I2C_FUNC_SMBUS_BLOCK_DATA support,
> which is not always available. I would suggest to check for both.
probe() already requires both before setting I2C_CLIENT_PEC:
if (!i2c_check_functionality(client->adapter,
I2C_FUNC_SMBUS_BLOCK_DATA |
I2C_FUNC_SMBUS_PEC))
return -ENODEV;
so the flag is only set on adapters that support PEC. The endianness,
is_visible and temp1_label comments are addressed in v5.
Thanks,
Andy
next prev parent reply other threads:[~2026-07-24 5:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 6:31 [PATCH v3 0/4] hwmon: Add Kandou KB9002 PCIe retimer driver Andy Chung via B4 Relay
2026-07-21 6:31 ` [PATCH v3 1/4] dt-bindings: Add vendor prefix for Kandou Andy Chung via B4 Relay
2026-07-21 8:27 ` Krzysztof Kozlowski
2026-07-21 6:31 ` [PATCH v3 2/4] dt-bindings: hwmon: Add Kandou KB9002 Andy Chung via B4 Relay
2026-07-22 7:41 ` Krzysztof Kozlowski
2026-07-24 7:28 ` Andy Chung
2026-07-21 6:31 ` [PATCH v3 3/4] hwmon: (kb9002) Add driver for Kandou KB9002 retimer Andy Chung via B4 Relay
2026-07-21 14:43 ` Guenter Roeck
2026-07-24 5:25 ` Andy Chung [this message]
2026-07-21 6:31 ` [PATCH v3 4/4] hwmon: (kb9002) Add documentation Andy Chung via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260724052530.2808587-1-Andy.Chung@amd.com \
--to=andy.chung@amd.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox