Re: [PATCH v5 net-next 1/7] ptp: Add ioctls for PHC timestamps with quality attributes

[Jakub Kicinski <kuba@kernel.org>]

On Mon, 27 Jul 2026 14:32:23 +0100 David Woodhouse wrote:
> > > I hate all this line wrapping, btw. I'll defer to the net coding style
> > > if they insist, but my preference would just be just to have longer
> > > lines. Especially when it's a block of assignments like this, the
> > > wrapped form is *much* harder to read.  
> > 
> > This is a long function, probably longer than the coding style
> > suggests. So one option is to move the code within the for loop into a
> > helper. That might then allow unwrapped lines?
> > 
> > That is kind of the point of the line length limit, to make you break
> > code up into lots of small functions which do one thing.  
> 
> Huh? Are we looking at the same function? The version of
> ptp_sys_offset_extended_attrs() I'm looking at, having fixed up the
> gratuitous line wrapping, is about 60 lines — none of which are wider
> than 100 characters. It's a simple setup and then loop over n_samples
> of data captures. A helper function would only serve to obfuscate it.

1. temporary variables for long deref chains help both readability 
   and the compiler
2. our 80 char rule is obviously negotiable.
   But more often than not the best solution is to refactor the code.