From: Fan Gong <gongfan1@huawei.com>
To: <gongfan1@huawei.com>
Cc: <andrew+netdev@lunn.ch>, <august.hewei@huawei.com>,
<chenanwen@huawei.com>, <davem@davemloft.net>,
<edumazet@google.com>, <guoxin09@huawei.com>, <horms@kernel.org>,
<kuba@kernel.org>, <larysa.zaremba@intel.com>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<luosifu@huawei.com>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>, <shijing34@huawei.com>,
<tengpeisen@huawei.com>, <wudi234@huawei.com>,
<wulike1@huawei.com>, <zhoushuai28@huawei.com>
Subject: Re: [PATCH net 1/2] hinic3: Fix skb_checksum_help() failure handling in Tx path
Date: Mon, 3 Aug 2026 14:41:39 +0800 [thread overview]
Message-ID: <20260803064140.1930-1-gongfan1@huawei.com> (raw)
In-Reply-To: <16ed10bb3470f17fe78b0803a8a550c2c720f3e6.1785727595.git.tengpeisen@huawei.com>
> From: Fan Gong <gongfan1@huawei.com>
>
> hinic3_tx_csum() falls back to skb_checksum_help() for unsupported VXLAN
> packets, but ignores its return value. On failure, this can cause packets
> with uncalculated or corrupted checksums to be transmitted.
>
> Fix this by returning the error status of skb_checksum_help() and marking
> the offload as HINIC3_TX_OFFLOAD_INVALID in hinic3_tx_offload() so that the
> packet is properly dropped.
>
> Fixes: 17fcb3dc12bb ("hinic3: module initialization and tx/rx logic")
Oops. This patch was mistakenly sent. We will send a new patch after 24 hours.
prev parent reply other threads:[~2026-08-03 6:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 3:48 [PATCH net 1/2] hinic3: Fix skb_checksum_help() failure handling in Tx path Fan Gong
2026-08-03 3:48 ` [PATCH net 2/2] hinic3: Fix partial RX buffer allocation check during queue setup Fan Gong
2026-08-03 6:41 ` Fan Gong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260803064140.1930-1-gongfan1@huawei.com \
--to=gongfan1@huawei.com \
--cc=andrew+netdev@lunn.ch \
--cc=august.hewei@huawei.com \
--cc=chenanwen@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guoxin09@huawei.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luosifu@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shijing34@huawei.com \
--cc=tengpeisen@huawei.com \
--cc=wudi234@huawei.com \
--cc=wulike1@huawei.com \
--cc=zhoushuai28@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox