From: Steven Rostedt <rostedt@goodmis.org>
To: Andrey Grodzovsky <andrey.grodzovsky@crowdstrike.com>
Cc: <bpf@vger.kernel.org>, <linux-trace-kernel@vger.kernel.org>,
<live-patching@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<mbenes@suse.cz>, <corbet@lwn.net>, <jpoimboe@kernel.org>,
<shuah@kernel.org>, <jolsa@kernel.org>, <mhiramat@kernel.org>,
<stable@vger.kernel.org>, <linux-open-source@crowdstrike.com>
Subject: Re: [RFC PATCH bpf-next v2 1/2] ftrace: deprecate disabling via ftrace_enabled sysctl
Date: Wed, 5 Aug 2026 21:54:36 -0400 [thread overview]
Message-ID: <20260805215436.2a526204@robin> (raw)
In-Reply-To: <20260731175358.3542156-2-andrey.grodzovsky@crowdstrike.com>
On Fri, 31 Jul 2026 13:53:57 -0400
Andrey Grodzovsky <andrey.grodzovsky@crowdstrike.com> wrote:
>
> -static void ftrace_shutdown_sysctl(void)
> +static void __maybe_unused ftrace_shutdown_sysctl(void)
> {
> int command;
>
> @@ -9377,7 +9377,7 @@ static void ftrace_shutdown_sysctl(void)
> # define ftrace_shutdown_sysctl() do { } while (0)
> #endif /* CONFIG_DYNAMIC_FTRACE */
>
> -static bool is_permanent_ops_registered(void)
> +static bool __maybe_unused is_permanent_ops_registered(void)
> {
> struct ftrace_ops *op;
I agree with Sashiko: https://sashiko.dev/#/patchset/20260731175358.3542156-3-andrey.grodzovsky%40crowdstrike.com
Instead of marking with "__maybe_unused", just delete them. If we need
to revent, the revert will add them back.
-- Steve
next prev parent reply other threads:[~2026-08-06 1:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 17:53 [RFC PATCH bpf-next v2 0/2] ftrace: deprecate the ftrace_enabled disable switch Andrey Grodzovsky
2026-07-31 17:53 ` [RFC PATCH bpf-next v2 1/2] ftrace: deprecate disabling via ftrace_enabled sysctl Andrey Grodzovsky
2026-08-06 1:54 ` Steven Rostedt [this message]
2026-07-31 17:53 ` [RFC PATCH bpf-next v2 2/2] selftests/livepatch: update test-ftrace.sh for deprecated ftrace_enabled Andrey Grodzovsky
2026-08-01 0:30 ` Joe Lawrence
2026-08-06 15:31 ` Andrey Grodzovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260805215436.2a526204@robin \
--to=rostedt@goodmis.org \
--cc=andrey.grodzovsky@crowdstrike.com \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=jolsa@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-open-source@crowdstrike.com \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mhiramat@kernel.org \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox