From: "Christian Melendez Nuñez" <chrismelnu@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
airlied@gmail.com, simona@ffwll.ch,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, corbet@lwn.net, skhan@linuxfoundation.org,
"Christian Melendez Nuñez" <chrismelnu@gmail.com>
Subject: [PATCH] PCI: vgaarb: Remove stale "not implemented" notes from docs
Date: Fri, 7 Aug 2026 22:06:39 +0200 [thread overview]
Message-ID: <20260807200639.172487-1-chrismelnu@gmail.com> (raw)
The vgaarb kerneldoc and Documentation/gpu/vgaarbiter.rst both
describe "unlock all" and "target default" as "(TODO: not
implemented yet)". Both are actually implemented already:
- "unlock all" is handled in vga_arb_write() via the "all"
strncmp branch, which releases both VGA_RSRC_LEGACY_IO and
VGA_RSRC_LEGACY_MEM.
- "target default" is handled in the same function via the
"default" strncmp branch, which resolves the target to
vga_default_device().
Drop the stale disclaimers so the documentation matches actual
behavior.
This is my first submission to the kernel; happy to take any
feedback on the patch itself or how I should be doing this.
Signed-off-by: Christian Melendez Nuñez <chrismelnu@gmail.com>
---
Documentation/gpu/vgaarbiter.rst | 9 ++++-----
drivers/pci/vgaarb.c | 7 +++----
2 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/Documentation/gpu/vgaarbiter.rst b/Documentation/gpu/vgaarbiter.rst
index d1e953712cc2..c3a728130b54 100644
--- a/Documentation/gpu/vgaarbiter.rst
+++ b/Documentation/gpu/vgaarbiter.rst
@@ -65,8 +65,7 @@ write
unlock <io_state>
release locks on target
unlock all
- release all locks on target held by this user (not implemented
- yet)
+ release all locks on target held by this user
decodes <io_state>
set the legacy decoding attributes for the card
@@ -74,9 +73,9 @@ write
event if something changes on any card (not just the target)
card_ID is of the form "PCI:domain:bus:dev.fn". It can be set to "default"
- to go back to the system default card (TODO: not implemented yet). Currently,
- only PCI is supported as a prefix, but the userland API may support other bus
- types in the future, even if the current kernel implementation doesn't.
+ to go back to the system default card. Currently, only PCI is supported
+ as a prefix, but the userland API may support other bus types in the
+ future, even if the current kernel implementation doesn't.
Note about locks:
diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c
index c360eee11dd9..4ae96ae60d8b 100644
--- a/drivers/pci/vgaarb.c
+++ b/drivers/pci/vgaarb.c
@@ -1008,10 +1008,9 @@ EXPORT_SYMBOL(vga_client_register);
* poll : event if something change on any card (not just the target)
*
* card_ID is of the form "PCI:domain:bus:dev.fn". It can be set to "default"
- * to go back to the system default card (TODO: not implemented yet).
- * Currently, only PCI is supported as a prefix, but the userland API may
- * support other bus types in the future, even if the current kernel
- * implementation doesn't.
+ * to go back to the system default card. Currently, only PCI is supported
+ * as a prefix, but the userland API may support other bus types in the
+ * future, even if the current kernel implementation doesn't.
*
* Note about locks:
*
--
2.34.1
next reply other threads:[~2026-08-07 20:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 20:06 Christian Melendez Nuñez [this message]
2026-08-07 20:56 ` [PATCH] PCI: vgaarb: Remove stale "not implemented" notes from docs Christian Melendez Nuñez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260807200639.172487-1-chrismelnu@gmail.com \
--to=chrismelnu@gmail.com \
--cc=airlied@gmail.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=skhan@linuxfoundation.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox