From: Christoph Hellwig <hch@lst.de>
To: Md Haris Iqbal <haris.iqbal@linux.dev>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: Re: [v2 for-next 1/3] block: reject unknown status tags in error injection rules
Date: Wed, 2 Sep 2026 15:58:00 +0200 [thread overview]
Message-ID: <20260902135800.GA22743@lst.de> (raw)
In-Reply-To: <20260830012002.80275-2-haris.iqbal@linux.dev>
On Sun, Aug 30, 2026 at 03:20:00AM +0200, Md Haris Iqbal wrote:
> tag_to_blk_status() returns BLK_STS_OK both for the "OK" tag and for a
> tag it does not recognise, so a caller cannot tell the two apart.
> match_status() leaves *status at BLK_STS_OK for an unknown tag and relies
> on error_inject_add() rejecting BLK_STS_OK.
There is no *status yet.
> That holds only while a rule without a status is meaningless. The delay
This reads a lot like AI slop. Can you please self-write a short and
descriptive commit message?
> - * Return BLK_STS_OK for mismatches as this function is intended to
> - * parse error status values.
> - */
> - return BLK_STS_OK;
> + return -EINVAL;
No need for an int return here, this can easily be done with a bool.
next prev parent reply other threads:[~2026-09-02 13:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 1:19 [v2 for-next 0/3] block: delay support for error injection Md Haris Iqbal
2026-08-30 1:20 ` [v2 for-next 1/3] block: reject unknown status tags in error injection rules Md Haris Iqbal
2026-09-02 13:58 ` Christoph Hellwig [this message]
2026-09-02 19:48 ` Haris Iqbal
2026-08-30 1:20 ` [v2 for-next 2/3] block: allow error injection rules to delay bios Md Haris Iqbal
2026-08-30 1:20 ` [v2 for-next 3/3] Documentation: block: document error injection delays Md Haris Iqbal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902135800.GA22743@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=haris.iqbal@linux.dev \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox