Linux Documentation
 help / color / mirror / Atom feed
From: Janani Sunil <janani.sunil@analog.com>
To: "Nuno Sá" <nuno.sa@analog.com>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Olivier Moysan" <olivier.moysan@foss.st.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Linus Walleij" <linusw@kernel.org>,
	"Bartosz Golaszewski" <brgl@kernel.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Michael Walle" <mwalle@kernel.org>,
	"Randy Dunlap" <rdunlap@infradead.org>
Cc: linux@analog.com, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org,
	jananisunil.dev@gmail.com,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Janani Sunil" <janani.sunil@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Andy Shevchenko" <andriy.shevchenko@intel.com>
Subject: [PATCH v8 06/17] iio: adc: ad7768: Validate master clock rate
Date: Wed, 16 Sep 2026 13:13:55 +0200	[thread overview]
Message-ID: <20260916-ad7768-driver-v8-6-27aa24db5225@analog.com> (raw)
In-Reply-To: <20260916-ad7768-driver-v8-0-27aa24db5225@analog.com>

Reject master clock rates outside the limits specified by the device.
External CMOS and LVDS clocks support 1.15 MHz to 34 MHz, while a
crystal requires 8 MHz to 34 MHz.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Janani Sunil <janani.sunil@analog.com>
---
 drivers/iio/adc/ad7768.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/drivers/iio/adc/ad7768.c b/drivers/iio/adc/ad7768.c
index 2c5d0657edf9..7ce0229b5b7c 100644
--- a/drivers/iio/adc/ad7768.c
+++ b/drivers/iio/adc/ad7768.c
@@ -91,6 +91,9 @@
 #define AD7768_SPI_REG_MASK				GENMASK(14, 8)
 #define AD7768_SPI_DATA_MASK				GENMASK(7, 0)
 
+#define AD7768_MIN_MCLK_FREQ_HZ				(1150 * HZ_PER_KHZ)
+#define AD7768_MIN_XTAL_FREQ_HZ				(8 * HZ_PER_MHZ)
+#define AD7768_MAX_MCLK_FREQ_HZ				(34 * HZ_PER_MHZ)
 #define AD7768_MAX_CHANNEL				8
 
 enum ad7768_clock_source {
@@ -810,6 +813,23 @@ static void ad7768_power_off(void *data)
 		dev_err(dev, "Failed to put device to sleep\n");
 }
 
+static int ad7768_validate_mclk_rate(struct device *dev,
+				     const struct ad7768_state *st)
+{
+	unsigned long min_rate = AD7768_MIN_MCLK_FREQ_HZ;
+	unsigned long rate = clk_get_rate(st->mclk);
+
+	if (st->clock_source == AD7768_CLOCK_SOURCE_XTAL)
+		min_rate = AD7768_MIN_XTAL_FREQ_HZ;
+
+	if (rate < min_rate || rate > AD7768_MAX_MCLK_FREQ_HZ)
+		return dev_err_probe(dev, -EINVAL,
+				     "MCLK rate %lu Hz outside %lu-%lu Hz\n",
+				     rate, min_rate, AD7768_MAX_MCLK_FREQ_HZ);
+
+	return 0;
+}
+
 static int ad7768_probe(struct spi_device *spi)
 {
 	unsigned int spi_readback, rev_id;
@@ -884,6 +904,10 @@ static int ad7768_probe(struct spi_device *spi)
 		return dev_err_probe(dev, PTR_ERR(st->mclk),
 				     "Failed to get master clock\n");
 
+	ret = ad7768_validate_mclk_rate(dev, st);
+	if (ret)
+		return ret;
+
 	st->regmap = devm_regmap_init(dev, &ad7768_regmap_bus, spi,
 				      st->chip_info->regmap_config);
 	if (IS_ERR(st->regmap))

-- 
2.43.0


  parent reply	other threads:[~2026-09-16 11:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 11:13 [PATCH v8 00/17] iio: adc: Add AD7768/AD7768-4 ADC driver support Janani Sunil
2026-09-16 11:13 ` [PATCH v8 01/17] iio: adc: adi-axi-adc: Initialize state mutex Janani Sunil
2026-09-16 11:13 ` [PATCH v8 02/17] dt-bindings: iio: adc: Add AD7768 Janani Sunil
2026-09-16 11:13 ` [PATCH v8 03/17] iio: backend: Add support for CRC Janani Sunil
2026-09-16 11:13 ` [PATCH v8 04/17] iio: adc: adi-axi-adc: " Janani Sunil
2026-09-16 11:13 ` [PATCH v8 05/17] iio: adc: Add AD7768 and AD7768-4 core support Janani Sunil
2026-09-21  0:31   ` Jonathan Cameron
2026-09-16 11:13 ` Janani Sunil [this message]
2026-09-16 11:13 ` [PATCH v8 07/17] iio: adc: ad7768: Add power mode helper Janani Sunil
2026-09-16 11:13 ` [PATCH v8 08/17] iio: adc: ad7768: Derive output data rates Janani Sunil
2026-09-16 11:13 ` [PATCH v8 09/17] iio: adc: ad7768: Configure channel sampling profiles Janani Sunil
2026-09-16 11:13 ` [PATCH v8 10/17] iio: adc: ad7768: Add sampling frequency controls Janani Sunil
2026-09-16 11:14 ` [PATCH v8 11/17] iio: adc: ad7768: Add per-channel filter controls Janani Sunil
2026-09-16 11:14 ` [PATCH v8 12/17] iio: adc: ad7768: Wait for digital filters to settle Janani Sunil
2026-09-16 11:14 ` [PATCH v8 13/17] iio: adc: ad7768: Add calibration controls Janani Sunil
2026-09-16 11:14 ` [PATCH v8 14/17] iio: adc: ad7768: Add per-channel conversion delay Janani Sunil
2026-09-16 11:14 ` [PATCH v8 15/17] iio: adc: ad7768: Add VCM regulator support Janani Sunil
2026-09-16 11:14 ` [PATCH v8 16/17] iio: adc: ad7768: Register GPIO auxiliary device Janani Sunil
2026-09-16 11:14 ` [PATCH v8 17/17] Documentation: iio: Add AD7768 Documentation Janani Sunil
2026-09-21  0:37 ` [PATCH v8 00/17] iio: adc: Add AD7768/AD7768-4 ADC driver support Jonathan Cameron
2026-09-21  8:46   ` Janani Sunil
2026-09-22  0:13     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260916-ad7768-driver-v8-6-27aa24db5225@analog.com \
    --to=janani.sunil@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jananisunil.dev@gmail.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@analog.com \
    --cc=mwalle@kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=p.zabel@pengutronix.de \
    --cc=rdunlap@infradead.org \
    --cc=robh@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox