From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 178084EB871 for ; Mon, 28 Sep 2026 17:41:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790617316; cv=none; b=H8S1lMtpYLI1VtICgN0jpbFdEPTiuRNF9+tZvRazbj+KiAo1wEx9rscLIxR6eZKN4Th9ZNhBSPZw/BB1DQ5j1umVg1VT9HhOWCv73e4SRiULLpVWjooEtPA5CpD+6McI/OQUSh81eEgpVAVaM94i619rLZQul66IiC8l7PU+t2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790617316; c=relaxed/simple; bh=4i8baIAc2dkPaONbaLPORXqEKtv4vzfNmgQCV2XNs9M=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=MxgCwW2Ncuj0fJ7/rL4PLzgkDYXxe88Y997iUVRiO1Y7vxF1GqPkeJ3aT7LxlOnC8R3emxGOnGq2wtdQU27I55ojZWTJSImdGYHlIMNudR1+Tx+I5mIt4VsBvZeeyGUzpYj1+WXDuZDsiNx1zHWJeZqm/NiTjEbIMmbkymv5s0M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--smostafa.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=HLcXuZug; arc=none smtp.client-ip=209.85.128.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--smostafa.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HLcXuZug" Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-49e6ba4abdfso35202845e9.1 for ; Mon, 28 Sep 2026 10:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1790617311; x=1791222111; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ZMttkoCzeXLC/JEGKL20pI+XNOolXdLvFIFeMj04zLo=; b=HLcXuZugBloA2b3C43tnwI7Qzd2sVPbUxdX7zXFeEmG12jO2VNPCXIqyGUvMWU2mS/ NopYAG6zsnKpll8eoJfG+eCaSgVfT/mNjtbBteo/RwGwIKOEztSMTx/qYNRhoY/0RVzu 0ZCBj4wQaRfgjTjJ8FfLuNkBDVo+iH8uvdddnG0QL6qE0+7Km/Ph1WEVvnfIjrzRA+iK k6jlFHpj7QumNTvBHQUxQ7lRAV0cZOcwtrs+X8iONyEL/H/vkRdqZfp65YFYjqVdNjWr Y03jyP0HUm5SUVva2B/U9njitjg+tHtVdRwgM7QYCkGSl2rgtv71VfqvhfNp5wTHpMO8 85Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790617311; x=1791222111; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZMttkoCzeXLC/JEGKL20pI+XNOolXdLvFIFeMj04zLo=; b=S+pV2KXwH7MSOE1CKKbZpSmjM86/cDxMkDiumXxDzpV4DprAsBdg73bwjdNZH2Ss3D 2gKg/yu84prWtFjpjy5sebeJGDaiAImv1W04/yaKqlq334e5hixSOydm2UWdZmpsWWIj d34y5wH2764vUETi9IsgNk+Uj1WsEoL7yE6XRXpQ+d0xjwTCFs/1KGlNTpZ1tTMJaqnu dN/CTbg3aHxxGyI14+bZ9ER7/BJRRQNDblyJLMNe9luFr+SbwPBpYtZ0x9Pbz1X+YToF e2+rPGgYk4YcvfLEzSOZtKQ2jDOAMSgENdsb1fVz9Bpl6toxi9g/zj1YOaXS0eYIZ/Po Z40A== X-Gm-Message-State: AFuF++klWcGD1iutMlCY00LRKYo8JHltJT9JHvSPEcBD1hdd/e9+oJ2A /idxyuNJqtlOiZKIfXvUQ8lj8e+bnyTpm8Bp/TeQ0gwEq+F7YWSG2C+/8PDlRN0egTA5IjsKfs5 gRqmM1HLEJ81YrUFQEKqwjzPwX3MhJCGcBquVuoh/7CBZQsHEFMV8iUC8qbimTywrRAI9M7MiJk Ed3upQ1a2tckvcj0HQPPXfIVSaRoUuv0Sca3hPhSBjcQ3PsFvjpE0= X-Received: from wmqb10.prod.google.com ([2002:a05:600c:4e0a:b0:4a0:107:e5c1]) (user=smostafa job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:8b4c:b0:49f:bd3c:bc16 with SMTP id 5b1f17b1804b1-49fe66f4c16mr231430235e9.17.1790617310870; Mon, 28 Sep 2026 10:41:50 -0700 (PDT) Date: Mon, 28 Sep 2026 17:41:10 +0000 In-Reply-To: <20260928174122.3380703-1-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260928174122.3380703-1-smostafa@google.com> X-Mailer: git-send-email 2.56.0.rc1.315.gc6ed9934b7-goog Message-ID: <20260928174122.3380703-4-smostafa@google.com> Subject: [RFC PATCH 03/15] fork: Move vm_stack to the beginning of the stack From: Mostafa Saleh To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, linux-rt-devel@lists.linux.dev Cc: corbet@lwn.net, skhan@linuxfoundation.org, rdunlap@infradead.org, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, akpm@linux-foundation.org, urezki@gmail.com, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, kprateek.nayak@amd.com, kees@kernel.org, david@kernel.org, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, gustavoars@kernel.org, bigeasy@linutronix.de, clrkwllms@kernel.org, David Stevens , Mostafa Saleh Content-Type: text/plain; charset="UTF-8" From: David Stevens The vm_stack struct used to free stacks via an RCU callback is stored directly in the stack being freed. Make sure it's stored at the beginning of the stack regardless of stack growth direction, to avoid faults on partially allocated stacks. Signed-off-by: David Stevens Signed-off-by: Mostafa Saleh --- kernel/fork.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/kernel/fork.c b/kernel/fork.c index ec4431bf309a..473878d7f62f 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -285,7 +285,12 @@ static void thread_stack_free_rcu(struct rcu_head *rh) static void thread_stack_delayed_free(struct task_struct *tsk) { - struct vm_stack *vm_stack = tsk->stack; + struct vm_stack *vm_stack; + + if (IS_ENABLED(CONFIG_STACK_GROWSUP)) + vm_stack = tsk->stack; + else + vm_stack = tsk->stack + THREAD_SIZE - sizeof(*vm_stack); vm_stack->stack_vm_area = tsk->stack_vm_area; call_rcu(&vm_stack->rcu, thread_stack_free_rcu); -- 2.56.0.rc1.315.gc6ed9934b7-goog