From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f34.google.com (mail-pj2-f34.google.com [74.125.227.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BF35544D7E for ; Tue, 29 Sep 2026 15:25:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.162 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790695512; cv=none; b=Uqsk/5ukny2maqSny0NEGVymKUv7ZeEAZ7oHdFDo3IrUisDOGfc/DG2n6xTQL2vscvkqLYjzQtNj3flMYJ4MHMTnnXWNf/jdflgsLJ/TF1/QXhpNg//+8vULsvK6HKAw8S/TFWYBfOxO6RgDSmOmpwncR8t0a06xB2FaBbTqkKg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790695512; c=relaxed/simple; bh=+cEEr6znaNoigBam8Uz4P3hHrN1WO+xiS9Xy1l2461g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FRgFbbGcIg+Vhvg2Sppq57vU04+ZU9EAwujrViTKT31UnaFTYjJUxP9R7zaTj8wJGrXhZY6+Hz51KdHnOBEZ1A1SzXu0GcRjUrj1EKemsudmAByGDYHfeky2HNqug+pWXPVBpZa0HJHxQ6UPBfdr76YcSGZzAtleX809qMta2hs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=r2A/V9iL; arc=none smtp.client-ip=74.125.227.162 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r2A/V9iL" Received: by mail-pj2-f34.google.com with SMTP id d9443c01a7336-2d747eb79f7so19823435ad.1 for ; Tue, 29 Sep 2026 08:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790695501; x=1791300301; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Avi89gTSEr8pephIlQG3FXl3Hk0q/RUFdATAtng+nto=; b=r2A/V9iLUr7hnQULU6G44Xtoap9OJvFZGWqm2BCHKd2X2EJOV/qpdbDJLxHNfAthKa XthnPpuXebFycydcQXBuXC3dw08tyccB+hJs8eqNDVKK9zfm2ue6HluwhitQJt41l2dx Sjs8N11dxzGUXofhk+FDP5QvBXnUjCbxrVpdvwDyhVT5jvJDW0dvs5pDqcRikhq6e6PH QCjo0Twu802fOz5q1NbFeh4THeGSbDRBfSGqwYWFZA2NEwVkduKJxsJjccJfuKfa0P3g URWYGJbeiWiQK28AI6bpB6JhHoAqFTciwjR2WHb1+aOn3XjMBFmds4GAMbmSggveAWub k4yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790695501; x=1791300301; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Avi89gTSEr8pephIlQG3FXl3Hk0q/RUFdATAtng+nto=; b=SCiUQCOGT9ffAteqkWiWyinSD51GrYNEPz8wxtEHaJ/0NqORYp6agUyYAGoevi4tuf MYV4L4DnGzhQ32mcJ9l52lkowbq03bzVbhcA8/L3SCpjO3WnoQ2tLmNGKDmQPuOhBSPl 4HAete3osi/p7Sn6SLNwPpI6q/5AUxRN3g20pT9uXUscm5DzclXNL/a23sSMzRfxASMQ gDCzmzl23t4+AhQW/F7ICiiayqYzmqWejmwUJJ34TpGPsk/miD2/uF5CrZfsoi5SpAjl HGWqTIrXGVwZl0wNdBDhlP6oz6pfEJc6j929DEcRvkfSfcJVKLGm3GiG/5rr3ArxU/85 uIwQ== X-Forwarded-Encrypted: i=1; AKwUvBwHJ54W0eJWuELXhCCuVLWt1KDnnixf6jjPovp00iSPHLLJQl/rXMpf1Olz5uyXZVAOGsh5uR0UYeQ=@vger.kernel.org X-Gm-Message-State: AFq9FYK62boJKUnjYm+vCzmuferdGANa8Z2ngy/2c3AH7IkYERlWSKPi PPdzx8D3Lj0XxOK9SxF4dlwMWZH6FWMyiTMxM5rzNNF64/5p5JJMASxs X-Gm-Gg: AYBFou3uxPy89csrI/vU2i5iuin5+KaqlSL4m/S80zkUVA6msHYQQHetUe5kzfC3HT+ Z7AITsqXUMLXdb61IoShpwwwwIyuqU2NeTOjybayNdh7trIb5ewbIktu7Kok1juRW9vs+lSsuSX +bPiJmCLjiqd1seVCcNHdJzrgo6BM7TqcVCXbd+JgCyoqlB0qjtXIf4/jYSwx/nGdKRyjRMZ7cu yPSagJYP8wq4qqiYr63T0ZpcRd3AXMorwaDk6GRJ/ZhG5dzsI3Djx6PJaA9/zHXLZ9Y0j2pygLT ZpftY4Inr6DK4K5LSed4n26HuVJzJCaL5areuWXmxvAFLMcdxUycrCRreXHC3AJHjv33nVw54/P aOVBdOFr6roklJBDUoEj9xIuK2TdL72jNqSOVALoMu57vkQAthCFuHGxCVjp4jzeyTaraNaMTkx IMkJIidYJ+C7KoYFcDSlfpoLys+DqERGkuj4WlPUwWDcpYE6+2ShevSegsHLBVg8nRCHZF6tos1 OD3tgu0uWRnKueGPnDp+VgTkzb3ZzMp0No6n2zXxjiiZtqA6YzN6SSTq89qrcGdy1JVSOhwwCwj VNnBh7C59MdqLK6mW/0P X-Received: by 2002:a17:902:fc86:b0:2e2:c604:b436 with SMTP id d9443c01a7336-2e2c604cbbcmr25400595ad.49.1790695500578; Tue, 29 Sep 2026 08:25:00 -0700 (PDT) Received: from NV-9MNJ414.tailae2068.ts.net (2001-b011-2005-5b75-0412-f652-3152-53f1.dynamic-ip6.hinet.net. [2001:b011:2005:5b75:412:f652:3152:53f1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2df91476bb4sm59762255ad.83.2026.09.29.08.24.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2026 08:24:59 -0700 (PDT) From: Yiwei Lin To: Andrew Morton , Peter Zijlstra Cc: Yiwei Lin , Ingo Molnar , Juri Lelli , Vincent Guittot , Davidlohr Bueso , Jon Maloy , netdev@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/4] rbtree_test: use rb_add_augmented_cached() for the cached augmented test Date: Tue, 29 Sep 2026 23:24:39 +0800 Message-Id: <20260929152439.91443-5-s921975628@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260929152439.91443-1-s921975628@gmail.com> References: <20260929152439.91443-1-s921975628@gmail.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit insert_augmented_cached() open-codes the descent that the generic rb_add_augmented_cached() helper provides. Use the helper instead, so that rbtree_test covers it: it is what sched/eevdf relies on and nothing in lib/ exercises it today. Signed-off-by: Yiwei Lin Assisted-by: LLM --- lib/rbtree_test.c | 25 ++----------------------- 1 file changed, 2 insertions(+), 23 deletions(-) diff --git a/lib/rbtree_test.c b/lib/rbtree_test.c index c1386d328cfb1..00f62e4f9d10e 100644 --- a/lib/rbtree_test.c +++ b/lib/rbtree_test.c @@ -89,29 +89,8 @@ static void insert_augmented(struct test_node *node, static void insert_augmented_cached(struct test_node *node, struct rb_root_cached *root) { - struct rb_node **new = &root->rb_root.rb_node, *rb_parent = NULL; - u32 key = node->key; - u32 val = node->val; - struct test_node *parent; - bool leftmost = true; - - while (*new) { - rb_parent = *new; - parent = rb_entry(rb_parent, struct test_node, rb); - if (parent->augmented < val) - parent->augmented = val; - if (key < parent->key) - new = &parent->rb.rb_left; - else { - new = &parent->rb.rb_right; - leftmost = false; - } - } - - node->augmented = val; - rb_link_node(&node->rb, rb_parent, new); - rb_insert_augmented_cached(&node->rb, root, - leftmost, &augment_callbacks); + node->augmented = node->val; + rb_add_augmented_cached(&node->rb, root, less, &augment_callbacks); } -- 2.34.1