From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC9913F929A for ; Sat, 3 Oct 2026 09:38:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791020320; cv=none; b=tbpCtdma3wwfOODqOksCEw+311ww4TgGF7+tmk+xfaHHN09tmXX6QicOxwQM3uZFok09PZQFZz8sGlF5f5geUU4cA0Kczt2Goe90Y6CZIfuHsi7+vHwlJmcPmYrFQE5ZJmYtePMaDzAJ/jPsUXkCybMa42f8G4V50jTtMPkMnUQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791020320; c=relaxed/simple; bh=0zGZamDELNJVb3ZPRXbsTVbrc9fNePuUT6QFJ6IALfk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pxoTbX2w9CiKMW26RxG+MGBoxenl7kiCvSQMQ0+ClOEDAAdix+WglhRxX8y9dbpj36FuLinEx8q/uNHp7K4TtXN+EBHH8pXbnUYn4WXVMB17yPeB3i/EUTRdrw4WzV+vC2SUG3mV0dE/3+AYE85IsKvgoDxs3M957BtcQjoYmoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eDqvSE9D; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eDqvSE9D" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-4a11603310fso5112595e9.1 for ; Sat, 03 Oct 2026 02:38:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791020317; x=1791625117; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=c+FUoa7O6EqJD1Y05Er2fK+U4nTQNlxggxHHVkGMPXA=; b=eDqvSE9DMeNkepkb9A+YIjdGGYaEzisl9v9B9LGX72FI/kvPehCzOqJxXC2a2/gJSI 50tO0oJSgaLFrflb1GWxW6LSDegRUkv48HhURw3mUQoAkmuNU9DRypwXTxSkV0YvtKay gkA2ap4fwXuQqi5Ukzt9LiB2nxqG2AqTxTH9ynhtVHsqqw9t+Tx1jzbcmqS3SqqGaRBd VN+vBjGj+ZtdMmW33kbu4UZ6yh5I89PLPdL1AewD8nr4LpLui3hb/F11ZItA33jt1shz 2HOa4gMgaG3lP62e5m8ZUqvGMZKDaJHaXGyP3cf0ZUF4yltCXq4RvLkgqbWuFuHq29Lo MLrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791020317; x=1791625117; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=c+FUoa7O6EqJD1Y05Er2fK+U4nTQNlxggxHHVkGMPXA=; b=sdXQJ6Cl1HCrDvxvOmF+XE3Q1NYAgHILj+DmBSIsH6k0XNsS8/UWT05cyU88P8y3w+ ndD+inUp/3u+/5J0Ga3p3BcDvlQP5QNdSxuEHwx/7m4Wt1S1ZULuyGJ5sSaXr9VQle/2 YktGQh+RHx/ck2VMKWFTkrVHBAtSUUHICU+yFpPN29cm1mGNkxH0ijUeqMPWoojQ/FvS CEMqxusySSB6w/lMn50MMKysrTAZ/I8gnAGvr6UCTKfcTJPUjFFrswA2khCoM6k+3gTN yAlv2q9BXkK1p6Mz0XjMWTDvo7r9kjRRVKlpn4ExTPZO4KcG5W99N9W5tpaGiVDlqipa lB+g== X-Forwarded-Encrypted: i=1; AKwUvByOHZ6aXj+uUalRseX3+yVyMP3DYza2trgWEq75dVN8nVooYvufWTMAqK87PCXg3g2GLEhgYq/ukJA=@vger.kernel.org X-Gm-Message-State: AFuF++lbwPFM5k+11FvTQwi9x1A19i+0TkTIFPiC8ZMWaqW1EhbYScRF yXW671vuTXpmYZkOPbwBYqlZRxzl7/Z2Ttmfhk7+oqjAlnhgmK0/JH/D X-Gm-Gg: AYBFou0AU9d70InzEG+atC+Qjfty1duaz1JXHBDyp32UhxzyBDzFK9jFf73rn3Mmmzf UQE693wr1VdjxhzUOJqxiU7diD/KYOST4MI7jCkVtHUj0tW1R2Zt6EFm+Z+Ue38Zs+d3Qwcoabm jQGoteRaHfQvx0cwNM49KpEZ/kCn+hvS4aBfP9TjM9QOEQ2zIfHT8dRtO/n8p6VOY0T0Dw1kGAE nfgoTKGsaaoJ2qiZ4vAOaRZnJYbp7sI5t3ZYRnUGfL67QctIvkHlq5trF289V+y9AVoBW50anHs WOxsxFX2+oeCnibVd8j729RFYpkVQyhp14wkiCSiEuPxC8JoWUUUqZMzTfXB3Zdfav9/RHow/Pw gU0mYUTCenHamPhSb5h4fpjY/aKwKW61EFjfCSXQMyOytzlEWQ71dPkTsBr3AEKYQxtI9eTPv2J MfY5/OMnqHHoE+QbbWIG5eSIS+MXWY7/z2d9CtPCgj2XxHsVJ1OcYkfxbPDJoxn9ZShY3mKDk4t uH6m2DL44TttRVSvHrnAheuq9Hy/8XKeR2MrQ1vDBe93Kwb3H8w1952zAK8mSu8+Kz0oOVwd02k cuac+K4WNe6r8x7b9Q2Hl0HGhLKTM98EopUCuP4ly69QBwCjG9Unles8QUwmmUiInXguMyCcXzW UDBMdYiE= X-Received: by 2002:a05:600c:46ca:b0:49f:fdca:c361 with SMTP id 5b1f17b1804b1-4a0275790b7mr85076925e9.12.1791020316829; Sat, 03 Oct 2026 02:38:36 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a02-3100-b2e2-2001-c47f-5a89-3d9a-cd2d.310.pool.telefonica.de. [2a02:3100:b2e2:2001:c47f:5a89:3d9a:cd2d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a02770e8f2sm136528375e9.6.2026.10.03.02.38.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 03 Oct 2026 02:38:36 -0700 (PDT) From: Karl Mehltretter To: Russell King , Miguel Ojeda Cc: Karl Mehltretter , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?UTF-8?q?Onur=20=C3=96zkan?= , Arnd Bergmann , Linus Walleij , Christian Schrefl , Bradley Morgan , "Paul E . McKenney" , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-arm-kernel@lists.infradead.org, rust-for-linux@vger.kernel.org, llvm@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] ARM: rust: Enable Rust support for ARMv5TE Date: Sat, 3 Oct 2026 11:38:27 +0200 Message-Id: <20261003093827.77857-3-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20261003093827.77857-1-kmehltretter@gmail.com> References: <20261003093827.77857-1-kmehltretter@gmail.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit HAVE_RUST is currently selected for CPU_32v7 only. The arm-unknown-linux-gnueabi target used for ARMv7 emits ARMv6 instructions (+v6), so it cannot be used for ARMv5. Use rustc's built-in armv5te-unknown-linux-gnueabi target instead. It keeps the Linux EABI (no short enums, unlike the -none-eabi targets) and is soft-float and strict-align. Kernels that also contain ARMv4 or ARMv4T CPUs are built for the lowest architecture and stay excluded. CPU_32v5 also covers the ARMv5T ARM1020. C code is already built with -march=armv5te there, so Rust matches. The kernel crate implements atomics through the C helpers rather than core::sync::atomic, so the missing atomic instructions on ARMv5 do not matter. The only gap was the 2-byte xchg() added by "ARM: cmpxchg: support 2-byte xchg() on pre-ARMv6 CPUs". core::sync::atomic types up to 32 bits still compile on this target, but LLVM lowers them to __sync_* libcalls which the kernel does not provide. Nothing in the tree uses them. Such code would fail to link on ARMv5 while it links on ARMv7. Tested on v7.3-rc1 with clang 22.1.8, rustc 1.99.0 and bindgen 0.73.2 in QEMU versatilepb and on a Microchip SAM9X75 Curiosity board (both ARM926EJ-S). The Rust samples, all Rust KUnit suites and the doctests pass. Link: https://lore.kernel.org/rust-for-linux/CACRpkdYF0sVB2-qgy=GzETSR3+2sagVQPGdunDQDJrn8KqJorA@mail.gmail.com/ Link: https://lore.kernel.org/rust-for-linux/b13d37bd-ec68-4713-94e5-e9ed4d6a6354@gmail.com/ Assisted-by: LLM Signed-off-by: Karl Mehltretter --- Documentation/rust/arch-support.rst | 2 +- arch/arm/Kconfig | 2 +- arch/arm/Makefile | 4 ++++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Documentation/rust/arch-support.rst b/Documentation/rust/arch-support.rst index 4f980815e92a..2193d8e1e156 100644 --- a/Documentation/rust/arch-support.rst +++ b/Documentation/rust/arch-support.rst @@ -15,7 +15,7 @@ support corresponds to ``S`` values in the ``MAINTAINERS`` file. ============= ================ ============================================== Architecture Level of support Constraints ============= ================ ============================================== -``arm`` Maintained ARMv7 Little Endian only. +``arm`` Maintained ARMv5TE and ARMv7, Little Endian only. ``arm64`` Maintained Little Endian only. ``loongarch`` Maintained \- ``riscv`` Maintained ``riscv64`` and LLVM/Clang only. diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index ffbc7f386131..f6b14d9f0e1f 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -138,7 +138,7 @@ config ARM select MMU_GATHER_RCU_TABLE_FREE if SMP && ARM_LPAE select HAVE_REGS_AND_STACK_ACCESS_API select HAVE_RSEQ - select HAVE_RUST if CPU_LITTLE_ENDIAN && CPU_32v7 && !KASAN + select HAVE_RUST if CPU_LITTLE_ENDIAN && (CPU_32v7 || (CPU_32v5 && !CPU_32v4T && !CPU_32v4)) && !KASAN select HAVE_STACKPROTECTOR select HAVE_SYSCALL_TRACEPOINTS select HAVE_UID16 diff --git a/arch/arm/Makefile b/arch/arm/Makefile index 573813ef5e77..ef94eae1f047 100644 --- a/arch/arm/Makefile +++ b/arch/arm/Makefile @@ -150,7 +150,11 @@ endif KBUILD_CPPFLAGS +=$(cpp-y) KBUILD_CFLAGS +=$(CFLAGS_ABI) $(CFLAGS_ISA) $(arch-y) $(tune-y) $(call cc-option,-mshort-load-bytes,$(call cc-option,-malignment-traps,)) -msoft-float -Uarm KBUILD_AFLAGS +=$(CFLAGS_ABI) $(AFLAGS_ISA) -Wa,$(arch-y) $(tune-y) -include $(srctree)/arch/arm/include/asm/unified.h -msoft-float +ifdef CONFIG_CPU_32v5 +KBUILD_RUSTFLAGS += --target=armv5te-unknown-linux-gnueabi +else KBUILD_RUSTFLAGS += --target=arm-unknown-linux-gnueabi +endif CHECKFLAGS += -D__arm__ -- 2.39.5 (Apple Git-154)