From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4058A4B99D9 for ; Sun, 18 Oct 2026 14:22:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792333347; cv=none; b=cqvQl2m3x3yKbBmN3NzuSkhwBzzqmN700NScqzx8D0S8T/g+G3Z3tbBy0Mygc2QeqbTgM11MhBkTYGILWnihqVAyB3k8PNQsGMi/XfvuV1xjO7a3UPAwhB+2rSbKDd1DOn/HV/AKHpFYvJXzfWEhrPGKMZB8mtRXwh5FyV9z+mM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792333347; c=relaxed/simple; bh=VxOR/bCOVZkIw8KCvCXFIKKLhAZToFxwLD68oZ1t8k4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pWEzxpIh3F8ZkzDllbtK/p+Mq+N0wKzu3Dyjb/acxO5ed2p+8PTiylXj/KbGMXzX5ZtX/xyuFSUaTvEN+d+L94ZcXtXpFOkHHqmwxckkmKhRrjtmE3s+sDvFDoADkuONqPKRP+42pM7i1/SLle+wRlMT/ajpLMsAQYWpilkhpRA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rRs2J1mh; arc=none smtp.client-ip=209.85.128.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rRs2J1mh" Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-8871ada1a26so7234007b3.1 for ; Sun, 18 Oct 2026 07:22:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792333345; x=1792938145; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UUlIHV3Y/eyAzB+bNbhTZ2vi/60rQRriQzgaW1YAFSU=; b=rRs2J1mhqX5bwvPb6V4+pexg8CQt1Ndrl+2w8jGT1f/UgBbHjmuBChrRU1yjBWexBI PCP8r76kksd7zais4alPXwAM3qz73W7QaJS2CQ9hivfH+XysG5M71gvNBeWUrO3MtZbC 1q2Prcsvo3n7sZa2j3HD7a0UMfHNqiGmg/hbpV7k9wD7yG84p2iSpaI+dGskxVknsJ9P sHFJJa6o+dQNfR2Thhb7TQxk5dwHm03rcKhTP3sVMEeeUhcvLCFDhKUHwZ9H7RoIWGWd uxsZIgVbrrHaza7AH18of/YR+I2aURtK7f94AYlO8Eudkym32j2hWJ3Dcs57xLcnKkWo z2HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792333345; x=1792938145; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UUlIHV3Y/eyAzB+bNbhTZ2vi/60rQRriQzgaW1YAFSU=; b=ydxqIbcyR1E1JbKjNs0upmiwp6fopeKTEjmPvruDJV6kRjAgAOhSdhtdPtiGAjHIKD wLjF8caiyyJ8kXTLTdYG8hmT1QBBNpcnCxhaU8rhenyV2TkGoovZO4WL2KC60qCpBVIG tfysnARhX17GU7DngSziKGdQdO9+E9/AQ99p0sTVccMrkCs2YHFxwIYdHOi3DPdlwRi2 /y8q8SJpga60uC4CinFPI5JIwUdYql77hZSyf47CGGLKTna4Oi03Yf7YScy/hQRuzjjQ lHSeUMgackx5Tl2mhjFg9qfHF84qFiNgxhRBe3ylkgy5mn1NX+7XZ//8xDYTOObxTCGo KLNw== X-Forwarded-Encrypted: i=1; AKwUvByubmkDpNArBMqKwSH7KGcUJMxSMAFFyCiH0ELyAK572SvNIRRXS61D3IGhB4yZn+4cWFjFFuzSTTM=@vger.kernel.org X-Gm-Message-State: AFq9FYIV8uEpd/5r/AQ40gk0g+rUMHgXvJzPGlcnr7yGqO2hAQeIrB4d hX3duzNLOB1u0VM/RGoz9VxdcPjmcMAi4otidWksMjxhTRv3EPqAfHII X-Gm-Gg: AYBFou3/R6mcKXhbwG58drwxxhywc6tHoObazuuTGS5rSk8n/j44TN2U7lilO4n5KTQ pBLXJNKb74XAMbd/v/MhXve+undTQ1Z9BJpC5Jq3XIlnOBPDpcA5SBsjJ7Y6EHW5rsibynTh0ib SfDLvBAWliPVUx10jE/w2vMmTlIqWgZ1UoOdGfEsDYxNycW4C+rtEMN1Aas20I3Idvw7JelGCev 9r/2kGu7BRpJo5dFTmVsXf6xUylzKXwjIs73REWttd26LRJ5cngFCSPfW0WT7lb0bg50DRGwcl8 AaudJk6DYeFru0QlatIwT68OiWXzPBccp3BgJaGWmD2SLOdrxFj8dqnKfNwyTM6+zk6wsztb09f LnszJGdLdSwp/NK9NLPDvibwQMjMBrpDa9oTjM/IJLYczHS7anlEnHNwQXr5mpec6K058w3EAuo TQnJkxZ8czxHirA2R+/ObEKfit4FG5ghRmxzxBJ9HRSZcwesqROpF94gf4MYjAxYougcT2141Wi JvVROpbKwSyyJyZV4qXeqynqq9bFyFCvjdZ8fKx0v+Dci5Huv8HI1fW8aZ5/sPdWzBuiiGFUQ/B u8zWpRAkYQKqd3GvXYeVH+5JVAw5EuIVG1lBSzg= X-Received: by 2002:a05:690c:a75a:b0:8b0:b1dd:c09a with SMTP id 00721157ae682-8b0f21bbb9cmr11567547b3.64.1792333345125; Sun, 18 Oct 2026 07:22:25 -0700 (PDT) Received: from localhost (108-93-236-139.lightspeed.chtnsc.sbcglobal.net. [108.93.236.139]) by smtp.gmail.com with ESMTPSA id 00721157ae682-8b0e590b586sm29403807b3.31.2026.10.18.07.22.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2026 07:22:24 -0700 (PDT) From: Matt Turner Date: Sun, 18 Oct 2026 10:22:02 -0400 Subject: [PATCH v3 2/5] alpha: stop storing the user stack pointer in pt_regs Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261018-alpha-perf-regs-v3-v3-2-52be85332c57@gmail.com> References: <20261018-alpha-perf-regs-v3-v3-0-52be85332c57@gmail.com> In-Reply-To: <20261018-alpha-perf-regs-v3-v3-0-52be85332c57@gmail.com> To: Richard Henderson , Magnus Lindholm Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-perf-users@vger.kernel.org, Ian Rogers , Matt Turner X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3175; i=mattst88@gmail.com; h=from:subject:message-id; bh=VxOR/bCOVZkIw8KCvCXFIKKLhAZToFxwLD68oZ1t8k4=; b=owGbwMvMwCW25rVmCc8sv+mMp9WSGLKuXOOs62SZ+eg+F3emovLvc1Mz5mwpdUi/ZRqwW6/3Q fvLmRWbOj6yMIhxMcwUU2SJW6/IMqttx1Kf09K/YOawMoEMkRZpYAACFga+3MS8UiMdIz1TbUM9 QyBDxygeIqfHoJFZXFyaWqSbVlDkkJdfkliSmZ9XrJdfkJpXkF6gl5aZVpKRkV9UnAo0Qi8vtcT U1dHNyNDAxNLRwszJwtHUxNnZydDJzdHR2dXJyNLcxMDZ0tHE1dKcgYtTAOYa2eOMDKfWPxaP0Y lbXMtktYfl3XzliNrA1KyEX0bl71dap5yWm87IcLtcp+5uhnTgoZ3yfCy+iceVn847089z8XSCH fNXphRlfgA= X-Developer-Key: i=mattst88@gmail.com; a=openpgp; fpr=3BB639E56F861FA2E86505690FDD682D974CA72A Nothing reads pt_regs->usp now that user_stack_pointer() uses the PCB. Drop the stores, which saves a PAL_rdusp call on every syscall, and give the field back its old name. Assisted-by: Claude:claude-opus-5-5 Reviewed-by: Magnus Lindholm Tested-by: Magnus Lindholm Acked-by: Ian Rogers Signed-off-by: Matt Turner --- arch/alpha/include/uapi/asm/ptrace.h | 2 +- arch/alpha/kernel/asm-offsets.c | 1 - arch/alpha/kernel/entry.S | 5 ----- arch/alpha/kernel/traps.c | 8 -------- 4 files changed, 1 insertion(+), 15 deletions(-) diff --git a/arch/alpha/include/uapi/asm/ptrace.h b/arch/alpha/include/uapi/asm/ptrace.h index 9d86b2a1526e..72ed913a910f 100644 --- a/arch/alpha/include/uapi/asm/ptrace.h +++ b/arch/alpha/include/uapi/asm/ptrace.h @@ -43,7 +43,7 @@ struct pt_regs { unsigned long trap_a1; unsigned long trap_a2; /* This makes the stack 16-byte aligned as GCC expects */ - unsigned long usp; + unsigned long __pad0; /* These are saved by PAL-code: */ unsigned long ps; unsigned long pc; diff --git a/arch/alpha/kernel/asm-offsets.c b/arch/alpha/kernel/asm-offsets.c index c89792c86044..22ed3c975b1c 100644 --- a/arch/alpha/kernel/asm-offsets.c +++ b/arch/alpha/kernel/asm-offsets.c @@ -30,7 +30,6 @@ static void __used foo(void) DEFINE(HAE_CACHE, offsetof(struct alpha_machine_vector, hae_cache)); DEFINE(HAE_REG, offsetof(struct alpha_machine_vector, hae_register)); - DEFINE(PT_REGS_USP, offsetof(struct pt_regs, usp)); DEFINE(TI_FLAGS, offsetof(struct thread_info, flags)); DEFINE(TI_SYSCALL_WORK, offsetof(struct thread_info, syscall_work)); diff --git a/arch/alpha/kernel/entry.S b/arch/alpha/kernel/entry.S index bfa116d455fb..790389a15c3c 100644 --- a/arch/alpha/kernel/entry.S +++ b/arch/alpha/kernel/entry.S @@ -476,11 +476,6 @@ entSys: ldq $1, 0($sp) /* syscall nr from saved r0 */ stq $1, 8($sp) /* regs->r1 = shadow syscall nr */ - mov $0, $8 - call_pal PAL_rdusp - stq $0, PT_REGS_USP($sp) - mov $8, $0 - lda $8, 0x3fff bic $sp, $8, $8 diff --git a/arch/alpha/kernel/traps.c b/arch/alpha/kernel/traps.c index cfaef96c4ce8..5882c65b7ef1 100644 --- a/arch/alpha/kernel/traps.c +++ b/arch/alpha/kernel/traps.c @@ -30,12 +30,6 @@ #include "proto.h" -static __always_inline void alpha_snapshot_usp(struct pt_regs *regs) -{ - if (user_mode(regs)) - regs->usp = rdusp(); -} - void dik_show_regs(struct pt_regs *regs, unsigned long *r9_15) { @@ -186,7 +180,6 @@ do_entArith(unsigned long summary, unsigned long write_mask, { long si_code = FPE_FLTINV; - alpha_snapshot_usp(regs); if (summary & 1) { /* Software-completion summary bit is set, so try to emulate the instruction. If the processor supports @@ -208,7 +201,6 @@ do_entIF(unsigned long type, struct pt_regs *regs) { int signo, code; - alpha_snapshot_usp(regs); if (type == 3) { /* FEN fault */ /* Irritating users can call PAL_clrfen to disable the FPU for the process. The kernel will then trap in -- 2.55.0