From: Joel Fernandes <joelagnelf@nvidia.com>
To: Zqiang <qiang.zhang@linux.dev>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Yonghao Zhang <hyz3367@gmail.com>,
paulmck@kernel.org, frederic@kernel.org,
neeraj.upadhyay@kernel.org, josh@joshtriplett.org,
boqun@kernel.org, urezki@gmail.com, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
corbet@lwn.net, skhan@linuxfoundation.org, rcu@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] doc: Fix stale RCU_GP_WAIT_FQS value in stallwarn.rst
Date: Sun, 18 Oct 2026 20:03:41 -0400 [thread overview]
Message-ID: <20261019000341.GB123764@joelbox> (raw)
In-Reply-To: <f6509555c4e1abfc3bf67643d568887a7f9b7215@linux.dev>
On Fri, Oct 16, 2026 at 11:54:39PM +0000, Zqiang wrote:
> >
> > On 10/13/26 11:31 PM, Yonghao Zhang wrote:
> >
> > >
> > > The sample "kthread starved" splat in stallwarn.rst shows
> > > RCU_GP_WAIT_FQS(3), which was correct when the example was captured,
> > > but has been stale since commit fea3f222d352 ("rcu: Record ->gp_state
> > > for both phases of grace-period initialization") inserted
> > > RCU_GP_ONOFF (3) and RCU_GP_INIT (4) ahead of it, shifting
> > > RCU_GP_WAIT_FQS from 3 to 5.
> > >
> > > Update the sample output to show (5), matching the current tree.h
> > > values and the later "kthread timer wakeup" example in the same file.
> > >
> > > Fixes: fea3f222d352 ("rcu: Record ->gp_state for both phases of grace-period initialization")
> > > Signed-off-by: Yonghao Zhang <hyz3367@gmail.com>
> > >
> > Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
> Reviewed-by: Zqiang <qiang.zhang@linux.dev>
Applying for 7.5 with the tags, thank you!
Joel Fernandes
>
> Thanks
> Zqiang
>
> > Thanks.
> >
> > >
> > > ---
> > > Documentation/RCU/stallwarn.rst | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/RCU/stallwarn.rst b/Documentation/RCU/stallwarn.rst
> > > index b888e13c02a4..049694b9c681 100644
> > > --- a/Documentation/RCU/stallwarn.rst
> > > +++ b/Documentation/RCU/stallwarn.rst
> > > @@ -379,7 +379,7 @@ If the relevant grace-period kthread has been unable to run prior to
> > > the stall warning, as was the case in the "All QSes seen" line above,
> > > the following additional line is printed::
> > >
> > > - rcu_sched kthread starved for 23807 jiffies! g7075 f0x0 RCU_GP_WAIT_FQS(3) ->state=0x1 ->cpu=5
> > > + rcu_sched kthread starved for 23807 jiffies! g7075 f0x0 RCU_GP_WAIT_FQS(5) ->state=0x1 ->cpu=5
> > > Unless rcu_sched kthread gets sufficient CPU time, OOM is now expected behavior.
> > >
> > > Starving the grace-period kthreads of CPU time can of course result
> > >
> > --
> > ~Randy
> >
prev parent reply other threads:[~2026-10-19 0:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 6:31 [PATCH] doc: Fix stale RCU_GP_WAIT_FQS value in stallwarn.rst Yonghao Zhang
2026-10-14 16:07 ` Randy Dunlap
2026-10-16 23:54 ` Zqiang
2026-10-19 0:03 ` Joel Fernandes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261019000341.GB123764@joelbox \
--to=joelagnelf@nvidia.com \
--cc=boqun@kernel.org \
--cc=corbet@lwn.net \
--cc=frederic@kernel.org \
--cc=hyz3367@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-doc@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=neeraj.upadhyay@kernel.org \
--cc=paulmck@kernel.org \
--cc=qiang.zhang@linux.dev \
--cc=rcu@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox