From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793820816; b=pCpIeRWweKTB7bk6rqSbXJlXf5XAma8R7CZNrbGevNaqF+m2m4vq+c2nKmOKuk5VmNC9 U+l2WhD1AdlLCkHc5fV+YdSws2+suT/kxumaz0wM6eTt2aB0Ah6/OZk4UoY/AL+0p2INx HzgKflp3ganXsAyLW5AAd8eSVNHIeRVDXVO0fgW1U0cqJ/ZP+xfa9pu6euWuXeAPLlKEo xcsc6LGKNTaJyGSsVQKIjo4i/OrKLKHQIy2j+h7HNmE/drwttmcVB9eudSJPHbso9/uig rv0/+P6Bxq6q8GseDvKLV7fehhsWSfTbN/TnYh22x0iPtfsfr262w1jSUnbIg4iExuw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793820816; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID: In-Reply-To:References:MIME-Version:Content-Type:X-Mailer: X-Developer-Signature:X-Developer-Key:Content-Transfer-Encoding; bh=DA4U0m1CHtqk19BjQpd8o6fqolui3N68b+LzMS0kHTM=; b=eT7UGgztnP4n97xkv+xFlGWvFRdukh4s21zEe1mHWAbHwiddwJ1uqmpbflcyAn3opGGJ 3bCSdmHgQxaXjmVRQyoicD1pdfSKgXI4w1o1eThZnj6NufShmEnr0axVsEjP5IquLgCst czQBxdr6yw1y6ZJ8Ek8+pFzfmaHA96lWX3pCVIDxKAO1EPG9xiQAulchFPLlxJ/I1JEN/ glKPH9OOCudleuRE2Yilxi/9zkmm45KANoKYj6QzCectT9N9NW8Vt7fEqL8Hp9QinU6JW mcBjlkFFkF8RXNhNZPpKW1VTbGSxQWiGcAZfMAjJzEggQHohT63qUXT35PxrOfGQvEw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=j7j0ZanL; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81434606E4EF; Wed, 4 Nov 2026 19:33:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=j7j0ZanL Received: by smtp.kernel.org (Postfix) with ESMTPSA id 469811F000C1; Wed, 4 Nov 2026 19:33:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793820816; bh=DA4U0m1CHtqk19BjQpd8o6fqolui3N68b+LzMS0kHTM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=j7j0ZanLPklc+rmEtTC9tqa+2dSI7D6dXyu+DrqtYaDUdnd/LUj9Nl96xu78fe9Bo ONceYKUXd7LLhykczcAo+XYQQdU9VnrXajvQp3bn0Dx2obQg2y/zyeUEJ6MGrrd+wb VFFMAfxyna6jHA221MxfRrjIXNI6FL+oxmibL6KxIcoNWzorQNT0Y26Aft3Ya4mbr3 nEmiL8AySa8xnCAjT+Cv2punHBoTSIUYIamvaW3tloiPYrIvszTdT7r1QGguINjG6f bcI8iyL36J/mqPEgKJA4dznZGpZUrnKnHaFZ18d22HlBAx+3YRJXUlVnXMqpcyi0q5 yU4xE/E1WQohQ== From: Christian Brauner To: linux-fsdevel@vger.kernel.org Cc: Linus Torvalds , Jann Horn , Josef Bacik , Chris Mason , Jeff Layton , NeilBrown , Eric Dumazet , Thomas Gleixner , Al Viro , Jonathan Corbet , Christoph Hellwig , Greg Kroah-Hartman , Joel Granados , Kees Cook , Jan Kara , Jan Kara , linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-um@lists.infradead.org, linux-wireless@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, platform-driver-x86@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, netfilter-devel@vger.kernel.org, dri-devel@lists.freedesktop.org, ibm-acpi-devel@lists.sourceforge.net, jfs-discussion@lists.sourceforge.net, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-cifs@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, sparclinux@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-doc@vger.kernel.org, linux-serial@vger.kernel.org, linux-atm-general@lists.sourceforge.net, Takashi Iwai , linux-input@vger.kernel.org, linux-raid@vger.kernel.org, linux-ext4@vger.kernel.org, linux-modules@vger.kernel.org, linux-debuggers@vger.kernel.org, "Christian Brauner (Amutable)" , Chuck Lever Subject: [PATCH RESEND v2 17/23] fs/proc/vmcore: let procfs copy out reads Date: Wed, 4 Nov 2026 20:33:22 +0100 Message-ID: <20261104-work-procfs-core-v2-17-76ace653a773@kernel.org> In-Reply-To: <20261104-work-procfs-core-v2-0-76ace653a773@kernel.org> References: <20261104-work-procfs-core-v2-0-76ace653a773@kernel.org> X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.17-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=2514; i=brauner@kernel.org; h=from:subject:message-id; bh=4DsZPmVa7FbNwblf9/47/FvU9tv8FcehxAI70fSkduE=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMWS9bm8tNg9c6qctsMOowaPB8dhVZm5nNklTraOzXbl+K qxoZzXqKGVhEONikBVTZHFoNwmXW85TsdkoUwNmDisTyBAGLk4BmAjbPYZ/pqcffG5u2ZjJWLlK bcnXA3+MpivM3Mhaxf3f+9SDHRe4pjIy3HaafDysJch9dWB2tJTnbNlTQdMUvf8XW3KJ126efym NFwA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit Implement ->proc_read_buf() so procfs copies what is read to userspace after it unpinned the entry. __read_vmcore() fills procfs' buffer through a kvec iov_iter. So a read goes through that buffer now instead of straight from the old memory into the reader's, which is what splice() did already. mmap() isn't affected. On ppc64 a machine check while reading the old memory used to be recovered through the exception table of copy_to_user(), by accident. copy_oldmem_page() copies with _copy_mc_to_iter() now, so a read through procfs' buffer recovers from it as well. The buffer is 128k, which keeps the entry pinned for one such piece at a time, and /proc/vmcore asks for PROC_ENTRY_FULL_READS so that a larger read is filled in pieces. kexec-tools treats a short read of it as fatal. A read that faults on its buffer in a later piece returns the pieces before it now instead of failing with -EFAULT. fadump removes /proc/vmcore when its memory is released and that no longer waits for a reader that faults on its buffer. Signed-off-by: Christian Brauner (Amutable) --- fs/proc/vmcore.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c index ccb795b85509..1c1e71231f4e 100644 --- a/fs/proc/vmcore.c +++ b/fs/proc/vmcore.c @@ -27,6 +27,7 @@ #include #include #include +#include #include #include #include @@ -427,9 +428,14 @@ static ssize_t __read_vmcore(struct iov_iter *iter, loff_t *fpos) return acc; } -static ssize_t read_vmcore(struct kiocb *iocb, struct iov_iter *iter) +static ssize_t read_vmcore(struct file *file, char *buf, size_t count, + loff_t *ppos) { - return __read_vmcore(iter, &iocb->ki_pos); + struct kvec kvec = { .iov_base = buf, .iov_len = count }; + struct iov_iter iter; + + iov_iter_kvec(&iter, ITER_DEST, &kvec, 1, count); + return __read_vmcore(&iter, ppos); } /** @@ -709,9 +715,11 @@ static int mmap_vmcore(struct file *file, struct vm_area_struct *vma) #endif static const struct proc_ops vmcore_proc_ops = { + .proc_flags = PROC_ENTRY_FULL_READS, .proc_open = open_vmcore, .proc_release = release_vmcore, - .proc_read_iter = read_vmcore, + .proc_read_buf = read_vmcore, + .proc_read_size = SZ_128K, .proc_lseek = default_llseek, .proc_mmap = mmap_vmcore, }; -- 2.53.0