From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.210.70 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794356650; b=1MXvn7UmplOd69+vhlcch3kCt9Avdg9KlHgo/k03+hWpYqBdtdHy2cJdDK+oo7cOuxd1 KPWhqR4BoSuP7NWZnP2ALdrT6/mtL2LxYaIvjMfQTjz1LhUypAaSfU37m2VxCeRP7f0yc Jv8Db8/ex4eJdEIknqQ0tVs3KQsIOOZ1ZBcuY3MMzsMO/okmRAsnak8YBPS7EbW8mAkNf +u+HwkPUwPE4/PyFt7urL7syiqN6RbifYh9ISvf64sWEUvtJ9nmh5l7dFstKQxx1dYJno ss4AkJ1eb8jLnC9rTDtdtXYSr9fnmOhcreBgxYZgIyMzky4Y9XAog8XG19ki3obgvLg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794356650; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=8hRjHNT+bDawf2n+fS4w87yYb1rrNIQllzNnUpN3o7M=; b=5mxr4iaXlmxqXyzaUQzv8gps/asl5S4fIT74yAVau4HYRkOwBRlc+S6eN9gSn6rzOMTt qmAh18ACI51k5Hh9fNW7jQx28kV1KV5pZ/JAWl9TaNm7l3HR01CTcdPZmibg+RLbMpp+t +Eg06wyoTwLx/bf/7O57PopDJjdnzOsmhe5hNPnAK/dtvW3MpLTJIxPeOGm2HC6LYRppU 8a7W+6zPlWwtGDnNqga2IzhrR9OlLtir/DCFkxmYt3ufno8+QnosDma+saOROzlUOE7sr ohMdFu1h79VmIrQTECgn0d29adnJHy1VLTc5hna6EjCIs4V93Szc7oJeiJ0rgR/5xrg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--dmatlack.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=NKjKVt5f; arc=none smtp.remote-ip=209.85.210.70 Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94B36606A334 for ; Wed, 11 Nov 2026 00:24:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 94B36606A334 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--dmatlack.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=NKjKVt5f Received: by mail-ot1-f70.google.com with SMTP id 46e09a7af769-824cc5f7fcdso3319715a34.3 for ; Tue, 10 Nov 2026 16:24:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1794356648; x=1794961448; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8hRjHNT+bDawf2n+fS4w87yYb1rrNIQllzNnUpN3o7M=; b=NKjKVt5f9XkfM7CuoIFDdkDQlHdtM0MKBEpsfvLZnwD9mUhdF49nghThwKCbg/tjdK hgfZT8pLuZum4ckqFw7SeWG0cAhsoRsXo83NIItg2fmhSWU9fXZgGxQwiwOgZtcyrvHJ 73giSbswvAqqY7Na+Ukrt6vD3KdnejPS3opbZbg2vaB7dZzSAOQ7xRqyUohhuSOsT9oI Cn80aCNPHwY0z/1hteK/M3Po8gexhZdicfOfS3XXdFjNML2utHPdR4Be98oqzhvmZ5g/ DGkADkkHabW+2AMRdEzsWN9Zsf/TGw5rTbQZljgGIebkGHoGyLULbzVzbfD9fV7Ruydk mZAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794356648; x=1794961448; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8hRjHNT+bDawf2n+fS4w87yYb1rrNIQllzNnUpN3o7M=; b=wHzjOFqUA6xEkPU/U0eSdDi8YD0V9qrAobnw381kH3LpBUQmOOXrN3RZe8FZp9QjEN S3gJbccgcUPOqIEOZxJvY9edNkrT/KtzNeXLC8Wh0WW8+/rjC2U41fXw3Qj7rabzyheg YbQsErVBpvuzkr0Nf8tJn4B4S3lvTNtqjANJ5FV1WOF6vBmmO4gpdx66wxD8wygutHnZ fPnJNhRkTERZhh/9sc1L4xXp5SzShAo7S3K/EbsnrVR4PnMtgbm9R4r6quqqJ3sgO2pB qb+57SYKA1SqOCC5Oess0Rxv1AR4wb1kIgQccTdxN+buweIc3GkYaCaM5k30xIgo3ywg /JFQ== X-Forwarded-Encrypted: i=1; AL+hErG/U8XvekrtKNOiDdbGUdVWIjwDmE4I7C5+hgp+jerZ184TUaGdRUMFOGL5EuhjyBuvs7k+Ucwtsw0=@vger.kernel.org X-Gm-Message-State: APuU4Z8HaelmP7DRn2NsrEApmOLpIAj7ZIKbC+CeqxZRxcK6qGoG+PPW gavjYVkgKsz/t6oG4vIrqfT9GGvp72qU+bLVlxE7gOLRUfZ+5IXJiJk63k5pHWFnjmJWNzOqD7b CPR3+OkbXYtRghg== X-Received: from iohf2-n2.prod.google.com ([2002:a05:6602:a5c2:20b0:9e3:4940:4cc3]) (user=dmatlack job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6808:13cc:b0:567:fd8f:403b with SMTP id 5614622812f47-56b97b17653mr680403b6e.42.1794356648195; Tue, 10 Nov 2026 16:24:08 -0800 (PST) Date: Wed, 11 Nov 2026 00:23:39 +0000 In-Reply-To: <20261111002358.1842967-1-dmatlack@google.com> X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261111002358.1842967-1-dmatlack@google.com> X-Mailer: git-send-email 2.56.0.542.g3ef89b7020-goog Message-ID: <20261111002358.1842967-2-dmatlack@google.com> Subject: [PATCH v4 01/19] liveupdate: Remove the list of steps from luo_preserve_file()'s comment From: David Matlack To: kexec@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Cc: Alexander Graf , Andrew Morton , Baolin Wang , Christian Brauner , David Hildenbrand , Hugh Dickins , Jonathan Corbet , "Liam R. Howlett" , Lorenzo Stoakes , Michal Hocko , Mike Rapoport , Pasha Tatashin , Pratyush Yadav , Randy Dunlap , Samiullah Khawaja , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , David Matlack Content-Type: text/plain; charset="UTF-8" Remove the numbered list of steps from the kernel-doc comment of luo_preserve_file(), along with the sentence that introduces it, which repeats the first sentence of the previous paragraph. The list only restates what the code does, and goes stale whenever the code changes. Suggested-by: Pratyush Yadav (Google) Signed-off-by: David Matlack --- kernel/liveupdate/luo_file.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/kernel/liveupdate/luo_file.c b/kernel/liveupdate/luo_file.c index a39992da504f..a42b60356d52 100644 --- a/kernel/liveupdate/luo_file.c +++ b/kernel/liveupdate/luo_file.c @@ -214,18 +214,6 @@ static bool luo_token_is_used(struct luo_file_set *file_set, u64 token) * unpreserved or successfully finished in the next kernel, preventing the file * from being prematurely destroyed. * - * This function orchestrates the first phase of preserving a file. It performs - * the following steps: - * - * 1. Validates that the @token is not already in use within the file_set. - * 2. Ensures the file_set's memory for files serialization is allocated - * (allocates if needed). - * 3. Iterates through registered handlers, calling can_preserve() to find one - * compatible with the given @fd. - * 4. Calls the handler's .preserve() operation, which saves the file's state - * and returns an opaque private data handle. - * 5. Adds the new instance to the file_set's internal list. - * * On success, LUO takes a reference to the 'struct file' and considers it * under its management until it is unpreserved or finished. * -- 2.56.0.542.g3ef89b7020-goog