From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.218 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794553675; b=H3PX4u3WHDZkmm0U1YPNaHlccr4XlsBBWtgSNrV1SzBdfQARqUVR/rpNJ8vl1wALRYEX r2yKlE/GG4ksMc9o2H4I9WRa8yleK6OIRm3Ty2RLbPOiXqyR/4xhVwNkCBwT3rIdr1IeT dkqarOMpnyPZRlZVmRMiUdOO6NFpjab7bPf6/hTmDCEG6CoDEYzJ43mfcN7XmXiJqqD3Q zKNiJapmKxjvEzw2rbsadafRlVrMXwTqWc1GHXMFyLUSGreWvdF4y+lXFAVvMRpMck4YJ B3EaHzBCJwYOzmkKZHdIetuso1BE6s0yqoglffA/BbDSFoujzsif1RjghMI3QrXT7+A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794553675; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=Y5c7omIAneSZefT9dfmZbyqefVv1syPKSN+V7Y2Kmgg=; b=LLss1tk5LI7HUbv9Uz8Wq3hMDycV8PL1ybaI+l7+kaQP7RQg3YMXHKCGRgssvUOKLGWR MyBHNRCgM71I8Ks2AO8HiLYMvsbBhCi6NKAkQwDreB0UYSkvs2lG5twSlUYcYZpKrIJL+ 2w2Gm4XzffcjNGs9Y3eUTkkDOmg/Ur1UURzt5V2ZSDwxmquecabXzCSVO4utIhmjBL5cA T/dYsDvnAmZcA6gEAfzj8fRBrY/XC1bsVTY7skW3ciF3zQIZa9V7Z8jZa1ldPDSnWzv8Y wgjZBvb+KAq+TWbgy480kGDb0cWbJA4DKxf+yq8C7HY3Rf62bo5JS4FFsf3xYMw5JPQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=RSa8yJKW; arc=none smtp.remote-ip=95.215.58.218 Received: from mta1.migadu.com (out-218.mta1.migadu.com [95.215.58.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEBFF606A8A9 for ; Fri, 13 Nov 2026 07:07:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org AEBFF606A8A9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=RSa8yJKW X-Envelope-To: linux-doc@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=wlo9vUd47ggH1TaP4OgfLMAqjSMe1zHTjJ3E73DhNZo=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794553673; v=1; x=1795158473; b=RSa8yJKWKSA+JxYP4Pun8TgADBCQWOoF3MI11B0wxXP5X/Mcy/Am+sMm4fE7S2HtKaZ0QCra IVmRmQPzqnewVGrHmsm6wzSyerWAQJEFjLjAZgVysHKB3PGW9EPtILBYI3R1WFYyPbPLcRWNQeI CPHjrrSAqs1plnmG1hjJ/Tpk= X-Envelope-To: linux-doc@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id c98b5bb3fe46bebc; Fri, 13 Nov 2026 07:07:52 +0000 X-Mizu-Trace-ID: c98b5bb3fe46bebc X-Migadu-Flow: FLOW_OUT From: Mengmeng Zhao To: Christoph Hellwig , Anuj Gupta , Nitesh Shetty , Jens Axboe , Sumit Semwal , christian.koenig@amd.com, Philipp Stanner , Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , tytso@mit.edu, Andreas Dilger , Baokun Li , Ojaswin Mujoo , "Ritesh Harjani (IBM)" , Zhang Yi , asml.silence@gmail.com, Jonathan Corbet , Shuah Khan , Randy Dunlap Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-doc@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, Li Wang , Mengmeng Zhao Subject: [RFC PATCH v2 4/8] blk-mq: factor out a dma-buf bio refusal helper Date: Fri, 13 Nov 2026 15:06:17 +0800 Message-ID: <20261113070621.273953-5-mengmeng.zhao@linux.dev> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261113070621.273953-1-mengmeng.zhao@linux.dev> References: <20261113070621.273953-1-mengmeng.zhao@linux.dev> X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mengmeng Zhao Move the dma-buf integrity check out of blk_mq_submit_bio() into bio_dmabuf_should_reject(), so that such checks have one place to grow. No functional change. Signed-off-by: Mengmeng Zhao Signed-off-by: Li Wang --- block/blk-mq.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 5ae22d556540..887d5cc5bb5e 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -3099,6 +3099,20 @@ static bool bio_unaligned(const struct bio *bio, struct request_queue *q) return false; } +/* + * A dma-buf bio carries a driver-private map instead of pages, so the block + * layer cannot generate or verify integrity metadata for it. Only reject when + * it would have to do that itself, not if the submitter attached its own + * payload or if generation or verification is turned off for the device. + */ +static bool bio_dmabuf_should_reject(struct bio *bio) +{ + if (!op_is_dmabuf(bio->bi_opf)) + return false; + return bdev_has_integrity_csum(bio->bi_bdev) && + (bio_integrity_action(bio) & BI_ACT_CHECK); +} + /** * blk_mq_submit_bio - Create and send a request to block device. * @bio: Bio pointer. @@ -3160,15 +3174,7 @@ void blk_mq_submit_bio(struct bio *bio) goto queue_exit; } - /* - * The block layer cannot generate or verify PI for a dma-buf bio, as - * that walks the data pages. Only fail the bio if it needs that, not - * if the submitter attached its own integrity payload or if PI - * generation or verification is turned off for the device. - */ - if (unlikely(op_is_dmabuf(bio->bi_opf) && - bdev_has_integrity_csum(bio->bi_bdev) && - (bio_integrity_action(bio) & BI_ACT_CHECK))) { + if (unlikely(bio_dmabuf_should_reject(bio))) { bio_endio_status(bio, BLK_STS_NOTSUPP); goto queue_exit; } -- 2.43.0