From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.219.45 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794835249; b=orwp743gC9uqje4amYxZdhKZK8vXvcNJAe5g0fj8L+aGJ3zAUvgwhOka8P9dz1AEYlyE Q9HLECkR8QxNJ98aJH8NIJi2c5I6LwJYdfTem5j3uown0BrL/mckD0UrChci9CcDsGTia hsJxxaSfK75vNfNh3IuAdCr5luqJoSKYx5/m5mpiHg7S/P+qoZHTRXZHCQ/UOJrWU3tzc Z7g5Nj4roMtq23BG3OWg+Dbgi/uOTKNqUvtUidmdDOg9kUNLdMx2MTzUoVuI/ZpP/jhPK TiPySJsKl5SiBUgasdx5zC0p+zRTpAod0FEM2U6jRgp/FYKO2HEcBD2/dgjIt4RrmZw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794835249; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Received:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=pW6Ljdl+VPjn0HqbJ5aXeG19kylCTPtUMbKY6fBA+PE=; b=w5psYRwDytnhsEzemGnYZXwUDnNvJBEy1ah2PezUiYTmCoxvBa1hmZzbGGfkO+de5ZF/ Gw0tex/W36QMD1RegbnYU2z159ETD90dXACK0qzLqMyeJqLD/O7w2kU06KJ6tD+dkJthL 14HwA+sBOSsJDpU02iogNh0oYkSj5p5tBAr4dccQ93ekNDWpZqHbMU1k7Be2FBAO5YY+S UywPVrOkhOXEsX21Vsi3gSn6SV7D8gQ+wVR3EtyncuhYsBIzY+V1UQi7wNgGocRwZIFse kpcrGtMjGwF8xpUW8EAtuTft9ZpW+kHWYTnAEePYyGYAOczpUAVnqolJkvtcutAxydQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=F00eXo5h; arc=none smtp.remote-ip=209.85.219.45 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41FC9606A32C for ; Mon, 16 Nov 2026 13:20:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 41FC9606A32C Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=F00eXo5h Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-91f23ddf32fso23834676d6.0 for ; Mon, 16 Nov 2026 05:20:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1794835248; x=1795440048; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=pW6Ljdl+VPjn0HqbJ5aXeG19kylCTPtUMbKY6fBA+PE=; b=F00eXo5hK7MhiGIzcy2xEZvXaOlU++0SsxWdg8F2eYgLj0IP/wqxNHSj70WYC1UCbD vmKPyn8zqLHpLHOvxkTPyXLn/laMAvSaSbXM05SN4tjv6Cx+GcVaR0GxUXpMgXzGykx3 FokKvpAfMx6w/qg4Q5h79shuv6MexzGsY/vmut+9b8A8pQsaE0GfSqy0kYc2aGWEaEae 3xYzyobXgBsc03sh3wdT6H/0kLtFYOlPUaVehm8clJUf4d9zj9Hfn5kvjyTiGQDD3sEC 6wk4kHeXw7a4jDhfFMIm7aNEb1ZQhwAt5xztT2KrBS1HRA1ERCFKDcAKt5g1NH70HZ/q daJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794835248; x=1795440048; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pW6Ljdl+VPjn0HqbJ5aXeG19kylCTPtUMbKY6fBA+PE=; b=HrwQMIUFi1SE3oASATUzBUiU8Sr9ZfcVSaEuUhcbPMaZczalZHD/QpEF1BqSSthUny 36gG4T93LxTd+ALFlNF5n+0RJyso0CyXOZqbVJlCPzU5gLdpWk6sq6gZOFvJnsh74GOL K7rrwYG2RPQbIiT5TA2+JR3cJrPk48mNzDgSzJQPVJeq45hv6lPpVIZ1k0LAabp2LjKR Gzr+GxtdmBjomlmFvYuUq/miiPFxwQrKeyrpz9ZsnzLRoP79bHPQy6HJMrVCIFRluQJp JJHgLPDS3Amky1/voA9AKH8nvG2RlM/NZrrFew70XTNTct1pEJs1wIwh0VG+j7rV0zRc Cbsg== X-Forwarded-Encrypted: i=1; AL+hErGrD9btSTe4WMVOAfC9Bg6UucH88brbfgpxXNL/b+I//gD/nZ8adURepfT/wYv2rFoSWbnM2/jwgaQ=@vger.kernel.org X-Gm-Message-State: APuU4Z9o9jYYCRYWWgprM4BIxjzIzG/uMGzkHZpGx+jaE4HkVUjWlvA4 ykfJKhqAjPFcMqUxYUnsbSD+cKCDDYmH0qW3kw9t1NwtaYKfnFjX4XBROSX8MB9bcec= X-Gm-Gg: AZFdTZfhyZaCP9Xw5f2nB/eb6Cml+Dv4wR2BsuNYPk0QTsfut9QgxNsbB2or+2m5u8r vRX7QBmhwwu0ySzcFKogmonl97T4+OwJI92hO8kIux4E9IYit2M5ZSJXcNjTFMaMO4Tc9Utbtz3 nPB9y8LROHG6zLBSqiy/jLmOmj+tWZlMjdhdUsPzMAbOgZbPr1tmb8oajWAgQLGAfQgtcBs6i6X h/PYyvnicjzo4nr0zg1O0ligue5HwqkWrOME/WO3JkLqLWWxhtN5PBE7CEpGtt2pDqGcyU2Y4Ag cpgs/Lvo6+c2ASb4QvSFFiFvJostr5Y3w/Gvo5sgeYSaKEuDvLwuylsVjkgRH0ebOsRE39yfunQ sgyThkqSjqBhLlwPSqiepQr3VNWjvkeostOWeSVBXnqlnlnZIx8YFpN/+YhO7SMRFVpKwFsinoN UJLFnkYN5i1cxlT6OGCe3t/jMHw9wvhBDyJGCh3VfECVr2ZbegvWQ8n+b9e+JvUo4i5AIWhyGmt qJgzGZBP2XFBPHjbWBvZMDAJoULyNCHfx9NL2IOFW8+Ap/0cU7e3pv9Ws3BuSJk/yvuaQ4T6x1+ Er9S4Q== X-Received: by 2002:ad4:5744:0:b0:91f:3230:2a4 with SMTP id 6a1803df08f44-91f32300351mr126741416d6.53.1794835247815; Mon, 16 Nov 2026 05:20:47 -0800 (PST) Received: from ziepe.ca ([142.166.156.71]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-91f23d7ba48sm85758876d6.28.2026.11.16.05.20.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 05:20:47 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1xSwda-00000009KhK-1awf; Mon, 16 Nov 2026 09:20:46 -0400 Date: Mon, 16 Nov 2026 09:20:46 -0400 From: Jason Gunthorpe To: "Aneesh Kumar K.V" Cc: Leon Romanovsky , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Dmitry Torokhov , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Johannes Berg , Jonathan Corbet , Shuah Khan , Randy Dunlap , Bjorn Helgaas , "Joerg Roedel (AMD)" , Suravee Suthikulpanit , Vasant Hegde , Will Deacon , Robin Murphy , David Woodhouse , Lu Baolu , Johan Hovold , Eric Dumazet , Marcel Holtmann , Luiz Augusto von Dentz , Nipun Gupta , Nikhil Agarwal , Pieter Jansen van Vuuren , linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, iommu@lists.linux.dev Subject: Re: [PATCH 17/17] PCI: Replace untrusted state with device trust Message-ID: <20261116132046.GI2532299@ziepe.ca> References: <20261105-device-trust-core-v1-0-1e536825b4eb@nvidia.com> <20261105-device-trust-core-v1-17-1e536825b4eb@nvidia.com> X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Nov 16, 2026 at 06:38:25PM +0530, Aneesh Kumar K.V wrote: > > +static inline bool > > +pci_dev_default_is_restricted(const struct pci_dev *pdev) > > +{ > > + enum device_trust_policy policy = READ_ONCE(pdev->dev.trust_policy); > > + > > + return policy == DEVICE_TRUST_POLICY_DISABLED || > > + policy == DEVICE_TRUST_POLICY_ADVERSARY; > > +} > > + > > Could you clarify how this series will work alongside device acceptance > and private-memory access? > > In particular, what should callers of device_cc_accepted() use under > this model? Who is calling device_cc_accepted? I thought we were keeping that internal to the DMA PI? > My understanding is that trust describes the operating > policy, not TDISP acceptance or DMA access to private memory. Right. > Therefore, > neither FULL nor ADVERSARY alone indicates whether a device can access > private memory? Right. Once you turn on TDISP you effectively activate DMA, just like turning on the IOMMU. Userspace then gets to choose how the rest of the system behavess. You can still run a strict viommu with an adversarial driver even if you enabled TDISP and can DMA to all memory. I don't know if many people would choose that combination, but it is there. > You also mention that once a trust level other than DISABLED is set, it > cannot be changed during the device's lifetime. If a device initially > operates in ADVERSARY mode and later attestation justifies FULL > operation, is that transition intentionally unsupported for the existing > device object? As documented, unbind/rebind and reset preserve the > committed level. I think it should only be for the duration of a bound driver? > It would help to describe how the trust framework fits together with > those separate mechanisms, including which pieces are left for follow-up > series. The main thing it brings is the pause to allow userspace to measure the device and put it into RUN if it so chooses before any driver is bound. It doesn't change how any of the DMA or TDSIP flows work. Jason