From: Jakub Kicinski <kuba@kernel.org>
To: Tianyi Gao <tianyi@cloudflare.com>
Cc: Stanislav Fomichev <sdf.kernel@gmail.com>,
bpf@vger.kernel.org, netdev@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Vladimir Vdovin <deliran@verdict.gg>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Donald Hunter <donald.hunter@gmail.com>,
Eduard Zingerman <eddyz87@gmail.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Jiri Olsa <jolsa@kernel.org>,
Emil Tsalapatis <emil@etsalapatis.com>,
Ihor Solodrai <ihor.solodrai@linux.dev>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Magnus Karlsson <magnus.karlsson@intel.com>,
Tushar Vyavahare <tushar.vyavahare@intel.com>,
Jason Xing <kerneljasonxing@gmail.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Madalin Bucur <madalin.bucur@nxp.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Shuah Khan <shuah@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Chris J Arges <carges@cloudflare.com>,
Jakub Sitnicki <jakub@cloudflare.com>,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, llvm@lists.linux.dev,
kernel-team@cloudflare.com, Tianyi Gao <tianyi.gao@linux.dev>
Subject: Re: [PATCH bpf-next 00/15] xdp: add SKB core extensions to keep RX metadata until skb creation
Date: Mon, 16 Nov 2026 14:27:10 -0800 [thread overview]
Message-ID: <20261116142710.347e8571@kernel.org> (raw)
In-Reply-To: <CAG4wq-dhd5a5zxQcSShaKifYd2z+pMpHaCYtZJRX1QCxEH4dfg@mail.gmail.com>
On Sun, 15 Nov 2026 23:36:34 +0000 Tianyi Gao wrote:
> On Sun, 15 Nov 2026 11:39:02 -0800 Jakub Kicinski wrote:
> > On Wed, 11 Nov 2026 01:07:46 +0000 Tianyi Gao wrote:
> > > - On veth, an XDP program removes software GSO from the peer, limits
> > > its MTU, and can copy skbs from the peer.
> >
> > Could you remind us why you XDP_REDIRECT xdp_frames to the veth
> > if you end up allocating the skb on the veth, anyway?
> >
> > I thought that was to let veth run its own prog before skb is allocated
> > but you're saying that you want to avoid veth having a prog, so clearly
> > it's not that.
>
> Thank you for your comment!
>
> XDP_REDIRECT into a veth without a program on it has been supported
> since commit 0e672f306a28 ("veth: check for NAPI instead of xdp_prog
> before xmit of XDP frame"). There is demand for it [1].
>
> With or without a program on the veth, and on cpumap, this series
> keeps the RX metadata from the NIC until the skb is built.
>
> [1] https://lore.kernel.org/all/20210416175929.35c3c389@carbon/
Perhaps I'm slow but I don't see how this answers my question.
I read your reply as "the config is supported and my team uses it".
The question is _why_ you use it. Let's leave the cpumap case aside,
you provided no legitimate reason why having an XDP prog in that case
is a problem. With veth - you are right that attaching XDP causes
problems for pure skb traffic. For veth cases, however, there's no
strong reason to delay the skb allocation. Hence my question.
Why not let the driver allocate the skb if we know that the
redirect target will need to allocate one, anyway.
Since your patches are not a natural / clean extension of the existing
infrastructure - we should step back and make sure the use case is
practically justified.
next prev parent reply other threads:[~2026-11-16 22:27 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 3:56 [PATCH bpf-next 00/15] xdp: add SKB core extensions to keep RX metadata until skb creation Tianyi Gao
2026-11-10 3:56 ` [PATCH bpf-next 01/15] xdp: reserve an skb core extension area after the xdp_frame Tianyi Gao
2026-11-10 13:10 ` Jesper Dangaard Brouer
2026-11-10 3:57 ` [PATCH bpf-next 02/15] net: dpaa, dpaa2: clear the skb core extension flag Tianyi Gao
2026-11-13 12:02 ` Loktionov, Aleksandr
2026-11-10 3:57 ` [PATCH bpf-next 03/15] xdp: add kfuncs to store RX hash and VLAN tag Tianyi Gao
2026-11-10 14:13 ` Jesper Dangaard Brouer
2026-11-10 3:57 ` [PATCH bpf-next 04/15] xdp: add a kfunc to delete skb core extension entries Tianyi Gao
2026-11-10 14:20 ` Jesper Dangaard Brouer
2026-11-13 12:04 ` Loktionov, Aleksandr
2026-11-10 3:57 ` [PATCH bpf-next 05/15] xdp: add a kfunc to store the RX checksum status Tianyi Gao
2026-11-10 3:57 ` [PATCH bpf-next 06/15] selftests/bpf: Test the skb core extension kfuncs Tianyi Gao
2026-11-10 3:57 ` [PATCH bpf-next 07/15] xdp: set skb RX metadata from the skb core extension area of xdp_frame Tianyi Gao
2026-11-10 3:57 ` [PATCH bpf-next 08/15] selftests/bpf: Test RX metadata on skbs built from xdp_frames Tianyi Gao
2026-11-10 3:57 ` [PATCH bpf-next 09/15] xdp: add the skb-ext-pass XDP feature and warn without it Tianyi Gao
2026-11-10 3:57 ` [PATCH bpf-next 10/15] xdp: warn on XDP_PASS with stored values when XDP runs on an skb Tianyi Gao
2026-11-10 4:53 ` bot+bpf-ci
2026-11-10 3:57 ` [PATCH bpf-next 11/15] ice: set skb RX metadata from the skb core extension area of xdp_buff Tianyi Gao
2026-11-10 3:57 ` [PATCH bpf-next 12/15] selftests: drv-net: xdp: test the stored RX metadata on XDP_PASS Tianyi Gao
2026-11-10 3:57 ` [PATCH bpf-next 13/15] xdp: add kfuncs to load the stored RX metadata Tianyi Gao
2026-11-13 12:05 ` Loktionov, Aleksandr
2026-11-10 3:57 ` [PATCH bpf-next 14/15] selftests/bpf: Test the load kfuncs on cpumap and veth Tianyi Gao
2026-11-13 12:06 ` Loktionov, Aleksandr
2026-11-10 3:57 ` [PATCH bpf-next 15/15] docs: net: document the skb core extension area Tianyi Gao
2026-11-10 4:53 ` bot+bpf-ci
2026-11-10 13:01 ` [PATCH bpf-next 00/15] xdp: add SKB core extensions to keep RX metadata until skb creation Jesper Dangaard Brouer
2026-11-11 0:00 ` Stanislav Fomichev
2026-11-11 1:07 ` Tianyi Gao
2026-11-11 22:25 ` Stanislav Fomichev
2026-11-11 23:46 ` Tianyi Gao
2026-11-15 19:39 ` Jakub Kicinski
2026-11-15 23:36 ` Tianyi Gao
2026-11-16 22:27 ` Jakub Kicinski [this message]
2026-11-12 0:34 ` Alexei Starovoitov
2026-11-12 14:55 ` Tianyi Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116142710.347e8571@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrii@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=carges@cloudflare.com \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=deliran@verdict.gg \
--cc=donald.hunter@gmail.com \
--cc=eddyz87@gmail.com \
--cc=edumazet@kernel.org \
--cc=emil@etsalapatis.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ihor.solodrai@linux.dev \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=ioana.ciornei@nxp.com \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=justinstitt@google.com \
--cc=kernel-team@cloudflare.com \
--cc=kerneljasonxing@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=lorenzo@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=madalin.bucur@nxp.com \
--cc=magnus.karlsson@intel.com \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=razor@blackwall.org \
--cc=rdunlap@infradead.org \
--cc=sdf.kernel@gmail.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=song@kernel.org \
--cc=tianyi.gao@linux.dev \
--cc=tianyi@cloudflare.com \
--cc=tushar.vyavahare@intel.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox