From: Conor Dooley <conor@kernel.org>
To: lhart.opensource@witekio.com
Cc: "Guenter Roeck" <linux@roeck-us.net>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
"Flaviu Nistor" <flaviu.nistor@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: Add TI TPS389006/TPS389008
Date: Wed, 18 Nov 2026 18:03:21 +0000 [thread overview]
Message-ID: <20261118-mystify-both-ec4feb95933a@spud> (raw)
In-Reply-To: <20261117-lhart-dev-tps38900x-v2-1-e5730523d3ee@witekio.com>
[-- Attachment #1: Type: text/plain, Size: 4635 bytes --]
On Tue, Nov 17, 2026 at 03:45:35PM -0800, Luna Hart via B4 Relay wrote:
> From: Luna Hart <lhart.opensource@witekio.com>
>
> Add a binding for the TI TPS389006 and TPS389008 I2C voltage
> supervisors and monitors, which provide 6 and 8 voltage inputs
> respectively. Each input may be described by an optional child node,
> containing additional properties including the label and voltage
> monitoring range. Inputs that are not connected can be marked with
> status set to "disabled".
>
> Based on an earlier binding by Flaviu Nistor.
Perhaps a co-developed-by for that?
>
> Signed-off-by: Luna Hart <lhart.opensource@witekio.com>
> ---
> .../devicetree/bindings/hwmon/ti,tps389006.yaml | 114 +++++++++++++++++++++
> 1 file changed, 114 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tps389006.yaml b/Documentation/devicetree/bindings/hwmon/ti,tps389006.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..2a26f6623adf06d1df38d5bc3683b5d2e06f3c0f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tps389006.yaml
> @@ -0,0 +1,114 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/ti,tps389006.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI TPS389006/TPS389008 voltage supervisor and monitor
> +
> +maintainers:
> + - Luna Hart <lhart.opensource@witekio.com>
> +
> +description: |
> + Voltage supervisor and monitor from TI (TPS389006, TPS389008) on I2C bus.
> +
> + Datasheets:
> + https://www.ti.com/lit/ds/symlink/tps389006.pdf
> + https://www.ti.com/lit/ds/symlink/tps389006-q1.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - ti,tps389006
> + - ti,tps389008
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> + description: NIRQ fault interrupt output (active low).
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
Missing a vdd-supply here I think?
pw-bot: changes-requested
> +
> +patternProperties:
> + "^channel@[0-7]$":
> + description:
> + A monitored input. Inputs that are not connected can be marked with
> + status set to "disabled".
> + type: object
> + additionalProperties: false
> +
> + properties:
> + reg:
> + description: Input index, 0 for MON1 up to 7 for MON8.
> + enum: [ 0, 1, 2, 3, 4, 5, 6, 7 ]
Or else, min: 0 and max: 7.
> +
> + label:
> + description: Name of the input source.
> +
> + ti,vrange-multiplier:
> + description:
> + Voltage monitoring range of the input. 1 selects 0.2V to 1.475V in
> + 5mV steps, 4 selects 0.8V to 5.5V in 20mV steps. If absent, the
> + range programmed in the device is used.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [ 1, 4 ]
Would this be more naturally expressed as "ti,vrange-steps-microvolt"
and be "5000" and "20000"? microvolt because that's the standard
voltage suffix we have, and in the actual range in case another device
in the future wishes to use this binding but has different scaling.
Cheers,
Conor.
> +
> + required:
> + - reg
> +
> +required:
> + - compatible
> + - reg
Probably the supply is also required.
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + const: ti,tps389006
> + then:
> + patternProperties:
> + "^channel@[67]$": false
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + voltage-monitor@30 {
> + compatible = "ti,tps389008";
> + reg = <0x30>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <12 IRQ_TYPE_LEVEL_LOW>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + channel@0 {
> + reg = <0x0>;
> + label = "input0";
> + ti,vrange-multiplier = <4>;
> + };
> +
> + channel@1 {
> + reg = <0x1>;
> + label = "input1";
> + ti,vrange-multiplier = <1>;
> + };
> +
> + channel@7 {
> + reg = <0x7>;
> +
> + status = "disabled";
> + };
> + };
> + };
>
> --
> 2.47.3
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-11-18 18:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 23:45 [PATCH v2 0/2] hwmon: Add support for TI TPS389006/TPS389008 Luna Hart via B4 Relay
2026-11-17 23:45 ` [PATCH v2 1/2] dt-bindings: hwmon: Add " Luna Hart via B4 Relay
2026-11-18 18:03 ` Conor Dooley [this message]
2026-11-17 23:45 ` [PATCH v2 2/2] hwmon: (tps38900x) Add driver for " Luna Hart via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118-mystify-both-ec4feb95933a@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=flaviu.nistor@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lhart.opensource@witekio.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox