Linux Documentation
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Willy Tarreau <w@1wt.eu>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Sasha Levin <sashal@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Theodore Ts'o <tytso@mit.edu>,
	David Hildenbrand <david@kernel.org>,
	workflows@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] docs: submitting-patches: ask bug fixes for their user-visible impact
Date: Thu, 19 Nov 2026 14:54:50 +0200	[thread overview]
Message-ID: <20261119125450.GJ162713@unreal> (raw)
In-Reply-To: <av7tY64O34gbJvH_@1wt.eu>

On Thu, Nov 19, 2026 at 01:36:51PM +0100, Willy Tarreau wrote:
> On Thu, Nov 19, 2026 at 01:04:32PM +0100, Krzysztof Kozlowski wrote:
> > On 19/11/2026 12:19, Leon Romanovsky wrote:
> > > On Thu, Nov 19, 2026 at 11:13:57AM +0100, Krzysztof Kozlowski wrote:
> > >>>> v1: https://lore.kernel.org/r/20261116191436.188098-1-sashal@kernel.org
> > >>>>
> > >>>>  Documentation/process/coding-assistants.rst  |  6 +++--
> > >>>>  Documentation/process/submitting-patches.rst | 23 ++++++++++++++++++++
> > >>>>  2 files changed, 27 insertions(+), 2 deletions(-)
> > >>>
> > >>> Sasha,
> > >>>
> > >>> Since you're already making changes in that area, could you add a sentence
> > >>> asking reporters to provide the full dmesg stack trace?
> > >>
> > >> If so, then trimmed. We do not need all addresses and registers and the
> > >> [time markers], but rather the calltrace from decode_stacktrace.sh.
> > > 
> > > Regarding time markers, I agree. However, addresses are an important part of
> > > debugging information. These bugs are rare, but addresses are still useful for
> > > identifying incorrect pointer arithmetic or pointer assignments.
> > 
> > Depending on the case, e.g. some driver lockdep reports don't need them.
> > NULL ptr usually as well. The point is that dmesg should be trimmed to
> > relevant and useful information. If that includes addresses for that
> > particular case, then of course these should stay. But 75% of data here
> > in commit like 5b4bd13e0552926648a46c2c9a12a24dfaee3715 is not really
> > helping. In the same time undecoded call trace is useless, because these
> > addresses depends on the build. The dmesg should simply be the decoded
> > stacktrace ONLY for this case.
> 
> Then just the 2-3 lines capture inline, and the full log attached could
> please everyone ?

I don't think so, because this information is also important to preserve in the
Git history. I received offline feedback that the full stack is useful for
backporting and customer support, too. Sometimes the dmesg output is similar
enough to recognize, but differs in two or three lines.

I welcome AI-generated patches, but they should not be trusted blindly.
I also don't believe AI can reliably trim stack traces.

Thanks

> 
> Willy

  reply	other threads:[~2026-11-19 12:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 20:05 [PATCH v2] docs: submitting-patches: ask bug fixes for their user-visible impact Sasha Levin
2026-11-17  9:00 ` Greg Kroah-Hartman
2026-11-17  9:27 ` Leon Romanovsky
2026-11-17 15:07   ` Sasha Levin
2026-11-17 15:27     ` Leon Romanovsky
2026-11-17 16:03       ` Sasha Levin
2026-11-19 12:34       ` Willy Tarreau
2026-11-19 12:59         ` Leon Romanovsky
2026-11-19 13:01           ` Willy Tarreau
2026-11-19 10:13   ` Krzysztof Kozlowski
2026-11-19 10:29     ` Geert Uytterhoeven
2026-11-19 11:19       ` Leon Romanovsky
2026-11-19 11:19     ` Leon Romanovsky
2026-11-19 12:04       ` Krzysztof Kozlowski
2026-11-19 12:36         ` Willy Tarreau
2026-11-19 12:54           ` Leon Romanovsky [this message]
2026-11-19 12:58             ` Willy Tarreau
2026-11-19 10:12 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119125450.GJ162713@unreal \
    --to=leon@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=david@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sashal@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tytso@mit.edu \
    --cc=w@1wt.eu \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox