From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.214.200 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795116343; b=YpWzJ9NKzOi5Sw8nsIw/1FRtrQYLcsZLHAky6M8aJKf89YMFMO9IYy7LLvxiAB3nlirX aiiptCpYHvZlc8a7DjVcGpbYTcnAQWoTJAEoiK0N4/uGZxNhBRLN2YDmHwbBO2YU2MGCD 8SEAx/dvdqG7F+wjf7KLbye/xZDnLP3Fv0Yq9rXMJgujLWniA+HuucGI/V2zm6kfH1r1l 2cIWYpxmUduLH4sPcx4M8uYXy0qKNgD9c6Tic0IBnDLDmMY/Ur7b2xnHmJQeG5cjBznE8 tQyIgi+Dm+Y6Z04eLYsbiRmALhAt2PsII5uR4LWJKUJ37N1QwyFJxyvwliBQDcb56ZQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795116343; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=ALLBk8MdTkFwcPZqYQO+ZVSicu8jJEanZFGqZFoBPVY=; b=bKF6xZgWbNzDDJa1a3jOT2RcMah2OSAN8esbnSHboUjOELM8m9pE4aLJpHat+BEsRDeh FdNoFaUwkWk2U3n4FYva1Vvqh3xGnfshECuO8Bm8YmsZVAOqesoSWCpDwWLWOu2JuibOi dr32ZziP/DNEXLmKr7olErhR4SyaX5X/esmynUmkui/kZjq7M/neqdMhPD99ryzLip8Pi m7XJF+sWqbwl8v0juwdh9TbXKpUvZuec15IIJpZV4K0hckP5AxYlaDNzoqhrP6edbDflh BSl6OKisxPMjclAJTOX8Hgayh+xIoXvoDTNQdEBwXyioT6T4CLTElXCGxumwyU+WEDw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=BYv7OsYs; arc=none smtp.remote-ip=209.85.214.200 Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF73360A260A for ; Thu, 19 Nov 2026 19:25:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org DF73360A260A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=BYv7OsYs Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2f040056fd0so1594155ad.1 for ; Thu, 19 Nov 2026 11:25:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1795116341; x=1795721141; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ALLBk8MdTkFwcPZqYQO+ZVSicu8jJEanZFGqZFoBPVY=; b=BYv7OsYsxwh5t8p7/0Bp+Ty/T8NLWmSWYXIktaSg0QLh2dtAIFb3imVoee12XgHoWK mUIbJT1XkyoNa7tb+YibdljLhg8xyJpSz4cIDdCeOF27j0B545vrSXDsPWORMWkYK8lL 2ud8bRh2hgMvWXbTuM+9Kmcc7s/hrRwyihUtOpStDYOfj2AtLGFx1Bu0icOsfO63qsRy ZGhxrkwNxvyV95wcfNMtY+9w7/r9tW4iBrIDYIwhqf5FSLswSImMzmz/v7CszkjOwRfu ayIbn7J6MZ6LABK9vpuCF081H5sl/Q8ZbGtbOEXMdSp6PCg6We/dTvPKV0t+kKCqx32J bOGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795116341; x=1795721141; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ALLBk8MdTkFwcPZqYQO+ZVSicu8jJEanZFGqZFoBPVY=; b=cnZw4jT1kC16pEo4G2wTHX6hXR7UU6Th2kijxmN0JixKgbXRooi8mYu4UmPOdr0UsB obzKRQwENSZcwISx8Et1FFiEkFGEuNrx4CqJehPU89Vn6P3ZhgcBkwj6p0v9paPgzQXJ jjMQJOP8rdE3iDfcdmvfEosOvvOG/fYW+YvPAaVm+OlnR8hoZAhoO9XDjaI9GWUk/8J6 bL5dLZ+UUc9zX+AUMAbKA1I/sUpqraJl18E7ms1rVjfQA5GVqNUPj0UkjOqYNMBnvVNU G3ZrVeSMh1bEMa3VHASvqzMYBf1v9CrjKo6v7kLDZke5y9Z0WHstPB/2AuHuQg3XhGL1 t/yg== X-Forwarded-Encrypted: i=1; AL+hErHnfKLzSyf1DKPqdt/t8Y3v6jSUIHf/W/JL0Kc+HszGWxDTWjrqPn+FHajWUYz1L7cqz8oNgyHwFfY=@vger.kernel.org X-Gm-Message-State: APuU4Z8SnTKV3xKg4LsK+HOpV6RmdFfJCHhjhKFPNq3/4rBbYTE0E+Gs BlSRWoPfwK9e8yuqsC6AGxRlUWGUiILErmYcVZ3jCxuMQ7ynA/zLgS5ROTjXqY9PlsQC9UobcR6 W7ECMjl0Z1Q== X-Received: from pleu15.prod.google.com ([2002:a17:903:41cf:b0:2ef:d860:1c85]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:fda5:b0:2ed:fb0:bfd6 with SMTP id d9443c01a7336-2f031e08699mr15736045ad.11.1795116341051; Thu, 19 Nov 2026 11:25:41 -0800 (PST) Date: Thu, 19 Nov 2026 11:25:14 -0800 In-Reply-To: <20261119192520.1983406-1-irogers@google.com> X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261119192520.1983406-1-irogers@google.com> X-Mailer: git-send-email 2.56.1.750.gf70dc682cf-goog Message-ID: <20261119192520.1983406-4-irogers@google.com> Subject: [PATCH v4 3/9] sh: sq: Add missing kobject release callback to ktype_percpu_entry From: Ian Rogers To: Danilo Krummrich , Greg Kroah-Hartman , Kees Cook , Miguel Ojeda , "Rafael J . Wysocki" Cc: Madhavan Srinivasan , Srish Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nayna Jain , Mimi Zohar , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Nathan Chancellor , Nick Desaulniers , Viresh Kumar , Zhongqiu Han , Alexander Aring , Felix Kuehling , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Zhihao Cheng , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers Content-Type: text/plain; charset="UTF-8" In sq_dev_add(), sq_kobject[cpu] is dynamically allocated with kzalloc_obj() and initialized with ktype_percpu_entry. When sq_dev_remove() calls kobject_put(kobj), the kobject is never freed because ktype_percpu_entry lacks a .release callback. Provide a sq_kobj_release() callback that calls kfree(kobj). Fixes: d7c30c682a27 ("sh: Store Queue API rework.") Acked-by: John Paul Adrian Glaubitz Signed-off-by: Ian Rogers --- arch/sh/kernel/cpu/sh4/sq.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/sh/kernel/cpu/sh4/sq.c b/arch/sh/kernel/cpu/sh4/sq.c index 908a8e09113b..f33864958487 100644 --- a/arch/sh/kernel/cpu/sh4/sq.c +++ b/arch/sh/kernel/cpu/sh4/sq.c @@ -331,7 +331,13 @@ static const struct sysfs_ops sq_sysfs_ops = { .store = sq_sysfs_store, }; +static void sq_kobj_release(struct kobject *kobj) +{ + kfree(kobj); +} + static struct kobj_type ktype_percpu_entry = { + .release = sq_kobj_release, .sysfs_ops = &sq_sysfs_ops, .default_groups = sq_sysfs_groups, }; -- 2.56.1.708.g77570a6a1d-goog