From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 232B0C43217 for ; Fri, 22 Apr 2022 21:35:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229936AbiDVViZ (ORCPT ); Fri, 22 Apr 2022 17:38:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230010AbiDVViQ (ORCPT ); Fri, 22 Apr 2022 17:38:16 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D0435A143; Fri, 22 Apr 2022 13:42:38 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id t11so18498636eju.13; Fri, 22 Apr 2022 13:42:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fZ2/OuEbTtlP/zbEoj+78SvWtB9uWMF+zESvUfUCBO4=; b=B7Hd84UyG0YttbYUhgQvL4d1pq3mxusUKlQRLFIQZs3auNE3kOIsG7+9OSj4DdysBG mqLQlVWTTHgeNKQi5dyXhHS0YYG7368eNfxkjYfKi+Qg36lYyXF+J/csTJvBGRfE2Umo V8fpyB9AaDpuEysiJ6ZtkspZ57PUfLgdtksqR1HIqwqt+EsGJOxQgnjt/xFVvbKxjHvh TXAYORwq9QCqRe3qJFlMsszhArFqyGW9e2AD9h/XFzEg16uXNgZqB1UQEyyWBZEjTD/n GwHLepHX0VOVcJaXF8zEazZVX0aDDC9paxe2rpLen6sUdcIKvwpKKzn4FTI+zLUC3HKm MGEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fZ2/OuEbTtlP/zbEoj+78SvWtB9uWMF+zESvUfUCBO4=; b=zu06kGFbOaV8g0vzcI+yICSNcAsCHObXIdr8NXqHEJvy2kUpTMEWFtrSJMZYR+DT0w JPCX9MZCqIcy2in3m59Yd1lL4hmgkQm4BdpTdzdyUIDH/bEu40PIBTF8No/LuBBLNwZb GvB6yaI5V4zbDg9F2fSXTePyPHra+JyhXEL2/4TFpvxKZWbrDGlPeTBLSH8pZk1A5hdV AeQRdyTWc+XqssxncNtvUJHEmtyY7J6lY4JkvXqFrRbHym+SdIse/OQQj7umKJPAEuxB NO+7nRwsAhv8+YbI7zj/pkHiIWLSOi+qOOrM/5vjr190l/iPru9+1Aorr2kLAcV+yaIu jn3w== X-Gm-Message-State: AOAM533yoBkuT3sq2yqHXk4XtyjwZYjOJhkimWehhhg1ogdo3j6SCoLq qLEwdkLSspOsXaJpR0YYFrHGWi85l7w= X-Google-Smtp-Source: ABdhPJx/sfbtZ0jZujbDr2K9gG27fiJ4Fj+BmJWojKiTW9YVnhEQi2DSVh9qIj34dyoZy+4/g81Cgg== X-Received: by 2002:a17:907:7246:b0:6ef:828d:4b49 with SMTP id ds6-20020a170907724600b006ef828d4b49mr6055932ejc.172.1650660156563; Fri, 22 Apr 2022 13:42:36 -0700 (PDT) Received: from leap.localnet (host-79-50-86-254.retail.telecomitalia.it. [79.50.86.254]) by smtp.gmail.com with ESMTPSA id fq6-20020a1709069d8600b006e891c0b7e0sm1072601ejc.129.2022.04.22.13.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 13:42:35 -0700 (PDT) From: "Fabio M. De Francesco" To: Ira Weiny Cc: Andrew Morton , Catalin Marinas , "Matthew Wilcox (Oracle)" , Will Deacon , Peter Collingbourne , Vlastimil Babka , Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, outreachy@lists.linux.dev, Mike Rapoport Subject: Re: [PATCH 1/4] mm/highmem: Fix kernel-doc warnings in highmem*.h Date: Fri, 22 Apr 2022 22:42:34 +0200 Message-ID: <2185371.iZASKD2KPV@leap> In-Reply-To: References: <20220421180200.16901-1-fmdefrancesco@gmail.com> <20220421180200.16901-2-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org (I don't know why it looks like my previous reply has not been sent and it= =20 also disappeared from drafts. I apologize if for whatever reason you=20 receive this message twice) On venerd=C3=AC 22 aprile 2022 20:08:46 CEST Ira Weiny wrote: > On Thu, Apr 21, 2022 at 08:01:57PM +0200, Fabio M. De Francesco wrote: > > [snip] > > > diff --git a/include/linux/highmem.h b/include/linux/highmem.h > > index 39bb9b47fa9c..c3d562b5f0c1 100644 > > --- a/include/linux/highmem.h > > +++ b/include/linux/highmem.h > > @@ -37,7 +37,7 @@ static inline void *kmap(struct page *page); > > =20 > > /** > > * kunmap - Unmap the virtual address mapped by kmap() > > - * @addr: Virtual address to be unmapped > > + * @page: Virtual address to be unmapped > ^^^^^^^^^^^^^^^ > Page >=20 > Not only was the name wrong but the description of an address is wrong. Yes, correct. I'll rewrite this line the following way and send a v2 of=20 this series while addressing also what it is required by your review of 3/4= =20 (unless you have better suited suggestions): =2D * @addr: Virtual address to be unmapped=20 + * @page: Pointer to the page which was mapped by kmap() > Other than that LGTM: >=20 > Reviewed-by: Ira Weiny Thanks! =46abio