From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D30C77B7D for ; Sat, 13 May 2023 23:58:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232868AbjEMX6H (ORCPT ); Sat, 13 May 2023 19:58:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjEMX6G (ORCPT ); Sat, 13 May 2023 19:58:06 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80A722130; Sat, 13 May 2023 16:58:05 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-6434e65d808so12077445b3a.3; Sat, 13 May 2023 16:58:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684022285; x=1686614285; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S6IPSqQ6NaOSfnUS0GpkC+isDFooikpsFH7l63MYdTo=; b=c6TQoKpeUT/xnus50Ag62eU/c39VunpDNtF/MKoJddF0jD6f3+TYJoIPhfkljoRSUP FsIStrF5AoIypO5VQ0CsJsWEeuRgT/XiSbZJ8vD6oh6tqmSkIZu2eadDaMRs2ytcGuFl /OS2p8h06OVmyhcjP5Jls80loAbw2tPq+mgwDSdO4dI0/Mw5wd8wDn4KHn4Wc/c1o52c T6aRqd3qZog1s0mA47WYKDtPvKsSQ4tBU57NLH6pvGVl8W3noU04rDMAXm+CB2SOopB6 VWE+4DRG/fR8pQUmehdiYKkTSqNem72yBbSDgvTcNSbVWGgBXUj0RmRplrnZ8jzAEOSy 7d7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684022285; x=1686614285; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S6IPSqQ6NaOSfnUS0GpkC+isDFooikpsFH7l63MYdTo=; b=XyvZFM+A8WCMHylLei52x4Fib/QE36ynI/Xj7Snga2JXmMOpTE1h503mMwmlP1cDbf 8K+Wmnf4+uwJgFcouN8pZJ9XcHiJjwJgNTecl4CVpZ/XvKASOA6aAq9Fc7K/KPdK2p4a NrwoSNOm0DbOdLe63fhyW7C9tndYE+mm3xuycEKGdXXHwQkEbl0RLsrMdSJe4D2rbsZx NiBNh+qG4xwpbE5KBak74E8rXdzU4VA7QJXny7UXydmJIFJLA0sOO0jRwU0BFZSjsYq2 tcoRxwCDOdc2w7/Xjj17lMjqtw7RLQ2Gdl+UGyO4sf8LHLrxFQ3emWmP+ExXdWIbHIBe wE7w== X-Gm-Message-State: AC+VfDwEBv9NJ9wXC66H+sgZJ3qhkfP5/4198tn8kw+0mhMRc36eHjQ1 FrWwnHHvufAOycqLXfYMGoA= X-Google-Smtp-Source: ACHHUZ40CHAdVD8zkf1r7hESgn2oYYdABf/NG73liqLqpxQ9GuLpKSyt9jFE2/Sst3fK7fVsfse4Ww== X-Received: by 2002:a05:6a00:1a92:b0:64a:a1ba:510e with SMTP id e18-20020a056a001a9200b0064aa1ba510emr9413823pfv.27.1684022284858; Sat, 13 May 2023 16:58:04 -0700 (PDT) Received: from [192.168.11.9] (KD106167171201.ppp-bb.dion.ne.jp. [106.167.171.201]) by smtp.gmail.com with ESMTPSA id x9-20020aa784c9000000b006475f831838sm8137449pfn.30.2023.05.13.16.58.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 May 2023 16:58:04 -0700 (PDT) Message-ID: <23195f15-7024-6fde-84f2-4cdd45c9abfc@gmail.com> Date: Sun, 14 May 2023 08:58:00 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH locking/atomic 18/19] locking/atomic: Refrain from generating duplicate fallback kernel-doc Content-Language: en-US To: paulmck@kernel.org, Mark Rutland Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-doc@vger.kernel.org, kernel-team@meta.com, Will Deacon , Peter Zijlstra , Boqun Feng , Akira Yokosawa References: <19135936-06d7-4705-8bc8-bb31c2a478ca@paulmck-laptop> <20230510181717.2200934-18-paulmck@kernel.org> <2a8b310c-3145-462b-a4c4-a130939da862@paulmck-laptop> From: Akira Yokosawa In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hi, On Fri, 12 May 2023 19:11:15 -0700, Paul E. McKenney wrote: [...] > > And here is a rough first cut: > > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git tags/fallback-rework-kernel-doc.2023.05.12a > > Or via HTML: > > https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/log/?h=fallback-rework-kernel-doc.2023.05.12a Running "./scripts/kernel-doc -none include/linux/atomic/atomic-arch-fallback.h" on the tag emits a lot of warnings. Looks like there are kernel-doc comments who don't have a corresponding function signature next to them. /** * function_name() - Brief description of function. * @arg1: Describe the first argument. * @arg2: Describe the second argument. * One can provide multiple line descriptions * for arguments. * * A longer description, with more discussion of the function function_name() * that might be useful to those using or modifying it. Begins with an * empty comment line, and may include additional embedded empty * comment lines. */ int function_name(int arg1, int arg2) <--- Note that the kernel-doc script ignores #ifdef -- #else. BTW, I couldn't checkout the tag so downloaded the tar ball via HTML. Thanks, Akira > > Thoughts? > > In the meantime, enjoy the weekend! > > Thanx, Paul