From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9245E3822B1 for ; Wed, 26 Aug 2026 13:07:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787749633; cv=none; b=n3ppjVSA+TrnENTGGvfADg/RZ/Tsuu/ZNM2InysIz67CfXpzbOyTWFNTNJtLLeXzebm5a/auWUBRZZAXRThpvk/hiX0ivmBnzllIMxXp5MW3xAWHhrGAEklAHv3OL03NbpiJrVT9Wu483SJGJXwJfaoaz9ol41Op1bW+EBmiR90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787749633; c=relaxed/simple; bh=LiZoxw5u7OkTtmxFcQ5+LUeZikX3PH8TbD4TDRPPn34=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YgqHdPrf4oAU28nyRMjGKeDrsyEDO4RHlM8uPcOUOLPd/aabBaFxNOvInZ+q1n5g6yjdFrlzfVTBHl7cU9Dp3GX0pZ+8unj3py+ttNLrBMO9sOWAWPlcLvDgYnhT3rLyRE2OBzq6RwRwbwsOVdN4rDEemdZiVzsbjtdSIvMJC9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cVbTFTRA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bGCwPnmt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cVbTFTRA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bGCwPnmt" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67QCCH77374857 for ; Wed, 26 Aug 2026 13:07:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= z8ZCL6UB+xi0N5gctLw16/d9ULv3ZvLsxlJFre/dyo4=; b=cVbTFTRA/0lJJsRz 1IV7KZRvSOcP707QMxiFBDWZD+bzVxbypuiePC1uTTRkmKqETUDEwn9XxGilb6pY nRuU9fKpMbKGrcjVsVzzh643jTiVHuUF16XEVgFG4M94fzO4W6GBwUnRmEhruP0w PZtGHsyaaFb15Pd8eG1wAoQa8Mj162q4fAXkPWdGWNIbNJXYfT7HDSkKPq5REeDD yhFKk8BUoueF/HzJ9yKMbqs+3FAjLLq8jJMx5yqfj7auX0FamTYxWUHuusLNwd4+ b3b7eFpusiLHNVzlA6RQFl3DBqwbkLpvjIhmoDRvwt5aEX6drirvxoQp6ujPpWhC EHsyFQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g9smx9x5c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 26 Aug 2026 13:07:11 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84842381150so1096462b3a.3 for ; Wed, 26 Aug 2026 06:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787749631; x=1788354431; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=z8ZCL6UB+xi0N5gctLw16/d9ULv3ZvLsxlJFre/dyo4=; b=bGCwPnmtiqaBiqXoiYADKtbeuz71hizGVlwLXL9FWM2C5rSOL/FS2LwI1C+fCpY4V8 DlSqCeU/TnC2XaNnwPVsaAwSRPXOkzsjwf7DbfKfJkh6IEdI+9Ec+7pjTU2NG77mk/7J 33uwfe/h6zYgCdAftV59rfb7Z4AC0Z5mMhTWj4Wf9SMwGMtIcNpOaQPBNqCdBrjBUoAl HwPDkBsSoxQVKJTKqnjRTDv3WfthtpCB98YaBTsefWXKIvyl4YKiZ31grdsfbSpWyh8y B50RwV8HRCLBZ4W8nmPvx2ZuyEKr8ZYnh/F3FtKlxhOaZJuyCzT4LrC0U1bBtTHIDU02 yLjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787749631; x=1788354431; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=z8ZCL6UB+xi0N5gctLw16/d9ULv3ZvLsxlJFre/dyo4=; b=Uf3qjHbdu2lO8ig98wRLthaw6nIefvuv/cfCxLo544DzVnoU7Cfv9Ddg+zpAfpSZPD E7nD7ic+lpjD2CHtnCBVD3PAhUdBRMwvzEFbs8DwvLp7imwetFG+680KUx9pLp3c9GVr v1pGJ4fYKP45oFvnDrB052tXqSnK7oQuGsXKzEZ/gkBwV7yOtatzpygOHTIcKzbslqAK ihgEQtqIpBRbqRaah2OC9nI2I/JwTdJtm2cV6vho70ZDQcGKmU03yn6iap5Se5Za/gqx wYG5mkY4rQWnEd9ZpRAuaLkddPCdLlD/NCfjNvEBWOx88/8KPxFqqJGYPDirhYc7RNcz 1Rhg== X-Forwarded-Encrypted: i=1; AHgh+RooiwsvFBcVv1rs4vh6BFEeV4l7JapqLIHMrq6lKY2RguC4FdH94UGD1A6ljqKfF5VqMIvQG6PeCE4=@vger.kernel.org X-Gm-Message-State: AFuF++mN+CxEveWk3We5SbVn3ZThjbBQLuYe9HSuEEY/RDmk/nq+0CcY C1UPNE5XYJm0abMGAJNOBeL/Kiq5z3t3ao28ZVsyeCQoK+Wb0S0xAXLtTL7D11fcrIRxJEJwdig Y1lZO2AtU7cg0buPhEaCbDaIXZETVj0z9ZVzcofFjR02gLPtCpHiMmulh9sj/GEY= X-Gm-Gg: AR+sD12Zwo2JXuQdL09l2SoHoEGPp5pBt5dghs9mrbB/qT7VKGyfeBiM7W97MPzLBqh wbAOjJ4YCR8hxQ8oHyejCT+g8jqQ2BYuX8z4RAeQgH/2iKUgcwf3QzjnqSZYitSBsD4fZ0l3DrV cG35KTasBAGoN6TKUxc2AYFoJIWPBbvLirFzMUygtSsP566gSFDK6l59KgDVT0gqMxn8ZuDsvd7 4hPQp5bChsisJ5fPNF9iW7opLFYyFSU2ynqn6/a9Mj17uDzzf3wO+LmLVwpNkrrOALoH1qisxvU 38s+cow485R603D2SbKFLh/bqQldi28j2o1hfKMcZ7NVAUhijO+XKK5+Cg69BsfVbJXkAHqst7Q 6mDfaXUzKqWmwhBQh4uODbqeeWi3xrA== X-Received: by 2002:a05:6a00:c96:b0:845:ce5f:c926 with SMTP id d2e1a72fcca58-85372ea6666mr12573091b3a.1.1787749630923; Wed, 26 Aug 2026 06:07:10 -0700 (PDT) X-Received: by 2002:a05:6a00:c96:b0:845:ce5f:c926 with SMTP id d2e1a72fcca58-85372ea6666mr12572918b3a.1.1787749630363; Wed, 26 Aug 2026 06:07:10 -0700 (PDT) Received: from [10.219.57.226] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-85359cdfeebsm917003b3a.4.2026.08.26.06.07.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Aug 2026 06:07:09 -0700 (PDT) Message-ID: <23e31249-cce2-421e-88f7-1a2af66e34b6@oss.qualcomm.com> Date: Wed, 26 Aug 2026 18:37:00 +0530 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 00/15] accel/qda: Qualcomm DSP Accelerator driver To: rob.clark@oss.qualcomm.com, Krzysztof Kozlowski Cc: Oded Gabbay , Jonathan Corbet , Shuah Khan , Randy Dunlap , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Bharath Kumar , Chenna Kesava Raju , srinivas.kandagatla@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, llvm@lists.linux.dev, iommu@lists.linux.dev, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Anandu Krishnan E References: <20260817-qda-v2-v2-0-69a02e9090d4@oss.qualcomm.com> <3322b42b-3755-45ec-ad55-345125f0d488@kernel.org> <10349e29-b583-403f-a89a-9a00c73666bc@oss.qualcomm.com> <87dca76c-851e-4cc3-ab91-68949d283b79@kernel.org> <318f14c2-0e87-4e07-8173-1511dca67d78@kernel.org> Content-Language: en-US From: Ekansh Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=O/oJeh9W c=1 sm=1 tr=0 ts=6a8ee4ff cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=HVFQHpX-XFYh-alqn_4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: xz1Sx_Ip7AS7lJXsa_d0KeavrcM96wdr X-Proofpoint-ORIG-GUID: xz1Sx_Ip7AS7lJXsa_d0KeavrcM96wdr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI2MDEwOCBTYWx0ZWRfX45cEYXYJEwiP 8qU4X1Hv81TZ0f/e22ZSgzsr7LoNE82IykRGNO85Deic8/SpnZrBe5oY5uWLpBwBh2T1EtkP8pX pCykUqAsgW4YxFbuz4U1HU9hogfZTC8qge6SPlFPI8T40VimaDCDLgUFDo9CNDqckBMBGsGhidZ iPyaGWH/t2VhB/rqb02lInB+SMFW+rgdltOaSgcFQQIkFpNvqCe/8nSFCNtNZ8cTjp7fgueXDpg tI3M/APNQWFL8CFuESl3ZtOVAhIXGtpFXlB2H67XRyG4ai7TB6ZluAD1Pweq4uDh9sPNtuMTCEq swC3x3JwzOQ8tTjoHsTyTaawD1Zt0+tKspgDncBFuGdfb/Zh7FGzK7IFUIBlmwbbB4YaOYijQAi yE90JucvW5d+KGh9hvCM/euVk0DcCaHW3iSF6Ztf2XaPmL7EAYWGFLm44IHZ/ZqCaJIo6evpkxY B5lRKc4EBzcJPYP/Sfw== X-Proofpoint-Spam-Info: AW1haW4tMjYwODI2MDEwOCBTYWx0ZWRfX15iPS5fN77pt WWhRN4sMU3zk8czokHEwc0p856z/WJOJ17OGogt23hsVt9TOuj4E5x3ALSfyiAHc5Z78vcpoiVw ZJJdH0HTiiwOcPL6mxe/tP7xfMY2eVw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-26_03,2026-08-26_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608260108 On 20-08-2026 20:17, Rob Clark wrote: > On Wed, Aug 19, 2026 at 11:15 PM Krzysztof Kozlowski wrote: >> >> On 19/08/2026 17:48, Rob Clark wrote: >>> On Wed, Aug 19, 2026 at 8:27 AM Krzysztof Kozlowski wrote: >>>> The rule of usptream development is that we do not accept duplicated >>>> code, just because a vendor wants to write something new. This is >>>> basically the concept applied all over the drivers tree, where we pushed >>>> back against all sorts of duplications all over the vendors. >>>> >>>> What I miss in this thread is why would there be any exception here. We >>>> do not grant exceptions from standard practices on "I want" reasons. >>> >>> I agree that we should not have duplicated drivers just for vendor >>> lolz. But when it comes to adopting common frameworks and integrating >>> better into the ecosystem, this doesn't seem like something we should >>> actively discourage. I don't think this is a case of vendor lolz, but >> >> No one discourages it. Following standard Linux kernel practices and >> requirements is not discouraging, do not twist the narrative here. >> Again, it is standard upstream review telling that we do not duplicate >> drivers. Ever, unless there is serious exception needed. > > I wasn't trying to twist the narrative, just trying to come up with a > path forward that isn't "no" or "improve existing driver", since > neither of those gets us towards a future using common frameworks. > >> I asked why there should be an exception granted? Is the reason for >> exception following: >> "We want to adopt common framework" >> ? > > Possibly? But I don't think we want two drivers to be any sort of > long term solution. (Ie. as long as venus/iris have co-exist.) > >> >>> rather reacting to drm/accel emerging as the standard framework for >>> this sort of driver. >>> >>> So how do we get from here to there? >> >> What is wrong with my proposal? > > Maybe I missed something, my understanding was your proposal was > "Grow/replace/improve existing driver instead of coming with a > duplicate".. grow or improve doesn't move us toward common > frameworks. Maybe "replace" is a valid option. If there is something > I missed, then I apologize. > > Options I can think of are: > > 1. Hardware cutoff.. new hw gets new driver, existing hw gets existing > driver > 2. Backwards compat chardev registered by new driver, providing existing > UABI. I'm not 100% sure about the feasibility/drawbacks of this.. > AFAIU the fastrpc folks where planning a backwards compat layer in > userspace, so maybe it is possible. > 3. exception? > > I'd like to know what the feasibility of #2 is, since at a high level > that sounds like the best option. Possibly limit exposure of legacy > UABI to existing hw so we don't get into a place of needing to extend > the legacy UABI for new hw? > > But #1 sounds like a non-controversial place to start regardless. > Possibly with #2 coming as followup and necessary step before eventual > migration to new driver for existing hw? > > Even if we start with #2, how do we handle first-merge-window > bugs/regressions without reverting addition of new driver and removal > of old? It seems like we'd need a window of a couple release cycles > where both drivers exist? > > Maybe others have other/better options in mind? To all, I'm seeking on the approach I should follow to go ahead here. I can work on implementing #1(as per Rob's list) with hw specific compatible for v4 if it's acceptable. #2(compat driver) is something that we are still exploring as we couldn't find any standard way to achieve it. We might start a separate discussion for that once we have few possible designs with us. Happy to take any other suggestion also.> > BR, > -R