From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81DFFC43334 for ; Fri, 10 Jun 2022 12:49:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241601AbiFJMtQ (ORCPT ); Fri, 10 Jun 2022 08:49:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239131AbiFJMtI (ORCPT ); Fri, 10 Jun 2022 08:49:08 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CAEC1EEF6; Fri, 10 Jun 2022 05:49:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654865347; x=1686401347; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=tgp8OHfSndf8X9XOTJF9Tb0izZaAsaa2D0KBtc/ukNo=; b=d9YWw9b92M3fXAVdGCcSSxlDxxwlOx9fNiiKgDyhhNbABmJww0tmWXC2 3yo4GcMb3iVZLPKSIQFxHnNdLxERAOKzlRrp0Bfpui32gHOPwUymOkUiX FVQy9TX9mtjpPvx5e0mExLXlQDGjEeOjmnMuh3q9wtyLePC6MsJh027f2 yHskeDmpTIQLwjSxZQjTzfeAGIGslr2o3xf1p9WRxP0EJ79FyCu1cfKx3 JIkKTgUA7nsQX/DJwMG+PGogetYctgV6ZR5E9qTG9bfXK1iAcbY/RXFyt +5O1tzppNlU891NMjg2LrAFQqbFqf6f9m/Nn0/ePxGvx8jA+5o0kJ7NM+ g==; X-IronPort-AV: E=McAfee;i="6400,9594,10373"; a="275152767" X-IronPort-AV: E=Sophos;i="5.91,290,1647327600"; d="scan'208";a="275152767" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2022 05:49:06 -0700 X-IronPort-AV: E=Sophos;i="5.91,290,1647327600"; d="scan'208";a="684527290" Received: from elmerred-mobl2.amr.corp.intel.com (HELO [10.251.8.219]) ([10.251.8.219]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2022 05:49:05 -0700 Message-ID: <2854ae00-e965-ab0f-80dd-6012ae36b271@intel.com> Date: Fri, 10 Jun 2022 05:49:04 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/2] x86: notify hypervisor about guest entering s2idle state Content-Language: en-US To: Grzegorz Jaszczyk Cc: linux-kernel@vger.kernel.org, Dmytro Maluka , Zide Chen , Peter Fang , Tomasz Nowicki , Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Brijesh Singh , Ashish Kalra , Mario Limonciello , Pratik Vishwakarma , Hans de Goede , Sachi King , Arnaldo Carvalho de Melo , David Dunn , Wei Wang , Nicholas Piggin , "open list:KERNEL VIRTUAL MACHINE (KVM)" , "open list:DOCUMENTATION" , "open list:ACPI" , "open list:HIBERNATION (aka Software Suspend, aka swsusp)" References: <20220609110337.1238762-1-jaz@semihalf.com> <20220609110337.1238762-2-jaz@semihalf.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 6/10/22 04:36, Grzegorz Jaszczyk wrote: > czw., 9 cze 2022 o 16:27 Dave Hansen napisał(a): >> On 6/9/22 04:03, Grzegorz Jaszczyk wrote: >>> Co-developed-by: Peter Fang >>> Signed-off-by: Peter Fang >>> Co-developed-by: Tomasz Nowicki >>> Signed-off-by: Tomasz Nowicki >>> Signed-off-by: Zide Chen >>> Co-developed-by: Grzegorz Jaszczyk >>> Signed-off-by: Grzegorz Jaszczyk >>> --- >>> Documentation/virt/kvm/x86/hypercalls.rst | 7 +++++++ >>> arch/x86/kvm/x86.c | 3 +++ >>> drivers/acpi/x86/s2idle.c | 8 ++++++++ >>> include/linux/suspend.h | 1 + >>> include/uapi/linux/kvm_para.h | 1 + >>> kernel/power/suspend.c | 4 ++++ >>> 6 files changed, 24 insertions(+) >> What's the deal with these emails? >> >> zide.chen@intel.corp-partner.google.com >> >> I see a smattering of those in the git logs, but never for Intel folks. > I've kept emails as they were in the original patch and I do not think > I should change them. This is what Zide and Peter originally used. "Original patch"? Where did you get this from? >> I'll also say that I'm a bit suspicious of a patch that includes 5 >> authors for 24 lines of code. Did it really take five of you to write >> 24 lines of code? > This patch was built iteratively: original patch comes from Zide and > Peter, I've squashed it with Tomasz later changes and reworked by > myself for upstream. I didn't want to take credentials from any of the > above so ended up with Zide as an author and 3 co-developers. Please > let me know if that's an issue. It just looks awfully fishy. If it were me, and I'd put enough work into it to believe I deserved credit as an *author* (again, of ~13 lines of actual code), I'd probably just zap all the other SoB's and mention them in the changelog. I'd also explain where the code came from. Your text above wouldn't be horrible context to add to a cover letter.