linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] docs: cgroup-v1: wrap charge moving deprecation in warning block
@ 2023-01-06  3:48 Bagas Sanjaya
  2023-01-20  8:20 ` Bagas Sanjaya
  0 siblings, 1 reply; 2+ messages in thread
From: Bagas Sanjaya @ 2023-01-06  3:48 UTC (permalink / raw)
  To: Linux CGroups, Linux Documentation, LKML,
	Linux Memory Management List
  Cc: Tejun Heo, Zefan Li, Johannes Weiner, Jonathan Corbet,
	Michal Hocko, Andrew Morton, Hugh Dickins, Shakeel Butt,
	Bagas Sanjaya

Commit 4ddb1a2aa1a3c4 ("docs: cgroup-v1: wrap remaining admonitions in
admonition blocks") in cgroups tree states that it also wraps charge
moving deprecation notice in admonition block (specifically warning).
However, the notice isn't in cgroups tree when the v2 of formatting
improv series [1] is submitted (and then applied), but rather in mm tree
instead.

Wrap the notice to fulfill the intention of referred commit.

Link: https://lore.kernel.org/linux-doc/20230105131633.553574-1-bagasdotme@gmail.com/ # [1]
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
 Documentation/admin-guide/cgroup-v1/memory.rst | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/Documentation/admin-guide/cgroup-v1/memory.rst b/Documentation/admin-guide/cgroup-v1/memory.rst
index 258e45cc3b2db1..b73eb174735556 100644
--- a/Documentation/admin-guide/cgroup-v1/memory.rst
+++ b/Documentation/admin-guide/cgroup-v1/memory.rst
@@ -722,12 +722,14 @@ NOTE2:
 8. Move charges at task migration (DEPRECATED!)
 ===============================================
 
-THIS IS DEPRECATED!
+.. warning::
 
-It's expensive and unreliable! It's better practice to launch workload
-tasks directly from inside their target cgroup. Use dedicated workload
-cgroups to allow fine-grained policy adjustments without having to
-move physical pages between control domains.
+   THIS IS DEPRECATED!
+
+   It's expensive and unreliable! It's better practice to launch workload
+   tasks directly from inside their target cgroup. Use dedicated workload
+   cgroups to allow fine-grained policy adjustments without having to
+   move physical pages between control domains.
 
 Users can move charges associated with a task along with task migration, that
 is, uncharge task's pages from the old cgroup and charge them to the new cgroup.

base-commit: dd5c3ba990ae67409bc058051efcd40c3689d01d
-- 
An old man doll... just what I always wanted! - Clara


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] docs: cgroup-v1: wrap charge moving deprecation in warning block
  2023-01-06  3:48 [PATCH] docs: cgroup-v1: wrap charge moving deprecation in warning block Bagas Sanjaya
@ 2023-01-20  8:20 ` Bagas Sanjaya
  0 siblings, 0 replies; 2+ messages in thread
From: Bagas Sanjaya @ 2023-01-20  8:20 UTC (permalink / raw)
  To: Linux CGroups, Linux Documentation, LKML,
	Linux Memory Management List
  Cc: Tejun Heo, Zefan Li, Johannes Weiner, Jonathan Corbet,
	Michal Hocko, Andrew Morton, Hugh Dickins, Shakeel Butt

On 1/6/23 10:48, Bagas Sanjaya wrote:
> Commit 4ddb1a2aa1a3c4 ("docs: cgroup-v1: wrap remaining admonitions in
> admonition blocks") in cgroups tree states that it also wraps charge
> moving deprecation notice in admonition block (specifically warning).
> However, the notice isn't in cgroups tree when the v2 of formatting
> improv series [1] is submitted (and then applied), but rather in mm tree
> instead.
> 
> Wrap the notice to fulfill the intention of referred commit.
> 

Ping?

-- 
An old man doll... just what I always wanted! - Clara


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-20  8:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-06  3:48 [PATCH] docs: cgroup-v1: wrap charge moving deprecation in warning block Bagas Sanjaya
2023-01-20  8:20 ` Bagas Sanjaya

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).