From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 877373B2AA; Fri, 10 Jul 2026 13:35:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.151 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783690525; cv=none; b=VopLgL2QnhxawIUDVd+ZWQe2Kv7DRkYSQsztPg/MGq3PAR/s+BVn372Qd24SULQFvRSUw5FLdgsz+AtQRFpKl5XgEWJxrQHzr39OIomSLtndr3zmAwEC43mNSl0rNzN5X5AzwrtPU4zbG2I56QdZkJ4a016YXGL7+Kz6YFWXa9M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783690525; c=relaxed/simple; bh=qfIZLF+bh/b40e3fxtqo0rkYJysVYWbXTttsLuuzEFo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OpXUm8eFPNqAZtMILgkRie9Peynq4Z8Pz/PHjZ41SJn9/jStbn72LC3b9hetAK7PaDd9xQAXW9gn8721m2Er/vN5pQfU2SVH9ARNff0bScDf2cpP6woV9hLM3mmDNbQwsacrID7hpl0m5lN1nvJ3DEnWitrRv638ECNZNQi4cS0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=FJJxmCIV; arc=none smtp.client-ip=80.241.56.151 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="FJJxmCIV" Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA512) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4gxXrj5TZ7z8txZ; Fri, 10 Jul 2026 15:35:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1783690517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zlKLNJPOGiDKqWlVl/uUtpjI3Xr5vwkpin4+jwj51A4=; b=FJJxmCIVt4hbz0GcuAzOD5mSpmcsjTnSJgrxCHghbGivf1Dkcd3M4z9rFhJWFg20UWKD39 mArdJWRl/y32FYiRJQcatQdN091jZQoC7Paz6gweqie3AqfP8b6Hp4l78nu5krwcRynQwB 4zegO5t8mrZbHwC4YIpuMZfrrw/tAOfbJFyWOa0af5cIGCXt3egqU7eCBQGOr70+rJa4hV gKVylEMRpUk3b6H63tA8q6QuhGvLnvHZIwWDCclCxm/A7KSmn7v7xf0jgjI4khnE+8O4Ew PauB/VmiEs60KqqKfk88beChhnqUwcN8Mq/q0Ry67f685oyQY4bl7WYxSDW+3Q== Message-ID: <2cb03029-0957-4ed8-98bd-9b3e0e0bce2d@mailbox.org> Date: Fri, 10 Jul 2026 15:35:10 +0200 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] PCI: rcar-gen4: Inline GIC_TRANSLATER offset macro To: Marc Zyngier Cc: linux-pci@vger.kernel.org, kernel test robot , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Catalin Marinas , Conor Dooley , Geert Uytterhoeven , Krzysztof Kozlowski , Lorenzo Pieralisi , Manivannan Sadhasivam , Rob Herring , Yoshihiro Shimoda , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <20260709201103.90162-1-marek.vasut+renesas@mailbox.org> <87qzlb5jsl.wl-maz@kernel.org> Content-Language: en-US From: Marek Vasut In-Reply-To: <87qzlb5jsl.wl-maz@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-MBO-RS-META: 39334qfx7t74yz6t7hkn76hnui4r95h5 X-MBO-RS-ID: c43d4b05b532b168186 On 7/10/26 10:30 AM, Marc Zyngier wrote: > On Thu, 09 Jul 2026 21:10:03 +0100, > Marek Vasut wrote: >> >> Instead of pulling in the whole linux/irqchip/arm-gic-v3.h , copy the >> one GITS_TRANSLATER register offset macro directly into the driver. >> This repairs the ability to build the driver on non-ARM non-GIC targets >> the way it was possible until now, which retains good build test coverage. >> >> Reported-by: kernel test robot >> Closes: https://lore.kernel.org/oe-kbuild-all/202607100310.iQw5m9Uo-lkp@intel.com/ >> Signed-off-by: Marek Vasut >> --- >> Cc: "Krzysztof Wilczyński" >> Cc: Bjorn Helgaas >> Cc: Catalin Marinas >> Cc: Conor Dooley >> Cc: Geert Uytterhoeven >> Cc: Krzysztof Kozlowski >> Cc: Lorenzo Pieralisi >> Cc: Manivannan Sadhasivam >> Cc: Marc Zyngier >> Cc: Rob Herring >> Cc: Yoshihiro Shimoda >> Cc: devicetree@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-doc@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Cc: linux-pci@vger.kernel.org >> Cc: linux-renesas-soc@vger.kernel.org >> --- >> Note: The alternative I could think of would be ifdeffery which >> is not nice and thwarts the build coverage, or limit the >> driver to ARM/ARM64 in Kconfig which also thwarts the build >> coverage. I could also split off the register macros in >> linux/irqchip/arm-gic-v3.h into some separate header >> linux/irqchip/arm-gic-v3-regs.h and include that which >> might be OKish and avoids duplication. Thoughts ? > > No, I'm not hacking something that is purely architecture specific for > the purpose of a bizarre integration quirk that should be handled by > the boot firmware, and not Linux. The PCIe controller is fully controlled by Linux. I don't think this can be handled by the boot firmware. The GIC ITS TRANSLATER address could be derived from the DT compatible string of the PCIe controller (I had that implemented before), but that is the less generic option. > Add whatever you want to the PCI glue code, limit this to arm64 (which > is the only architecture this can ever be used on, and the build > coverage argument really doesn't hold), but please leave the GIC code > alone. So in the end, it is either this patch or limit the build to arm/arm64 . At least this patch still allows building this driver with more compilers on the various build bots, so I would opt for this patch here. Thank you for your help !