From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC9CA2253EB; Tue, 2 Sep 2025 20:49:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756846201; cv=none; b=slgvV5gKliqHcAHj5xNr/iXHKxF0MH//InFClCSsqW4OtFmhcc9zMSdavtYh4+zZ9b8CeZ3E50mx8vhGYZvOTEpdLngrdqHPhYue5e9Jg5YM4zTFaQheLN2DRFJyQZUrAPn9KsPG3ztpKN7LcxvBa8XlzIKTciUhpG3a4b1rho8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756846201; c=relaxed/simple; bh=h9YG598jez9xHSTtoGC3TbdsaCDXkMcOLxofIDRanhw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=LB/bJb6+jMiGxTatRYRdw5WhH11CwgG0T6mTmZ2mHrocQ8a4QSGmZN4LYTjmb/fRdN4OuO0SGRPKVkM/nvLkb/i+gcmZbhWkZg9RfbWbxVLMnAVy2izv3HdC5pu7vUXksHsBntmufIe+fZVQEm063gp6j2K4mCqOgK6nZXa4iE4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=TCSDXZF2; arc=none smtp.client-ip=210.118.77.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="TCSDXZF2" Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20250902204951euoutp019772216366e471dce5ab670ff270a1c3~hkk2PqBI40583005830euoutp01b; Tue, 2 Sep 2025 20:49:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20250902204951euoutp019772216366e471dce5ab670ff270a1c3~hkk2PqBI40583005830euoutp01b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1756846191; bh=cns0fXIAbt1EqvizSg/wAnSv3SWVs6AXpQ/9VbxT1xc=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=TCSDXZF2Z62YcDiWqMDDa7Dv+pRBN+EUSjgrFZ1mzkO8tak0poyAI0nhbznKNDhqf D8kNvQjhwMLyfbECL2R2+e0uzHGZze/5arbNIj/FB7PwNbK4vxp5cjSUYa4Wb+jDZr M4rtfp2Rgp2ma7OWloLOB4f81ua8G4Rw/nxkJvc0= Received: from eusmtip1.samsung.com (unknown [203.254.199.221]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20250902204950eucas1p1185c6ab6c55958183bb0c347b0396b5b~hkk1r34Tc3157531575eucas1p1q; Tue, 2 Sep 2025 20:49:50 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250902204948eusmtip14b51a6d907c8deca19aa6660d162e2c8~hkkz6C6Li1369313693eusmtip1I; Tue, 2 Sep 2025 20:49:48 +0000 (GMT) Message-ID: <2d8e67b2-4ab2-4c1f-9ef3-470810f99d07@samsung.com> Date: Tue, 2 Sep 2025 22:49:48 +0200 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: [PATCH v4 14/16] block-dma: migrate to dma_map_phys instead of map_page To: Leon Romanovsky Cc: Leon Romanovsky , Jason Gunthorpe , Abdiel Janulgue , Alexander Potapenko , Alex Gaynor , Andrew Morton , Christoph Hellwig , Danilo Krummrich , iommu@lists.linux.dev, Jason Wang , Jens Axboe , Joerg Roedel , Jonathan Corbet , Juergen Gross , kasan-dev@googlegroups.com, Keith Busch , linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nvme@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-trace-kernel@vger.kernel.org, Madhavan Srinivasan , Masami Hiramatsu , Michael Ellerman , "Michael S. Tsirkin" , Miguel Ojeda , Robin Murphy , rust-for-linux@vger.kernel.org, Sagi Grimberg , Stefano Stabellini , Steven Rostedt , virtualization@lists.linux.dev, Will Deacon , xen-devel@lists.xenproject.org Content-Language: en-US From: Marek Szyprowski In-Reply-To: <22b824931bc8ba090979ab902e4c1c2ec8327b65.1755624249.git.leon@kernel.org> Content-Transfer-Encoding: 7bit X-CMS-MailID: 20250902204950eucas1p1185c6ab6c55958183bb0c347b0396b5b X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20250819173845eucas1p221cd6842839f5e7130f131cd341df566 X-EPHeader: CA X-CMS-RootMailID: 20250819173845eucas1p221cd6842839f5e7130f131cd341df566 References: <22b824931bc8ba090979ab902e4c1c2ec8327b65.1755624249.git.leon@kernel.org> On 19.08.2025 19:36, Leon Romanovsky wrote: > From: Leon Romanovsky > > After introduction of dma_map_phys(), there is no need to convert > from physical address to struct page in order to map page. So let's > use it directly. > > Signed-off-by: Leon Romanovsky > --- > block/blk-mq-dma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/block/blk-mq-dma.c b/block/blk-mq-dma.c > index ad283017caef..37e2142be4f7 100644 > --- a/block/blk-mq-dma.c > +++ b/block/blk-mq-dma.c > @@ -87,8 +87,8 @@ static bool blk_dma_map_bus(struct blk_dma_iter *iter, struct phys_vec *vec) > static bool blk_dma_map_direct(struct request *req, struct device *dma_dev, > struct blk_dma_iter *iter, struct phys_vec *vec) > { > - iter->addr = dma_map_page(dma_dev, phys_to_page(vec->paddr), > - offset_in_page(vec->paddr), vec->len, rq_dma_dir(req)); > + iter->addr = dma_map_phys(dma_dev, vec->paddr, vec->len, > + rq_dma_dir(req), 0); > if (dma_mapping_error(dma_dev, iter->addr)) { > iter->status = BLK_STS_RESOURCE; > return false; I wonder where is the corresponding dma_unmap_page() call and its change to dma_unmap_phys()... Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland