From: Philipp Stanner <phasta@mailbox.org>
To: "Krzysztof Wilczyński" <kw@linux.com>, phasta@kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jonathan Corbet <corbet@lwn.net>,
Bjorn Helgaas <bhelgaas@google.com>,
Mark Brown <broonie@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Zijun Hu <quic_zijuhu@quicinc.com>,
Yang Yingliang <yangyingliang@huawei.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/7] Docu: PCI: Update pcim_enable_device()
Date: Fri, 16 May 2025 15:41:31 +0200 [thread overview]
Message-ID: <2e80298be4bcb6b17f5b38302d6945306928c6b0.camel@mailbox.org> (raw)
In-Reply-To: <20250516132811.GB2390647@rocinante>
On Fri, 2025-05-16 at 22:28 +0900, Krzysztof Wilczyński wrote:
> Hello,
>
> [...]
> > > > pcim_enable_device() is not related anymore to switching the
> > > > mode
> > > > of
> > > > operation of any functions. It merely sets up a devres callback
> > > > for
> > > > automatically disabling the PCI device on driver detach.
> > > >
> > > > Adjust the function's documentation.
> > >
> > > Is the "Docu" prefix in thew Subject aligned with the git history
> > > of
> > > this file?
> > >
> >
> > Seems its "Documentation: ". Can fix.
>
> Has Andy been sending his review off-list? Or something is broken on
> my
> side...
Nope, it's on-list. Andy's a veteran ;-)
https://lore.kernel.org/linux-pci/aCXnPHy5heHCKVd_@smile.fi.intel.com/
>
> Philipp, if you have a v2 ready, then I would love to pull it, while
> we
> await for more reviews, just to get enough soak time and allow for
> the
> 0-day and KernelCI to run their usual tests, etc.
>
> Thank you!
I don't have it ready, but should be trivial to do, since it's not
fundamental critcism. I'll do my best.
P.
>
> Krzysztof
next prev parent reply other threads:[~2025-05-16 13:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 12:45 [PATCH 0/7] PCI: Remove hybrid-devres region requests Philipp Stanner
2025-05-15 12:45 ` [PATCH 1/7] PCI: Remove hybrid devres nature from request functions Philipp Stanner
2025-05-15 12:46 ` [PATCH 2/7] Docu: PCI: Update pcim_enable_device() Philipp Stanner
2025-05-15 12:58 ` Andy Shevchenko
2025-05-16 7:49 ` Philipp Stanner
2025-05-16 13:28 ` Krzysztof Wilczyński
2025-05-16 13:41 ` Philipp Stanner [this message]
2025-05-16 13:48 ` Krzysztof Wilczyński
2025-05-17 16:32 ` Andy Shevchenko
2025-05-15 12:46 ` [PATCH 3/7] PCI: Remove pcim_request_region_exclusive() Philipp Stanner
2025-05-15 12:46 ` [PATCH 4/7] PCI: Remove request_flags relict from devres Philipp Stanner
2025-05-15 13:00 ` Andy Shevchenko
2025-05-16 7:48 ` Philipp Stanner
2025-05-15 12:46 ` [PATCH 5/7] PCI: Remove redundant set of request funcs Philipp Stanner
2025-05-15 12:46 ` [PATCH 6/7] PCI: Remove unnecessary prototype from pci.h Philipp Stanner
2025-05-15 13:02 ` Andy Shevchenko
2025-05-15 13:37 ` Philipp Stanner
2025-05-16 9:16 ` Andy Shevchenko
2025-05-15 12:46 ` [PATCH 7/7] PCI: Remove hybrid-devres hazzard warnings from doc Philipp Stanner
2025-05-15 13:08 ` [PATCH 0/7] PCI: Remove hybrid-devres region requests Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e80298be4bcb6b17f5b38302d6945306928c6b0.camel@mailbox.org \
--to=phasta@mailbox.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=kw@linux.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=phasta@kernel.org \
--cc=quic_zijuhu@quicinc.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).