From: "Arnd Bergmann" <arnd@arndb.de>
To: "Ethan Nelson-Moore" <enelsonmoore@gmail.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Cc: "Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Max Nikulin" <manikulin@gmail.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] char: applicom: remove low-quality, unused driver
Date: Fri, 08 May 2026 08:30:30 +0200 [thread overview]
Message-ID: <2f229a4f-110a-437a-8ecb-51e2d6adf30b@app.fastmail.com> (raw)
In-Reply-To: <20260503035824.24078-1-enelsonmoore@gmail.com>
On Sun, May 3, 2026, at 05:58, Ethan Nelson-Moore wrote:
> The applicom driver supports PCI Profibus cards from Applicom, later
> acquired by Molex. It has severe coding style issues and has attracted
> a number of bug and security fixes over the years, despite the fact
> that no one appears to be using it. It was broken from at least the
> beginning of Git history (Linux 2.6.12-rc2 in April 2005) until October
> 2008, when a fatal bug was fixed in commit bc20589bf1c6 ("applicom.c:
> fix apparently-broken code in do_ac_read()"). In the commit message,
> the author commented that no one they knew was able to test the change.
> Since then, there have been no commits that indicate the driver is
> being used. Later PCI and PCI-Express Applicom Profibus cards only
> officially support Windows [1], and even the PCI-Express cards have
> been discontinued [2]. Given all these factors, remove the driver to
> reduce future maintenance workload.
>
> [1]
> https://www.sarcitalia.it/file_upload/prodotti//PCIE1500S7_PFB_987651-3769_0876250001505823933.pdf
> [2]
> https://us.rs-online.com/product/molex-woodhead-brad/112011-5026/70631928/
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
I recently looked at this when another fix came in and came to
similar conclusions, but at the wasn't sure if any users remain:
https://lore.kernel.org/all/5c4965c8-dcec-4faf-bd87-19ca7665fedc@app.fastmail.com/
Let's go with your patch now. If users do remain, they should
be able to either just revert the removal locally, or work
on reintroducing an improved driver.
Acked-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2026-05-08 6:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 3:58 [PATCH] char: applicom: remove low-quality, unused driver Ethan Nelson-Moore
2026-05-07 22:20 ` David Woodhouse
2026-05-08 6:30 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f229a4f-110a-437a-8ecb-51e2d6adf30b@app.fastmail.com \
--to=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=enelsonmoore@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manikulin@gmail.com \
--cc=martin.petersen@oracle.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox