Re: [PATCH V2] scripts/checktransupdate.py: add support for scanning directory

Re: [PATCH V2] scripts/checktransupdate.py: add support for scanning directory

[Nathan Chancellor]

Hi Haoyang,

On Tue, Aug 12, 2025 at 01:00:50AM +0800, Haoyang LIU wrote:
> Origin script can only accept a file as parameter, this commit enables
> it to scan a directory.
> 
> Usage example:
> ./scripts/checktransupdate.py Documentation/translations/zh_CN/dev-tools
> 
> Signed-off-by: Haoyang LIU <tttturtleruss@gmail.com>
> ---
> 
> V1 -> V2: remove the fix of missing "f" in f-string and make it a new patch
> 
>  scripts/checktransupdate.py | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)

Thanks for the update. While this seems reasonable to me from a purely
surface level glance over the actual Python, I have added the
Documentation folks that Dongliang added from the previous thread, who
really own and maintain this file (the original patch is at [1]). Please
include them in future revisions should they be necessary. It would
probably be good for something like this to be applied?

diff --git a/MAINTAINERS b/MAINTAINERS
index fe168477caa4..b7e3a8c8832e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7302,6 +7302,7 @@ P:	Documentation/doc-guide/maintainer-profile.rst
 T:	git git://git.lwn.net/linux.git docs-next
 F:	Documentation/
 F:	scripts/check-variable-fonts.sh
+F:	scripts/checktransupdate.py
 F:	scripts/documentation-file-ref-check
 F:	scripts/get_abi.py
 F:	scripts/kernel-doc*

[1]: https://lore.kernel.org/20250811170050.94997-1-tttturtleruss@gmail.com/

Cheers,
Nathan

Re: [PATCH V2] scripts/checktransupdate.py: add support for scanning directory

[Dongliang Mu]

On 8/12/25 5:24 AM, 'Nathan Chancellor' via HUST OS Kernel Contribution 
wrote:
> Hi Haoyang,
>
> On Tue, Aug 12, 2025 at 01:00:50AM +0800, Haoyang LIU wrote:
>> Origin script can only accept a file as parameter, this commit enables
>> it to scan a directory.
>>
>> Usage example:
>> ./scripts/checktransupdate.py Documentation/translations/zh_CN/dev-tools
>>
>> Signed-off-by: Haoyang LIU <tttturtleruss@gmail.com>
>> ---
>>
>> V1 -> V2: remove the fix of missing "f" in f-string and make it a new patch
>>
>>   scripts/checktransupdate.py | 24 ++++++++++++++++++++++++
>>   1 file changed, 24 insertions(+)
> Thanks for the update. While this seems reasonable to me from a purely
> surface level glance over the actual Python, I have added the
> Documentation folks that Dongliang added from the previous thread, who
> really own and maintain this file (the original patch is at [1]). Please
> include them in future revisions should they be necessary. It would
> probably be good for something like this to be applied?

Thanks for the suggestion. I've submitted a patch[1].

[1] 
https://lore.kernel.org/linux-doc/20250812050711.2515173-1-dzm91@hust.edu.cn/

>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fe168477caa4..b7e3a8c8832e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7302,6 +7302,7 @@ P:	Documentation/doc-guide/maintainer-profile.rst
>   T:	git git://git.lwn.net/linux.git docs-next
>   F:	Documentation/
>   F:	scripts/check-variable-fonts.sh
> +F:	scripts/checktransupdate.py
>   F:	scripts/documentation-file-ref-check
>   F:	scripts/get_abi.py
>   F:	scripts/kernel-doc*
>
> [1]: https://lore.kernel.org/20250811170050.94997-1-tttturtleruss@gmail.com/
>
> Cheers,
> Nathan
>

Re: [PATCH V2] scripts/checktransupdate.py: add support for scanning directory

[Haoyang LIU]

> On 12 Aug 2025, at 05:24, Nathan Chancellor <nathan@kernel.org> wrote:
> 
> Hi Haoyang,
> 
> On Tue, Aug 12, 2025 at 01:00:50AM +0800, Haoyang LIU wrote:
>> Origin script can only accept a file as parameter, this commit enables
>> it to scan a directory.
>> 
>> Usage example:
>> ./scripts/checktransupdate.py Documentation/translations/zh_CN/dev-tools
>> 
>> Signed-off-by: Haoyang LIU <tttturtleruss@gmail.com>
>> ---
>> 
>> V1 -> V2: remove the fix of missing "f" in f-string and make it a new patch
>> 
>> scripts/checktransupdate.py | 24 ++++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
> 
> Thanks for the update. While this seems reasonable to me from a purely
> surface level glance over the actual Python, I have added the
> Documentation folks that Dongliang added from the previous thread, who
> really own and maintain this file (the original patch is at [1]). Please
> include them in future revisions should they be necessary. It would
> probably be good for something like this to be applied?
Hi Nathan
That makes sense. My V1 patch also missed Dongliang Mu and the other maintainers. Thanks for pointing it out.

Sincerely,
Haoyang
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fe168477caa4..b7e3a8c8832e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7302,6 +7302,7 @@ P: Documentation/doc-guide/maintainer-profile.rst
> T: git git://git.lwn.net/linux.git docs-next
> F: Documentation/
> F: scripts/check-variable-fonts.sh
> +F: scripts/checktransupdate.py
> F: scripts/documentation-file-ref-check
> F: scripts/get_abi.py
> F: scripts/kernel-doc*
> 
> [1]: https://lore.kernel.org/20250811170050.94997-1-tttturtleruss@gmail.com/
> 
> Cheers,
> Nathan