From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6761045039; Sat, 6 Jun 2026 07:34:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780731259; cv=none; b=ep4Zus8BMSGTETWeMOzYkPJlZFw61QGxGNDo/GwR4DWz0nuxGp6JZeXoa3bOLi8IPqOgSaZHUkOcQjA8Z5K0QlKRXCBexmB4dRK7Cg3omscqBwaec7SxBRs/UeVRDOWQpyg84w59d9LCISgsQOa1VGkYFChOPPBORAQIMYfTHaI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780731259; c=relaxed/simple; bh=Hj4jtNlmm4TyAKUXCKYOWfzfBlQpj3Y4D+j5+2tpzEM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s6XjLmILUogcFbuGeHQPwBFsU4Q2ZdAT8JMThwCR/72CCl/nRgQcJWaTQrUtiE/xvAfsHWJM6DpdZSMd4NdbBuQL18iDeviLfLh94YSH6wBj0SXB/gOFQUt9KUExsnTGHKvuFuDLOO3MqbIJpzzUxPKuIt7ZrszqpS8rpcFuD2I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Fx7684AQ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Fx7684AQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2C2C1F00893; Sat, 6 Jun 2026 07:34:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780731258; bh=EnqYGUdPmuADwtZ4RT0d+RNOynoAs9q0xEap8W9Djtg=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=Fx7684AQRixnSFIhI3q7J2qXC/Fxx17OV8Ee3KgrbzF/nq79QZ6JsPgz8J47VS6g4 iorwffelSHkkEVd5bbz9d+OjIVEkwtRsrRPn3CJj2unu7RlEO9/+/siH+Obj6k6I0N Y5rYNel4riZqW2tfKvIW8xps1HKdx72LEGjT1aszG/cH1Xnl0eHPel949XQLEgx7sW muT7d4H5b7B83VcTZzC6Rk8h8JprMWVOKKXDGqipqRI2G1/qjpiQ7NwpmMv/wmtBbl TIhpSTeXIcOLrwURx/3SbQ9jZuSoyl9Rpe3vvs9sJruoNFmrDHV0KdaCZ9f90s8c3k ix0XdgK0U78aA== Message-ID: <32705660-cd65-423f-a04b-8c6babed53bf@kernel.org> Date: Sat, 6 Jun 2026 15:33:59 +0800 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] block: add configurable error injection To: Christoph Hellwig , Jens Axboe Cc: Jonathan Corbet , linux-block@vger.kernel.org, linux-doc@vger.kernel.org References: <20260605184441.590927-1-hch@lst.de> <20260605184441.590927-5-hch@lst.de> Content-Language: en-US From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20260605184441.590927-5-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2026/06/06 2:44, Christoph Hellwig wrote: > Add a new block error injection interface that allows to inject specific > status code for specific ranges. > > Signed-off-by: Christoph Hellwig [...] > +=================== ======================================================= > +op=%s block layer operation this rule applies to, e.g. READ > + or WRITE. Like you did in the commit message of patch 3, maybe mention that this should match "XYZ" of one of the defined REQ_OP_XYZ operation ? > + Mandatory. > +start=%u First block layer sector the rule applies to. > + Optional, defaults to 0. > +nr_sectors=%u Number of sectors this rule applies. > + Optional, defaults to the remainder of the device. > +status=%s Status to return. Maybe mention that this should match XYZ for one one of the defined BLK_STS_XYZ ? > + Mandatory. > +chance=%u Only return a failure with a likelihood of 1/chance. > + Optional, defaults to 1 (always). > +=================== ======================================================= [...] > + /* > + * Add to the front of the list so that newer entries can partially > + * override other entries. This also intentional allows duplicate s/intentional/intentionally > + * entries as there is no real reason to reject them. > + */ Beside these nits, looks good to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research