From: Alistair Popple <apopple@nvidia.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <linux-mm@kvack.org>, <nouveau@lists.freedesktop.org>,
<bskeggs@redhat.com>, <akpm@linux-foundation.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>, <jhubbard@nvidia.com>,
<rcampbell@nvidia.com>, <jglisse@redhat.com>, <jgg@nvidia.com>,
<daniel@ffwll.ch>
Subject: Re: [PATCH v3 1/8] mm: Remove special swap entry functions
Date: Tue, 2 Mar 2021 23:02:01 +1100 [thread overview]
Message-ID: <3345714.hC2lq6CL0I@nvdebian> (raw)
In-Reply-To: <2110609.1zlQqR5hOE@nvdebian>
On Tuesday, 2 March 2021 7:52:53 PM AEDT Alistair Popple wrote:
> On Saturday, 27 February 2021 2:59:09 AM AEDT Christoph Hellwig wrote:
> > > - struct page *page = migration_entry_to_page(entry);
> > > + struct page *page = pfn_to_page(swp_offset(entry));
> >
> > I wonder if keeping a single special_entry_to_page() helper would still
> > me a useful. But I'm not entirely sure. There are also two more open
> > coded copies of this in the THP migration code.
>
> I think it might be if only to clearly document where these entries are
used.
> Will add it for the next version to see what it looks like.
Actually the main advantage ends up being that it becomes easy to retain the
page locked check for migration entries.
- Alistair
next prev parent reply other threads:[~2021-03-02 18:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 7:18 [PATCH v3 0/8] Add support for SVM atomics in Nouveau Alistair Popple
2021-02-26 7:18 ` [PATCH v3 1/8] mm: Remove special swap entry functions Alistair Popple
2021-02-26 15:59 ` Christoph Hellwig
2021-03-02 8:52 ` Alistair Popple
2021-03-02 12:02 ` Alistair Popple [this message]
2021-03-01 17:46 ` Jason Gunthorpe
2021-03-02 0:21 ` Alistair Popple
2021-02-26 7:18 ` [PATCH v3 2/8] mm/swapops: Rework swap entry manipulation code Alistair Popple
2021-02-26 16:00 ` Christoph Hellwig
2021-03-01 17:47 ` Jason Gunthorpe
2021-02-26 7:18 ` [PATCH v3 3/8] mm/rmap: Split try_to_munlock from try_to_unmap Alistair Popple
2021-02-26 16:01 ` Christoph Hellwig
2021-03-01 16:10 ` Jason Gunthorpe
2021-03-04 4:27 ` Alistair Popple
2021-02-26 7:18 ` [PATCH v3 4/8] mm/rmap: Split migration into its own function Alistair Popple
2021-02-26 16:03 ` Christoph Hellwig
2021-03-02 22:08 ` Zi Yan
2021-03-04 23:54 ` Alistair Popple
2021-02-26 7:18 ` [PATCH v3 5/8] mm: Device exclusive memory access Alistair Popple
2021-03-01 17:54 ` Jason Gunthorpe
2021-03-01 22:55 ` Ralph Campbell
2021-03-02 0:05 ` Jason Gunthorpe
2021-03-02 8:57 ` Alistair Popple
2021-03-02 12:41 ` Jason Gunthorpe
2021-03-04 5:20 ` Alistair Popple
2021-02-26 7:18 ` [PATCH v3 6/8] mm: Selftests for exclusive device memory Alistair Popple
2021-03-01 17:55 ` Jason Gunthorpe
2021-03-01 18:07 ` Ralph Campbell
2021-03-01 23:14 ` Ralph Campbell
2021-03-02 9:12 ` Alistair Popple
2021-02-26 7:18 ` [PATCH v3 7/8] nouveau/svm: Refactor nouveau_range_fault Alistair Popple
2021-02-26 7:18 ` [PATCH v3 8/8] nouveau/svm: Implement atomic SVM access Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3345714.hC2lq6CL0I@nvdebian \
--to=apopple@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=jgg@nvidia.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).