From: Janosch Frank <frankja@linux.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Christoph Schlameuss <schlameuss@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] s390/kvm: Reject memory region operations for ucontrol VMs
Date: Thu, 27 Jun 2024 14:32:51 +0200 [thread overview]
Message-ID: <35cb7d12-d93b-4fbb-98fe-10ce2e6358f2@linux.ibm.com> (raw)
In-Reply-To: <CABgObfYxZZdwe94u7OvHPUx+u4fDEJLnBEQbk1hdYs_Zy0D2hA@mail.gmail.com>
On 6/27/24 13:53, Paolo Bonzini wrote:
> On Mon, Jun 24, 2024 at 11:59 AM Christoph Schlameuss
> <schlameuss@linux.ibm.com> wrote:
>>
>> This change rejects the KVM_SET_USER_MEMORY_REGION and
>> KVM_SET_USER_MEMORY_REGION2 ioctls when called on a ucontrol VM.
>> This is neccessary since ucontrol VMs have kvm->arch.gmap set to 0 and
>> would thus result in a null pointer dereference further in.
>> Memory management needs to be performed in userspace and using the
>> ioctls KVM_S390_UCAS_MAP and KVM_S390_UCAS_UNMAP.
>>
>> Also improve s390 specific documentation for KVM_SET_USER_MEMORY_REGION
>> and KVM_SET_USER_MEMORY_REGION2.
>
> Would be nice to have a selftest for ucontrol VMs, too... just saying :)
>
> Paolo
>
Already in the works, he just hasn't posted it yet :)
We did do a couple rounds of internal feedback on the tests first.
next prev parent reply other threads:[~2024-06-27 12:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 9:59 [PATCH] s390/kvm: Reject memory region operations for ucontrol VMs Christoph Schlameuss
2024-06-24 15:33 ` Claudio Imbrenda
2024-06-27 11:52 ` Janosch Frank
2024-06-27 11:53 ` Paolo Bonzini
2024-06-27 12:32 ` Janosch Frank [this message]
2024-06-27 18:47 ` Christoph Schlameuss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35cb7d12-d93b-4fbb-98fe-10ce2e6358f2@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=schlameuss@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).