From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF008252917 for ; Mon, 10 Feb 2025 14:39:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739198344; cv=none; b=Q1PKznb7Bv8X94fIk8Jnet08IH5WrsoSqLLHH5VKlnYknB1Uyss5jRndM8fGTBbEWa08OI0lAugAA2rwQThU5cv6VWrmVuX1pzkkGWfxKZXpeevKr5Y0EHck/GSs4r+/VFyLRzBK+sJxuwv9Jpv20jEaKKSW75lq5q/joA6vA7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739198344; c=relaxed/simple; bh=LLZv8spMczu++PFSJ3yUBhOJ9eSME+MogTlX8kOq+/I=; h=Message-ID:Date:MIME-Version:Subject:Cc:References:From: In-Reply-To:Content-Type; b=I6By8Gf5IcwoG7dnS2pMikfSuyC765ysIml7pASX9NKgfGqmKsekUFSxMZ+lTJb+icmvlBCBuLSMf35HbAe+PqFScRZvQBhwl2jop7XuL+vlLng7nfI230qJCvdo32k3dWpWI9MYdDc3l6tK2RfbVqvRMkQofCK0X8GC2v/TLqQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=q9SBBPWm; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="q9SBBPWm" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4361e89b6daso30361055e9.3 for ; Mon, 10 Feb 2025 06:39:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1739198341; x=1739803141; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=Zo0VN4ey+NCxOpRRNUPLhuYri5JxBmbs9To1sFVTXQI=; b=q9SBBPWmLmywLTglIF0FlOH9SU6aUbhslPY3lnGCOkHVIkbYbekI84lz1MsKVcNt9G fenSxMkTOwov+JfqDIyBdyo5QJJdidEFMk6q7n1JJree8eV4PLvYfAFRFlJC+7QkvW4R ffr/1a/rYXw8jLf5QSwSmXayjIAFqBjfQrW6qOgQ3ElIO6frZS9QgkSLg1wiaYx5B+kR 9p7xNzuhBBE5JxSq38QKanS6Jk2NoJ/xtjb9kyTJ0K28HHsyEG0feiaFw0CyAuIDUNBW BeGh0A1QaDGKa7Y7ESKvR+TVQuWY87tLyXLJrFLf9Pt6E3llb0Z+DC/JeoVKG9L6l4iY JI+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739198341; x=1739803141; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Zo0VN4ey+NCxOpRRNUPLhuYri5JxBmbs9To1sFVTXQI=; b=gVHV/NNxgTlt0fecCl2C+IsP7HpQyaosrzzyBi4/OE6FSignr1541qq4I/PqQOrJzv wakwhTFJhwZh/qapqx6K4zO4i13nVoZjq4ybs3foI/4VS2xcM9baiazozt6CDpds7CK7 2iT6czs2zz0tXjvHINEgFKqkA1ZsSsH1DVHvrEUDRwKoPI1RVtX6j2XSl8BsdDJBj/g/ FNtFGVePUVfPmUnOmCvh3CXYIxO+aggtCrtFME9nTAcjXG8PtmhX7tmL3QyFrLR/2NZ4 XJzdB5t+Mwr2Ld15Z8QwXgvY+F0UOY1LufrIShlHMCU5JcF6W6IICdY09YdZICDZwrgv wj0w== X-Gm-Message-State: AOJu0YybmK596uSEevEKbRUOVh9B4m+VX8G+P5Z0UwvQ47d2rewtlqFU 3gD/SFFAVBCinOjt12opBeFl9Hg50pkyaOyI6NZU0adAk1vqS4C9VDJXmh6hmW8HOrcnSuh+1/O 9eW8= X-Gm-Gg: ASbGncvR5vE5hRmqKC4xebfCBuHgFPgNNINsSA4rFW7ECXuShhWyJH0+jiQEWN2BL5m zD1IF+isyXKNZfS4IGRNcaRqdSi53AUpCLYNnl4uDpUZY25eS6dfCvSuTA7GqkfUDqdK7bh7hFs 7blnxPLb9/w4uPCZ/bCGUqYpYDljU5JqlKe8laPYG3Pn8OFXb4yEiijLtkM78ZmfFRQ+izuN2h2 76krP7wOq11QA9rTUIBz3c9LmfxqVXUIQpg1Rhbcu0QpN2PEU4Y1+W4rSbAuhA+EXctviiIWDD4 uo1+iHqjOaDiJ0eX7u2EvLrpJJ5RJSz02UwQTzOMuzNhyyAaFGLxTWDWjDis X-Google-Smtp-Source: AGHT+IGm5AlxQcuKzP0PEYl2wRs1l7PkvTwrGGHXffc7rJgV/RWXIbNwUCK7tjW///sMOC1+p0rrnA== X-Received: by 2002:a05:600c:56d0:b0:434:9c1b:b36a with SMTP id 5b1f17b1804b1-4392dfbd5d8mr83693895e9.13.1739198340511; Mon, 10 Feb 2025 06:39:00 -0800 (PST) Received: from ?IPV6:2a01:e0a:e17:9700:16d2:7456:6634:9626? ([2a01:e0a:e17:9700:16d2:7456:6634:9626]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4394127afcbsm45103195e9.23.2025.02.10.06.38.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Feb 2025 06:39:00 -0800 (PST) Message-ID: <374d3b07-e16c-4468-828a-a2a542cd88ac@rivosinc.com> Date: Mon, 10 Feb 2025 15:38:58 +0100 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] riscv: add ISA extension parsing for bfloat16 ISA extension Cc: linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Yixun Lan , Longbin Li , Jesse Taube , Yong-Xuan Wang , Samuel Holland , Krzysztof Kozlowski , Evan Green , Andrew Jones , Alexandre Ghiti , Andy Chiu , Charlie Jenkins , Conor Dooley , Rob Herring , Albert Ou , Palmer Dabbelt , Paul Walmsley , Jonathan Corbet , Chen Wang , Inochi Amaoto References: <20241206055829.1059293-1-inochiama@gmail.com> <20241206055829.1059293-3-inochiama@gmail.com> Content-Language: en-US From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= In-Reply-To: <20241206055829.1059293-3-inochiama@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 06/12/2024 06:58, Inochi Amaoto wrote: > Add parsing for Zfbmin, Zvfbfmin, Zvfbfwma ISA extension which > were ratified in 4dc23d62 ("Added Chapter title to BF16") of > the riscv-isa-manual. > > Signed-off-by: Inochi Amaoto > --- > arch/riscv/include/asm/hwcap.h | 3 +++ > arch/riscv/kernel/cpufeature.c | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/arch/riscv/include/asm/hwcap.h b/arch/riscv/include/asm/hwcap.h > index 869da082252a..14cc29f2a723 100644 > --- a/arch/riscv/include/asm/hwcap.h > +++ b/arch/riscv/include/asm/hwcap.h > @@ -100,6 +100,9 @@ > #define RISCV_ISA_EXT_ZICCRSE 91 > #define RISCV_ISA_EXT_SVADE 92 > #define RISCV_ISA_EXT_SVADU 93 > +#define RISCV_ISA_EXT_ZFBFMIN 94 > +#define RISCV_ISA_EXT_ZVFBFMIN 95 > +#define RISCV_ISA_EXT_ZVFBFWMA 96 > > #define RISCV_ISA_EXT_XLINUXENVCFG 127 > > diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c > index c0916ed318c2..5cfcab139568 100644 > --- a/arch/riscv/kernel/cpufeature.c > +++ b/arch/riscv/kernel/cpufeature.c > @@ -341,6 +341,7 @@ const struct riscv_isa_ext_data riscv_isa_ext[] = { > __RISCV_ISA_EXT_DATA(zacas, RISCV_ISA_EXT_ZACAS), > __RISCV_ISA_EXT_DATA(zawrs, RISCV_ISA_EXT_ZAWRS), > __RISCV_ISA_EXT_DATA(zfa, RISCV_ISA_EXT_ZFA), > + __RISCV_ISA_EXT_DATA(zfbfmin, RISCV_ISA_EXT_ZFBFMIN), Hi Inochi, You could add a validation callback to that extension: static int riscv_ext_f_depends(const struct riscv_isa_ext_data *data, const unsigned long *isa_bitmap) { if (__riscv_isa_extension_available(isa_bitmap, RISCV_ISA_EXT_f)) return 0; return -EPROBE_DEFER; } ... __RISCV_ISA_EXT_DATA_VALIDATE(zfbfmin, RISCV_ISA_EXT_ZFBFMIN, riscv_ext_f_depends), But I'm ok with the current state of that patch since I have the same thing coming for other extensions as well. So with or without my previous comment fixed: Reviewed-by: Clément Léger Thanks, Clément > __RISCV_ISA_EXT_DATA(zfh, RISCV_ISA_EXT_ZFH), > __RISCV_ISA_EXT_DATA(zfhmin, RISCV_ISA_EXT_ZFHMIN), > __RISCV_ISA_EXT_DATA(zca, RISCV_ISA_EXT_ZCA), > @@ -373,6 +374,8 @@ const struct riscv_isa_ext_data riscv_isa_ext[] = { > __RISCV_ISA_EXT_SUPERSET(zve64d, RISCV_ISA_EXT_ZVE64D, riscv_zve64d_exts), > __RISCV_ISA_EXT_SUPERSET(zve64f, RISCV_ISA_EXT_ZVE64F, riscv_zve64f_exts), > __RISCV_ISA_EXT_SUPERSET(zve64x, RISCV_ISA_EXT_ZVE64X, riscv_zve64x_exts), > + __RISCV_ISA_EXT_DATA(zvfbfmin, RISCV_ISA_EXT_ZVFBFMIN), > + __RISCV_ISA_EXT_DATA(zvfbfwma, RISCV_ISA_EXT_ZVFBFWMA), > __RISCV_ISA_EXT_DATA(zvfh, RISCV_ISA_EXT_ZVFH), > __RISCV_ISA_EXT_DATA(zvfhmin, RISCV_ISA_EXT_ZVFHMIN), > __RISCV_ISA_EXT_DATA(zvkb, RISCV_ISA_EXT_ZVKB),