From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 7BB307D2F0 for ; Thu, 15 Aug 2019 05:05:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730097AbfHOFFf (ORCPT ); Thu, 15 Aug 2019 01:05:35 -0400 Received: from mga18.intel.com ([134.134.136.126]:36254 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730092AbfHOFFe (ORCPT ); Thu, 15 Aug 2019 01:05:34 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2019 22:05:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,388,1559545200"; d="scan'208";a="171013666" Received: from allen-box.sh.intel.com (HELO [10.239.159.136]) ([10.239.159.136]) by orsmga008.jf.intel.com with ESMTP; 14 Aug 2019 22:05:30 -0700 Cc: baolu.lu@linux.intel.com, corbet@lwn.net, tony.luck@intel.com, fenghua.yu@intel.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org, linux-doc@vger.kernel.org, linux-ia64@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Thomas.Lendacky@amd.com, Suravee.Suthikulpanit@amd.com, Joerg Roedel Subject: Re: [PATCH 07/10] iommu: Print default domain type on boot To: Joerg Roedel References: <20190814133841.7095-1-joro@8bytes.org> <20190814133841.7095-8-joro@8bytes.org> From: Lu Baolu Message-ID: <39163f22-0c22-ccae-84df-e65f53aa1a82@linux.intel.com> Date: Thu, 15 Aug 2019 13:04:30 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190814133841.7095-8-joro@8bytes.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hi, On 8/14/19 9:38 PM, Joerg Roedel wrote: > From: Joerg Roedel > > Introduce a subsys_initcall for IOMMU code and use it to > print the default domain type at boot. > > Signed-off-by: Joerg Roedel > --- > drivers/iommu/iommu.c | 30 +++++++++++++++++++++++++++++- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index e1feb4061b8b..233bc22b487e 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -93,12 +93,40 @@ struct iommu_group_attribute iommu_group_attr_##_name = \ > static LIST_HEAD(iommu_device_list); > static DEFINE_SPINLOCK(iommu_device_lock); > > +/* > + * Use a function instead of an array here because the domain-type is a > + * bit-field, so an array would waste memory. > + */ > +static const char *iommu_domain_type_str(unsigned int t) > +{ > + switch (t) { > + case IOMMU_DOMAIN_BLOCKED: > + return "Blocked"; > + case IOMMU_DOMAIN_IDENTITY: > + return "Passthrough"; > + case IOMMU_DOMAIN_UNMANAGED: > + return "Unmanaged"; > + case IOMMU_DOMAIN_DMA: > + return "Translated"; > + default: > + return "Unknown"; > + } > +} Run scripts/checkpatch.pl: ERROR: switch and case should be at the same indent #28: FILE: drivers/iommu/iommu.c:102: + switch (t) { + case IOMMU_DOMAIN_BLOCKED: [...] + case IOMMU_DOMAIN_IDENTITY: [...] + case IOMMU_DOMAIN_UNMANAGED: [...] + case IOMMU_DOMAIN_DMA: [...] + default: Best regards, Lu Baolu > + > +static int __init iommu_subsys_init(void) > +{ > + pr_info("Default domain type: %s\n", > + iommu_domain_type_str(iommu_def_domain_type)); > + > + return 0; > +} > +subsys_initcall(iommu_subsys_init); > + > int iommu_device_register(struct iommu_device *iommu) > { > spin_lock(&iommu_device_lock); > list_add_tail(&iommu->list, &iommu_device_list); > spin_unlock(&iommu_device_lock); > - > return 0; > } > >