Re: [PATCH v4 0/3] Add max-power platform profile

["Mark Pearson" <mpearson-lenovo@squebb.ca>]

On Thu, Nov 27, 2025, at 10:16 AM, Derek J. Clark wrote:
> This series adds a new "max-power" platform profile mode and uses it for
> the lenovo-wmi-gamezone driver. It also adds the Lenovo Legion Go 2 to
> the extreme mode quirks table.
>
> On some Lenovo Legion devices there is a thermal mode called extreme
> that corresponds to setting ppt/spl vlaues to the maximum achievable by
> the cooling solution. This correlates strongly with an overall power draw
> that exceeds the DC power draw capability of the internal battery. This
> mode being mapped to performance when extreme mode is detected as
> supported, with the actual performance mode being set to
> balanced-performance, has led to some misinformation being promulgated
> that performance is always a bad setting in Linux for these devices.
> There is also some confusion that the mode labeled performance in
> userspace, which corresponds to a red LED in Windows, shows as purple
> when set using the hardware extreme mode.
>
> I'll also note that as the hard TDP limits are refreshed when on AC or DC
> by the ACPI notifier of lenovo-wmi-other method driver, no special handling
> of the battery is needed for safety limiting extreme mode.
>
> Signed-off-by: Derek J. Clark <derekjohn.clark@gmail.com>
>
> ---
> v4:
>  - prevent  platform_profile_cycle() from selecting max_power.
> v3: 
> https://lore.kernel.org/platform-driver-x86/20251113212639.459896-1-derekjohn.clark@gmail.com/
>  - Rename the vendor specific "extreme" to a vendor agnositic 
> "max-power"
>    to better allign with the "low-power" platform profile.
> v2: 
> https://lore.kernel.org/platform-driver-x86/20251106212121.447030-1-derekjohn.clark@gmail.com/
>  - Drop patch 3/3, keep extreme mode quirks table
>  - Add Legion Go 2 to quirks table
>  - Fix nits from Mario
> v1: 
> https://lore.kernel.org/platform-driver-x86/20251026081240.997038-1-derekjohn.clark@gmail.com/
>
>
> Derek J. Clark (3):
>   acpi: platform_profile - Add max-power profile option
>   platform/x86: lenovo-wmi-gamezone Use max-power rather than
>     balanced-performance
>   platform/x86: wmi-gamezone: Add Legion Go 2 Quirks
>
>  .../ABI/testing/sysfs-class-platform-profile  |  2 ++
>  .../wmi/devices/lenovo-wmi-gamezone.rst       | 31 ++++++++--------
>  drivers/acpi/platform_profile.c               |  7 ++--
>  drivers/platform/x86/lenovo/wmi-gamezone.c    | 35 +++++++++++--------
>  include/linux/platform_profile.h              |  1 +
>  5 files changed, 44 insertions(+), 32 deletions(-)
>
> -- 
> 2.51.2

For the series - looks good to me.
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>

Mark