Linux Documentation
 help / color / mirror / Atom feed
From: Gabriele Monaco <gmonaco@redhat.com>
To: Nam Cao <namcao@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	linux-trace-kernel@vger.kernel.org, 	linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] rv/rtapp: Add wakeup monitor
Date: Thu, 02 Jul 2026 14:12:54 +0200	[thread overview]
Message-ID: <3b0cb6e06b52607ba4de8202e197391abd585cfd.camel@redhat.com> (raw)
In-Reply-To: <87ldbtvoo8.fsf@yellow.woof>

On Thu, 2026-07-02 at 09:25 +0200, Nam Cao wrote:
> Gabriele Monaco <gmonaco@redhat.com> writes:
> > This looks good, but if I understand it correctly, the same violation should
> > be
> > spotted by both monitors from two different perspectives, but sleep catches
> > more
> > things (e.g. tasks using wrong sleeping ways despite their wakeup):
> > 
> >   # perf stat -a -e rv:error_sleep -e rv:error_wakeup -- stress-ng --cpu 5 -
> > -cpu-load 90 --sched rr -t 5
> > 
> >    Performance counter stats for 'system wide':
> > 
> >                285     
> > rv:error_sleep                                         
> >                 20     
> > rv:error_wakeup                                        
> > 
> > Provided I don't really know what's happening down there (I just let the
> > stressor run free), this discrepancy is expected, right?
> 
> Thanks for testing it.
> 
> Beside monitoring low-prio task waking high-prio task, the rtapp/sleep
> monitor also checks that user uses the correct APIs for sleeping. So
> yes, this discrepancy is expected.

Alright makes sense, thanks.

Reviewed-by: Gabriele Monaco <gmonaco@redhat.com>

      reply	other threads:[~2026-07-02 12:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-19  7:21 [PATCH v2 0/4] rv: rtapp monitor update Nam Cao
2026-06-19  7:21 ` [PATCH v2 1/4] rv/rtapp/sleep: Make the error more informative for user Nam Cao
2026-07-01 12:26   ` Gabriele Monaco
2026-07-01 12:34     ` Gabriele Monaco
2026-06-19  7:21 ` [PATCH v2 2/4] rv/rtapp/sleep: Update nanosleep rule Nam Cao
2026-07-01 12:29   ` Gabriele Monaco
2026-06-19  7:21 ` [PATCH v2 3/4] rv/rtapp/sleep: Stop monitoring kernel threads Nam Cao
2026-07-01 13:02   ` Gabriele Monaco
2026-06-19  7:21 ` [PATCH v2 4/4] rv/rtapp: Add wakeup monitor Nam Cao
2026-07-01 13:11   ` Gabriele Monaco
2026-07-02  7:25     ` Nam Cao
2026-07-02 12:12       ` Gabriele Monaco [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b0cb6e06b52607ba4de8202e197391abd585cfd.camel@redhat.com \
    --to=gmonaco@redhat.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=namcao@linutronix.de \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox