From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011015.outbound.protection.outlook.com [40.107.130.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B64003A3E88; Fri, 29 May 2026 06:33:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.15 ARC-Seal:i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780036397; cv=fail; b=sI9992kTkrEKVsf6NYjBlM47c8MmarScI0YWKbGQTtQVBaq9RZpIN2Tq/8Vlav0OedWCPIqBTNqHzqgt/U0VIYoAHUX/1Lyp59qj6wxpl3f0exJPintuW5eb4ltwzphR62C6ZrWE6delpGh9e+RDY4S/S/nbe9sUw/pPmGj9TO4= ARC-Message-Signature:i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780036397; c=relaxed/simple; bh=ZKtx4uyZa05n62hu/dKdAYa3Qyr42C2Hkg6HUOGgMKc=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=RxBwFKMNR7s0sCbodWCp26Nx3EPuioR/I8NNbLPniPBQ7Yn3O3eMpgBMuF40bcs3q/Az+5vFVGtvXGx18DW7r91XTk38zd/mMRSKvEl/5SSN27tjZP9dGHFbpJfE7k0z0JMq5JvHnkMnJG0d5LtUAHXCg8IYgeWn075mw5SbCkk= ARC-Authentication-Results:i=3; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=THi7Jff6; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=THi7Jff6; arc=fail smtp.client-ip=40.107.130.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="THi7Jff6"; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="THi7Jff6" ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=dnRvtIUt25yeguLBaYWCfpWZdcrU5UdVLpTWDLnPVvLBlfrSlWVjODTieR7p9B9zQLLUgbWwYnzCvwv6XO+5xVd1fcKXKbGfDu3A+Ovw2KnR2231N7y2RYEs3RaPz3Kos9sypX03zrSAh9efhFhwyBhXXdwbUkW0J88wujxbnQqMSFT8MvQRWUiMY5eMrpjduWLD30hxyakyFDhXDnn4bi3bhXqjoZVkorTXxeGDnGrLIqPkotLLTwMBMkVVznpituWQ2JzqW/nohE+iQnSqos7EQ4q0MRCCOqofUccO7OWldZT/oAR1/TpwpCrRm2ryP66hjWX4OJi2lt66BvprhA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GW0CP+ZsZC4al5ZwOSMYomFQLHQKOerVe7jZ0jYNcrU=; b=AVBQCGJFOlGFVuTihMfZwHNiW5J+Ya4PS029SH2LfHR71arLmW9M8BFkZy0n2TX5QnM8Ys3uQ+DOkWda3nMemU6s5bRzAclK/AoVxjxKH/EvkjZ0RRgPeDQJiqUHXOoMyeZ7JZRsyG9Tco2xmfoM7ciSc0TSbosb7cTKJ1tpnKOQRrPj8ZZt5nCon5vlbsW1arh/4JlVU420WndYDIIFof+IqhgHLj8DVZ2NDI3oj1W+xh98XH21igNpeHhGCUzDUlCrlpzfjgS4wfdY1uYtf7tejhU3Lzf3+FAj5pZsx33lHs3AFCj6adcXYd30lK7H/MQ/S8Oqr0sLDZ2BYMT4pg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=linux-foundation.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GW0CP+ZsZC4al5ZwOSMYomFQLHQKOerVe7jZ0jYNcrU=; b=THi7Jff6jkViJnCpuIHMfbBqt2M0fhgvOcH7aFitLjt212EmMrBOjnTRX1BQceOIb2JM2UT0zvPA8wJeT7XYKKCBUJM+dCUYmk3uyQApa3wVBbcTHoHkRNqfYr6uZmo8wphxASxVqYqOvMCZLOwQRHb5nPYB8k0dz4aSLyAaVEc= Received: from AS8PR04CA0049.eurprd04.prod.outlook.com (2603:10a6:20b:312::24) by DB4PR08MB8032.eurprd08.prod.outlook.com (2603:10a6:10:388::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.15; Fri, 29 May 2026 06:33:11 +0000 Received: from AMS1EPF0000004E.eurprd04.prod.outlook.com (2603:10a6:20b:312:cafe::8a) by AS8PR04CA0049.outlook.office365.com (2603:10a6:20b:312::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.71.13 via Frontend Transport; Fri, 29 May 2026 06:33:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AMS1EPF0000004E.mail.protection.outlook.com (10.167.16.139) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Fri, 29 May 2026 06:33:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hN6NjjapgGaBIu+z5x08x8Wf/AurLiY6K4HLJcnrpJDoxPEzIHZt8O+PcAyJq4+XsfgrPTQzHFVnhe/JYGb5q2+2AvfyVLj3HpohcobTjFM6+6cy1MKyGBN5XpHmy7uw+X2wFU/Wi8MnG70C9LerTBp1hfiirQPI+6vOFyaDYTXacRFykjXjTlGW1XP8CE/tMRDGcXqqCWPW2KlXtpCQMIFSscqhxt30e/gB+8m8VokiQAItK7aIJqw6+nWEH6K/KcVDOQUnDLs5q0yEm3pDfifLMP3jloU88oCh2Bb3u8MSVyJX6eszMgsqQL1h0I9Y5GzrcwFmpD2awFbjQEvEtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GW0CP+ZsZC4al5ZwOSMYomFQLHQKOerVe7jZ0jYNcrU=; b=SByACEEAtSZM0yxm6/WLHayO2jAyaBIavoAvph1g3Px8Qns4+OzbUw8PFgK1JXF/lROXYrqvFBKCPZy8/LRzQCnXhoVaeE0+QXh3iixlg3rCQsUe7NnDUpNTKuMYjIphhOJgwstEmM1V/ymV5L8RubLoq0Z16kPld+31OEK9CD7Yd4zuKYHZbuojdhz2MFgzi78RiaoifomEkyOj4pOtjo8yqqeaOsjAW0iJDDbD23BNfYw/nm86PMcNeWpkpvIW6glws/BgL6YLdGOTK0f+f/PNbaeo7b87BHmKysr6uegkSfRBsb7xt70A0Xfbi9HJ4MEWirlskRXjJbwwdOFhLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GW0CP+ZsZC4al5ZwOSMYomFQLHQKOerVe7jZ0jYNcrU=; b=THi7Jff6jkViJnCpuIHMfbBqt2M0fhgvOcH7aFitLjt212EmMrBOjnTRX1BQceOIb2JM2UT0zvPA8wJeT7XYKKCBUJM+dCUYmk3uyQApa3wVBbcTHoHkRNqfYr6uZmo8wphxASxVqYqOvMCZLOwQRHb5nPYB8k0dz4aSLyAaVEc= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DU0PR08MB9203.eurprd08.prod.outlook.com (2603:10a6:10:417::12) by DU0PR08MB8322.eurprd08.prod.outlook.com (2603:10a6:10:40d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.12; Fri, 29 May 2026 06:32:01 +0000 Received: from DU0PR08MB9203.eurprd08.prod.outlook.com ([fe80::f1e:73f2:57df:4047]) by DU0PR08MB9203.eurprd08.prod.outlook.com ([fe80::f1e:73f2:57df:4047%5]) with mapi id 15.21.0071.011; Fri, 29 May 2026 06:32:01 +0000 Message-ID: <3e98ca04-086a-4028-a854-c317d0ceae70@arm.com> Date: Fri, 29 May 2026 12:01:52 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/5] selftests/mm: separate GUP microbenchmarking from functional testing To: Dev Jain , Andrew Morton Cc: David Hildenbrand , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Barry Song , Lance Yang , Jason Gunthorpe , John Hubbard , Peter Xu , Leon Romanovsky , Jonathan Corbet , Shuah Khan , Mark Brown , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260527142432.230127-1-sarthak.sharma@arm.com> <20260527114752.cf4dd3e1bda93fb8ebab5a76@linux-foundation.org> <3b4176f4-e099-490c-a5e2-6a36d00b1207@arm.com> <403181bc-eab0-4f4a-b986-dab1d8c49bf3@arm.com> From: Sarthak Sharma Content-Language: en-US In-Reply-To: <403181bc-eab0-4f4a-b986-dab1d8c49bf3@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MA5P287CA0130.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:1d2::12) To DU0PR08MB9203.eurprd08.prod.outlook.com (2603:10a6:10:417::12) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DU0PR08MB9203:EE_|DU0PR08MB8322:EE_|AMS1EPF0000004E:EE_|DB4PR08MB8032:EE_ X-MS-Office365-Filtering-Correlation-Id: d1e1eee2-4a88-409c-edac-08debd4c2732 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|1800799024|376014|7416014|366016|18002099003|22082099003|5023799004|11063799006|6133799003|56012099006|4143699003; X-Microsoft-Antispam-Message-Info-Original: tUvvY6LButqZipRaMhA47/6SsP6CmDzeTzULWjTgUyFEcbNuCXwy0Y5Rum+5WEp04QdUkVooOqXJ9JqSnDH4DcmMbCjEzD5elc6QZIBpoU00KmfNdq5c2f7ldeERGM+ks3nsK0zQszj9mhPPS0WqGitm2fUbsuSY5dOx61uFEcOAoYvIWbUgdSaI2ehwXSFZIoJgBS+ALkrPSB+TjaDuz1Z6ptGws116f+M8IsxfvJGtdIQg3r1ySEA0wEEZLMHwbBacZmj4Hha0HiGQeNhd0khpU84MnU37prRbfIz5/cxof36zY8A19IPVyLq9MISbpB2loRpJJkVPcHIEv0wEMCpgjxBe0HxtBSrnHNaJm8lR15vulMWRSpFaC+3yV9DRw2kkUb589cgeZ4mBYVANbBk8nAN2X0tHSf7Sr7wpBrqL8t74bxk5hufu5s0BuwmoPUX2nl5E8Pcjsizuf67PT0zfJBGh/el9y9XNO5CgfRoJdSwgr8Hocz5XD/tgHiZwBhk6ooTFLwVlYsU/cD64FkBHZtapupyMtyuNZKUqxZs6kOrkZ/bBSbS4s2S7liDHCh6XEOpMtVoHiGJiohP1kpzsvKKbfGAi3uU1C5utQKQsJj/nBf5p3QUV2zx5716ayen1CK5MDNxtLhFzVOtUBQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB9203.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016)(18002099003)(22082099003)(5023799004)(11063799006)(6133799003)(56012099006)(4143699003);DIR:OUT;SFP:1101; X-Exchange-RoutingPolicyChecked: s/gIiAWAhe5B94m/n3N6UmAKfP+CEq6J4KNHeRlNtvCUJAthG2mEocMOa9NBlNQ6DHzqjtCOyhCKMh4wF0JWonL/DVzbEDkjihTvGxyHWWrP6dWQrRLPWJ66tJZLmrCQKIKvXqbTJ3NSlQKsv4kkvxlmEumiv1r3lic1ir/wvx8+R3L6ZLvi+CCSsOcCUxVSZs1cu3e0apuEG3WMakP4kpaO1ep1ksocjFHaEfVYAECFruKRrr6x2nDAxpCwq/IJ/qkS1mPa4JPnFsfo5c9XS+/Clgg0iXUXAOvtqsF9SWZ0WeyOxANoUMddSmggQPzK1b8i0mvVcN9A9Y0u0R88NQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8322 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS1EPF0000004E.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7d29084b-5f9a-4d35-5920-08debd4bfde4 X-Microsoft-Antispam: BCL:0;ARA:13230040|14060799003|36860700016|82310400026|35042699022|1800799024|376014|7416014|56012099006|4143699003|6133799003|11063799006|5023799004|22082099003|18002099003|13003099007; X-Microsoft-Antispam-Message-Info: E1sglhRdTHFPfgh58Ey8uSSf8Gp3zO6RB/pyP0zjXf7KSZ8mimQ5TwJ9JzGDWm8OGYgNAtNFOK/iWtHW4kleOfFsxgZTEx3V8zi3+k8atPOis6ppo/xrrR0R5Jm4I4yxefgFcUvm+fwtNbeDW8szJXpdYZKSGBLgKjFAFuJoSEurcCBzIdejQcMk4PUTwSVw+8AzJjKtLHg6vn6VAUg6SeSEZVjdOFzvBuPqtvV+dxnASNvrHZ8pA5pbnS39Uout+PhSSM/bwm7z1qtHUIrNwtjiPghF6hbtISTHsUdc2nLKqyQEBLubTetJGfRVmWtRDreuD09eXvC+JaJY25qoLsuPVUPoLKTuVqYiRylm7kM6N+8A7fgOzIHTttpdw38Gy3PeiN9YIES357YvUi4QTvUrCup1mGpxgZedvZVxIzmeWFfohsRZsLWLnjUEPNk+I21IXP09Z+3UOgIYOfYLFwc4eU94B5hQFLJKA4pytuVkstOhKx7XSP+NpOM1JYl435EtbM9Z6PdTzAJU2hSKjBcpZYXnytBisqmACuTK/vJN7O5dfEDIBnHzV6U7ugaN4Y4gPh+Gq8gUMlbyCHzSwRIwpsVDjJmqJClpv1VDtSP61H0jp1qu9MS4JkCLuFqbNGKWXNYW31ukaAECYGhPok0HKE51rUyi9wU4UU4W6qwo2OY3FonN/xQkrko5o6CG X-Forefront-Antispam-Report: CIP:4.158.2.129;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:outbound-uk1.az.dlp.m.darktrace.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(14060799003)(36860700016)(82310400026)(35042699022)(1800799024)(376014)(7416014)(56012099006)(4143699003)(6133799003)(11063799006)(5023799004)(22082099003)(18002099003)(13003099007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: u2Ym6cVVrUgSt7cEx8Xwh6QOyJ+4Wgi64jpeE/iSkmH8uQ4L+jkQ8S5uG5ra3Nph+k52xZNL9DmsXTHiJ4nZP+Lbi9Y8tNfE+tbzE7kmIGetOOVsVvhEOG73q5kmfe7QUUZ9n6Pum/40KqbqrnDKajKmSVM+h5n625AczjGDcq2cJvBN21XnWzZiQLbfgJenUEeQx9V0E1Xn339AKbj5coU1yt5FTo3tT59a2aLNLpGfE1/Buo+jGxDjwyJXy5al7xldcUL+auxKlrR0drqRR6cYZ4s5ZVuWR1qsI3rQ17NZSKeNBi0Ss9BrjF2hRllScVaKLQgpqpLH57LXEayc+XB5bdg3qShB2gTZMWkHweODPtYLrn3lClfEDafwUooU83Nkn0Gy4BANnGDp9fYLDmhqmOhXaO7XfJwgCE3p7k+8xwrNWmSSzE/QgU4uRMcw X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2026 06:33:10.5057 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d1e1eee2-4a88-409c-edac-08debd4c2732 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[4.158.2.129];Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000004E.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB8032 Hi Dev! On 5/29/26 11:36 AM, Dev Jain wrote: > > > On 29/05/26 11:27 am, Sarthak Sharma wrote: >> Hi Andrew! >> >> On 5/28/26 12:17 AM, Andrew Morton wrote: >>> On Wed, 27 May 2026 19:54:27 +0530 Sarthak Sharma wrote: >>> >>>> gup_test.c currently serves two distinct purposes: microbenchmarking >>>> (GUP_FAST_BENCHMARK, PIN_FAST_BENCHMARK, PIN_LONGTERM_BENCHMARK) and >>>> functional correctness testing (GUP_BASIC_TEST, PIN_BASIC_TEST, >>>> DUMP_USER_PAGES_TEST). Mixing these in a single binary means functional >>>> tests cannot be run or reported individually and run_vmtests.sh must >>>> invoke the binary multiple times with different flag combinations to >>>> cover all configurations. >>>> >>>> This patch series separates the two concerns: tools/mm/gup_bench for >>>> benchmarking and tools/testing/selftests/mm/gup_test for functional >>>> testing. To avoid duplicating HugeTLB and related file helpers, the >>>> series first prepares the existing file helpers for sharing, then moves >>>> the common helper code to tools/lib/mm/ so it can be shared by both >>>> selftests and tools/mm. >>> >>> Thanks. I'll duck this for now, see what reviewers have to say. >>> >>> Sashiko still has a couple of nags. Minor stuff, arguably ignorable. >>> https://sashiko.dev/#/patchset/20260527142432.230127-1-sarthak.sharma@arm.com >> >> Thanks! I went through Sashiko's review. >> >> Both the points are valid but look very minor to me: one is a temporary >> x86 build issue fixed by the next patch and the other is stricter > > For the sake of bisection, we try to make patches such that each patch > when applied one by one, does not break the build. Sashiko says that > applying this patch breaks mm-selftests build for x86, so this needs > to be fixed : ) > > Although if there is no other major review comment, instead of respinning > you could simply reply to this patch with a fix patch and Andrew can > incorporate that : ) Thanks, that makes sense. I'll wait for reviewer feedback for now. If no major comment comes in, I'll send a fix patch to move the x86 Makefile change from patch 3 to patch 2. > >> argument validation for -F in gup_bench. > >> >> I don't feel they require a v5 on their own. Let's wait for reviewer >> feedback. If a respin is needed then I'll fold these cleanups in as well. >> >