From: Akira Yokosawa <akiyks@gmail.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915/guc, docs: Fix pdfdocs build error by removing nested grid
Date: Tue, 5 Oct 2021 00:09:28 +0900 [thread overview]
Message-ID: <3ec7d7c5-301f-ad34-fd40-844e81e1cdb9@gmail.com> (raw)
In-Reply-To: <87czozba5c.fsf@intel.com>
On Thu, 23 Sep 2021 18:10:23 +0300, Jani Nikula wrote:
> On Mon, 20 Sep 2021, Akira Yokosawa <akiyks@gmail.com> wrote:
>> Nested grids in grid-table cells are not specified as proper ReST
>> constructs.
>> Commit 572f2a5cd974 ("drm/i915/guc: Update firmware to v62.0.0")
>> added a couple of kerneldoc tables of the form:
>>
>> +---+-------+------------------------------------------------------+
>> | 1 | 31:0 | +------------------------------------------------+ |
>> +---+-------+ | | |
>> |...| | | Embedded `HXG Message`_ | |
>> +---+-------+ | | |
>> | n | 31:0 | +------------------------------------------------+ |
>> +---+-------+------------------------------------------------------+
>>
>> For "make htmldocs", they happen to work as one might expect,
>> but they are incompatible with "make latexdocs" and "make pdfdocs",
>> and cause the generated gpu.tex file to become incomplete and
>> unbuildable by xelatex.
>>
>> Restore the compatibility by removing those nested grids in the tables.
>>
>> Size comparison of generated gpu.tex:
>>
>> Sphinx 2.4.4 Sphinx 4.2.0
>> v5.14: 3238686 3841631
>> v5.15-rc1: 376270 432729
>> with this fix: 3377846 3998095
>>
>> Fixes: 572f2a5cd974 ("drm/i915/guc: Update firmware to v62.0.0")
>> Cc: John Harrison <John.C.Harrison@Intel.com>
>> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Matthew Brost <matthew.brost@intel.com>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> Cc: Matt Roper <matthew.d.roper@intel.com>
>> Cc: Jonathan Corbet <corbet@lwn.net>
>> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
>
> Pushed to drm-intel-gt-next, thanks for the patch.
>
> This makes the HTML output arguably worse, but there were no comments
> from anyone and the pdf build needs to work.
[Dropped most CCs]
Hi Jani,
Thank you for taking care of this patch.
Jon, as this has reached upstream, can you back-merge v5.15-rc4
into docs-next so that "make pdfdocs" can complete?
I tried the back-merge without seeing any conflict.
"make pdfdocs" finishes successfully now.
Thanks, Akira
>
> BR,
> Jani.
>
>
>
>> ---
[...]
next prev parent reply other threads:[~2021-10-04 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 7:05 [PATCH] drm/i915/guc, docs: Fix pdfdocs build error by removing nested grid Akira Yokosawa
2021-09-20 8:50 ` Jani Nikula
2021-09-23 15:10 ` Jani Nikula
2021-10-04 15:09 ` Akira Yokosawa [this message]
2021-10-04 23:14 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ec7d7c5-301f-ad34-fd40-844e81e1cdb9@gmail.com \
--to=akiyks@gmail.com \
--cc=corbet@lwn.net \
--cc=jani.nikula@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).