From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 968C44A0C for ; Tue, 1 Jul 2025 08:04:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751357053; cv=none; b=Ogdert+IXBXrrO18UsEMbukXdmIszoYzohVfOKnPDYi+TAca4lZ+u7lh5hKYrszQGYp+QGrgqAgtG/IoRFYHZbz1nJPNQSxOixMBci2aN4QNclNZMwWp1VD/hsCN0zF68K/ue13JcM2RBYnrnliW2ay27at/dub+/NVuwO1+CnE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751357053; c=relaxed/simple; bh=ZtIGBD2+g8T5YgNHrFs6+HwZ/kfDfPpPyWcD9GIgXbQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mDi8h2aEdx+SU6CKB5y8D3ygd/D5vesVZni1KAP8iHowkQ6OQzmrA0GNo1Y3uw9Ki2gRZP4z4HDBaFTOv3GpLPt0vl2BYs4VZsqqwQ+ITAnsxpNm81s1F/BHMuGIjwdVupDBPNpizJLrU6i7lP4sF3cQRNqXvcHNSMkhTzzsBVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cR4TTRhS; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cR4TTRhS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751357050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pUfxa+nNjdWULRVVJvn16LKseq+jCWAXhMIO+TN4r9c=; b=cR4TTRhSdA+sfj5DmVaMI9JNeQdE3W8ebMOUe17yrbbidvptogmMav/GKahwniwzqV2FgN YZ3sggN+U91NtIH9adJnjfdU9o2fy6SugwPD1Vhxvq9mXIS8cYsMs+9vUSKxlfxliYMR7g MxnPz5LiThsgX2dTIfAhu6FBfFNpUQk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-HN6hBw1bMmesMR9Cyi3eIA-1; Tue, 01 Jul 2025 04:04:09 -0400 X-MC-Unique: HN6hBw1bMmesMR9Cyi3eIA-1 X-Mimecast-MFC-AGG-ID: HN6hBw1bMmesMR9Cyi3eIA_1751357044 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-45311704d22so20966795e9.2 for ; Tue, 01 Jul 2025 01:04:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751357042; x=1751961842; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=pUfxa+nNjdWULRVVJvn16LKseq+jCWAXhMIO+TN4r9c=; b=mUOjdJ1g2pnE0UU9F1A66pv6bp97oKJJ5kOvs9TpJzwPzQgFNqHclRBoqYE3xs+SXm befHXLMogfXZK+tMMvhwAs7yBulmIghwgqXLX1Hj9ZB8XXYe8gsyMJe1bevL8xALg255 DqhJE2Pgm/cWfZ0UsLnOHhvBWJexWRtUvxQbJUYTMEBwFsWwBTSH6dbxReJX+OymEhBW DMjwT+5siKwe+KWDRAC0XC67Wz2LmTP7x7K/ykFudiHLfjLjIAUGNwHu5kgJ8wJI4kbW J3RRoVnuarFRcq2AZ61NYHP+vsMh55q+I5tneUOx2XfHGj1isuUvFnsilpj6BpuLGj9P 60PA== X-Forwarded-Encrypted: i=1; AJvYcCUNWF4K9o5PK+hZEO84ItoqJIi7hka8pD9dLexdkIQOwJJcLGL90HFelw/FkoNJGzfnmU9DaDz2z9E=@vger.kernel.org X-Gm-Message-State: AOJu0YyHZ2Ae8A7TPYz1vnG1/oPXRAQK/3G38cr4cTiVZ2wo3w5fhkRZ VC4k6gXS0XQ0v9E3LHPL6qYFf2wHxX0fkuJxLj2bgL7jJy8BaUL9YB7bmJ3rkHkbHTs7umo97kk 39jLNHZo2ifqHU51E8SPT5RdEHarAZafe2vsns8M6MzvuTmtO5NhuftqLUBikxw== X-Gm-Gg: ASbGncuQUjDMOiQqvWFlGvncF7yXHxRAaVlBfJyL19h8NUneYff27Ce/iNr5TcUjrgk b6FhFtzfhMsBwDEdnwrKw0rUW2a3u9dsPLK98tScv5gIZ+0IjPYRN9TNlaG6FcC2LccEqVHr1nL D2gpoGMoeMrtgoHFgayu+H3NRrQ1Xp81aAR/cAujPNdHfHRtKcfmZalASCnWt12/uIgRWAPtGPw BH5a8UaxtSpUZu0HoPRV4EfdVxDazIvivGvyK+iw2x40qEhQ5kNPqFHuaQODUA9lFmJ/02mT4Xu oUepT2Ost9WuLiR6P5YK0cYzb8TY/CZ4ZqbGKHwmFBXdWUtmMoJih+wHctvdXczJk2irm3uCe5V kTpbApnpfn3WqLJ3CD0LsXE5sQJeTvwr0/eOrY+nRZDPdFHg7Tw== X-Received: by 2002:a05:600c:348b:b0:43c:f8fc:f697 with SMTP id 5b1f17b1804b1-453929a6d39mr150001235e9.9.1751357041414; Tue, 01 Jul 2025 01:04:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGm6r359RgTt8m7jA8PuYlLgOkMn1+oAKNYFF6zANtJXeownWBFwaSRu8IR5EUD4wI8vxIgKQ== X-Received: by 2002:a05:600c:348b:b0:43c:f8fc:f697 with SMTP id 5b1f17b1804b1-453929a6d39mr150000635e9.9.1751357040906; Tue, 01 Jul 2025 01:04:00 -0700 (PDT) Received: from ?IPV6:2003:d8:2f18:7500:202e:b0f1:76d6:f9af? (p200300d82f187500202eb0f176d6f9af.dip0.t-ipconnect.de. [2003:d8:2f18:7500:202e:b0f1:76d6:f9af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453823c463asm186965025e9.39.2025.07.01.01.03.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 01:04:00 -0700 (PDT) Message-ID: <411b94bb-4662-4357-86a3-05478f2f8c8f@redhat.com> Date: Tue, 1 Jul 2025 10:03:57 +0200 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 03/29] mm/zsmalloc: drop PageIsolated() related VM_BUG_ONs To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250630130011.330477-1-david@redhat.com> <20250630130011.330477-4-david@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30.06.25 17:17, Lorenzo Stoakes wrote: > On Mon, Jun 30, 2025 at 02:59:44PM +0200, David Hildenbrand wrote: >> Let's drop these checks; these are conditions the core migration code >> must make sure will hold either way, no need to double check. >> >> Acked-by: Zi Yan >> Reviewed-by: Sergey Senozhatsky >> Acked-by: Harry Yoo >> Signed-off-by: David Hildenbrand > > LGTM, one comment below. > > Reviewed-by: Lorenzo Stoakes > Thanks! >> --- >> mm/zpdesc.h | 5 ----- >> mm/zsmalloc.c | 5 ----- >> 2 files changed, 10 deletions(-) >> >> diff --git a/mm/zpdesc.h b/mm/zpdesc.h >> index d3df316e5bb7b..5cb7e3de43952 100644 >> --- a/mm/zpdesc.h >> +++ b/mm/zpdesc.h >> @@ -168,11 +168,6 @@ static inline void __zpdesc_clear_zsmalloc(struct zpdesc *zpdesc) >> __ClearPageZsmalloc(zpdesc_page(zpdesc)); >> } >> >> -static inline bool zpdesc_is_isolated(struct zpdesc *zpdesc) >> -{ >> - return PageIsolated(zpdesc_page(zpdesc)); >> -} >> - >> static inline struct zone *zpdesc_zone(struct zpdesc *zpdesc) >> { >> return page_zone(zpdesc_page(zpdesc)); >> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c >> index 999b513c7fdff..7f1431f2be98f 100644 >> --- a/mm/zsmalloc.c >> +++ b/mm/zsmalloc.c >> @@ -1719,8 +1719,6 @@ static bool zs_page_isolate(struct page *page, isolate_mode_t mode) >> * Page is locked so zspage couldn't be destroyed. For detail, look at >> * lock_zspage in free_zspage. >> */ >> - VM_BUG_ON_PAGE(PageIsolated(page), page); >> - >> return true; >> } >> >> @@ -1739,8 +1737,6 @@ static int zs_page_migrate(struct page *newpage, struct page *page, >> unsigned long old_obj, new_obj; >> unsigned int obj_idx; >> >> - VM_BUG_ON_PAGE(!zpdesc_is_isolated(zpdesc), zpdesc_page(zpdesc)); >> - >> /* The page is locked, so this pointer must remain valid */ >> zspage = get_zspage(zpdesc); >> pool = zspage->pool; >> @@ -1811,7 +1807,6 @@ static int zs_page_migrate(struct page *newpage, struct page *page, >> >> static void zs_page_putback(struct page *page) >> { >> - VM_BUG_ON_PAGE(!PageIsolated(page), page); >> } > > Can we just drop zs_page_putback from movable_operations() now this is empty? Common code expects there to be a callback, and I don't want to change that. Long-term I assume it will rather indicate a BUG if there is no putback handler, not something we want to encourage. Likely, once we rework that isolated pages cannot get freed here, we'd have to handle stuff on the putback path (realize that the page can be freed and free it) -- TODO for that is added in #12. -- Cheers, David / dhildenb