Linux Documentation
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: kernel test robot <lkp@intel.com>,
	Benjamin Coddington <bcodding@hammerspace.com>,
	oe-kbuild-all@lists.linux.dev,
	Christian Brauner <brauner@kernel.org>,
	Jeff Layton <jlayton@kernel.org>,
	linux-doc@vger.kernel.org
Subject: Re: [linux-next:master 1503/2671] htmldocs: Documentation/filesystems/api-summary:56: ./fs/namei.c:4953: WARNING: Inline emphasis start-string without end-string. [docutils]
Date: Thu, 1 Jan 2026 22:38:18 -0800	[thread overview]
Message-ID: <424be38c-e315-42e3-9783-51ce34310d38@infradead.org> (raw)
In-Reply-To: <aVc_KwkNGsPxS5jT@casper.infradead.org>



On 1/1/26 7:44 PM, Matthew Wilcox wrote:
> On Thu, Jan 01, 2026 at 07:36:48PM -0800, Randy Dunlap wrote:
>> fs/open.c is not used in Documentation/ (where the lines were moved _from_).
> 
> That seems like it might be worth a patch?
> 
> +++ b/Documentation/filesystems/api-summary.rst
> @@ -56,6 +56,9 @@ Other Functions
>  .. kernel-doc:: fs/namei.c
>     :export:
> 
> +.. kernel-doc:: fs/open.c
> +   :export:
> +
>  .. kernel-doc:: block/bio.c
>     :export:
> 
> 
> ... of course, then someone would have to check it didn't introduce new
> errors, so it's a bit more work than that.  Perhaps you'd like to take
> care of it?

It seems safe enough unless -Wall or -Wreturn is used (these are not used
by default AFAICT), yielding these warnings:
Warning: fs/open.c:1046 No description found for return value of 'finish_open'
Warning: fs/open.c:1069 No description found for return value of 'finish_no_open'
Warning: fs/open.c:1089 No description found for return value of 'vfs_open'
Warning: fs/open.c:1330 No description found for return value of 'file_open_name'
Warning: fs/open.c:1351 No description found for return value of 'filp_open'
Warning: fs/open.c:1046 No description found for return value of 'finish_open'
Warning: fs/open.c:1069 No description found for return value of 'finish_no_open'
Warning: fs/open.c:1089 No description found for return value of 'vfs_open'
Warning: fs/open.c:1330 No description found for return value of 'file_open_name'
Warning: fs/open.c:1351 No description found for return value of 'filp_open'


Sure, I'll send that patch.

> (and don't we have a script that flags files that have kernel-doc that's
> not included in rst files?)

tools/doc/find-unused-docs.sh

-- 
~Randy


  reply	other threads:[~2026-01-02  6:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-01 13:27 [linux-next:master 1503/2671] htmldocs: Documentation/filesystems/api-summary:56: ./fs/namei.c:4953: WARNING: Inline emphasis start-string without end-string. [docutils] kernel test robot
2026-01-02  3:36 ` Randy Dunlap
2026-01-02  3:44   ` Matthew Wilcox
2026-01-02  6:38     ` Randy Dunlap [this message]
2026-01-05 23:59   ` Gopi Krishna Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=424be38c-e315-42e3-9783-51ce34310d38@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=bcodding@hammerspace.com \
    --cc=brauner@kernel.org \
    --cc=jlayton@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox