From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from iad-out-007.esa.us-east-1.outbound.mail-perimeter.amazon.com (iad-out-007.esa.us-east-1.outbound.mail-perimeter.amazon.com [3.221.209.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02BE63E3DAC; Fri, 10 Apr 2026 15:27:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=3.221.209.22 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775834826; cv=none; b=riHdh0oxmCn8KdsmbCiHDVG/4ILN9PZQV8J81EEXV8a6YbN9OrN7/jztuNt5kQ1afUxCBFLMLXYyPr27MonwVnY9lsvIFF88WMK3v1zQNCp00xM4zTyFTxeSpKOyOk9vX/1DH34pYvfMVDp/x4SxS45/xqDUsgFHdwdRCXsA8JY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775834826; c=relaxed/simple; bh=szA8egPzOY8OgLKL+8qAoC4/LyFsfkY0RLZUw1/YyFM=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=kIxOHnmFGx8+yNiVRdlWDgALsbiLEwRjmuEPHUC5AV5C9WrkpzDJM8XEZfu0F0rmq7xZ1zB1K3gecUdZLnCJm8YIqfhJb2jgLKGQQHmdT+51EYpdBu1gZfzKzfWWM0qz+YJlHO/wUJL0JdrB5w4y3HLoo7Hg2puEZMBZmXHEZbc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.co.uk; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b=CcIi3iYN; arc=none smtp.client-ip=3.221.209.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b="CcIi3iYN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1775834825; x=1807370825; h=message-id:date:mime-version:reply-to:subject:to:cc: references:from:in-reply-to:content-transfer-encoding; bh=DewD7DK1ob/bc268SFd2/qF7WsGADICns3g/XEuN0nA=; b=CcIi3iYNLNgCSH931M2mLbVfDN/1PKcADwlSVhMgzne3oO1c4DlY51tT rQz1NTeTlin3b6Xu5c4eDXEysORinjS0Noip0N+o6Quh4nZQWxIPz+evw 05X46htZsa6KrCag1ZWWuC5s5M5SPF6SYqhUItr+fdTa8ORqbKz/VoHcN s3vMtsbfFQt9zenxvgZBNph1nVjWXImw0/eTfchgQGT0oMflEbuJbsu02 jCfUF5gJLswsiuVifmGfoYtEow/F/fMlUKYo0rJu6y2rZwbI3mAJw5pNn vJ8i6YNlBIv2Lub1GOy8sHSixMC0L0X5DbIIexLffGeLoQxGihh7hb7cq A==; X-CSE-ConnectionGUID: gI4/W2RwTOG1O7PgCTUhgw== X-CSE-MsgGUID: BLc77vy4SnqTbMYl2NOT7w== X-IronPort-AV: E=Sophos;i="6.23,171,1770595200"; d="scan'208";a="15990465" Received: from ip-10-4-3-150.ec2.internal (HELO smtpout.naws.us-east-1.prod.farcaster.email.amazon.dev) ([10.4.3.150]) by internal-iad-out-007.esa.us-east-1.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2026 15:27:04 +0000 Received: from EX19MTAUEA002.ant.amazon.com [52.94.133.129:20620] by smtpin.naws.us-east-1.prod.farcaster.email.amazon.dev [10.0.46.155:2525] with esmtp (Farcaster) id a191a26b-32aa-4efa-af7e-55c66dfde52b; Fri, 10 Apr 2026 15:27:03 +0000 (UTC) X-Farcaster-Flow-ID: a191a26b-32aa-4efa-af7e-55c66dfde52b Received: from EX19D027UEC003.ant.amazon.com (10.252.137.250) by EX19MTAUEA002.ant.amazon.com (10.252.134.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.37; Fri, 10 Apr 2026 15:26:58 +0000 Received: from [192.168.12.97] (10.106.82.30) by EX19D027UEC003.ant.amazon.com (10.252.137.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.37; Fri, 10 Apr 2026 15:26:45 +0000 Message-ID: <453fb48d-0f68-4947-bf9a-c2c9b017162d@amazon.com> Date: Fri, 10 Apr 2026 16:26:43 +0100 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Subject: Re: [PATCH v11 03/16] mm/secretmem: make use of folio_{zap, restore}_direct_map To: Ackerley Tng , "Kalyazin, Nikita" , "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "bpf@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "kernel@xen0n.name" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-pm@vger.kernel.org" CC: "pbonzini@redhat.com" , "corbet@lwn.net" , "maz@kernel.org" , "oupton@kernel.org" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "seanjc@google.com" , "tglx@kernel.org" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "luto@kernel.org" , "peterz@infradead.org" , "willy@infradead.org" , "akpm@linux-foundation.org" , "david@kernel.org" , "lorenzo.stoakes@oracle.com" , "vbabka@kernel.org" , "rppt@kernel.org" , "surenb@google.com" , "mhocko@suse.com" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , "martin.lau@linux.dev" , "eddyz87@gmail.com" , "song@kernel.org" , "yonghong.song@linux.dev" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "sdf@fomichev.me" , "haoluo@google.com" , "jolsa@kernel.org" , "jgg@ziepe.ca" , "jhubbard@nvidia.com" , "peterx@redhat.com" , "jannh@google.com" , "pfalcato@suse.de" , "skhan@linuxfoundation.org" , "riel@surriel.com" , "ryan.roberts@arm.com" , "jgross@suse.com" , "yu-cheng.yu@intel.com" , "kas@kernel.org" , "coxu@redhat.com" , "kevin.brodsky@arm.com" , "yosry@kernel.org" , "ajones@ventanamicro.com" , "maobibo@loongson.cn" , "tabba@google.com" , "prsampat@amd.com" , "wu.fei9@sanechips.com.cn" , "mlevitsk@redhat.com" , "jmattson@google.com" , "jthoughton@google.com" , "agordeev@linux.ibm.com" , "alex@ghiti.fr" , "aou@eecs.berkeley.edu" , "borntraeger@linux.ibm.com" , "chenhuacai@kernel.org" , "dev.jain@arm.com" , "gor@linux.ibm.com" , "hca@linux.ibm.com" , "palmer@dabbelt.com" , "pjw@kernel.org" , "shijie@os.amperecomputing.com" , "svens@linux.ibm.com" , "thuth@redhat.com" , "wyihan@google.com" , "yang@os.amperecomputing.com" , "Jonathan.Cameron@huawei.com" , "Liam.Howlett@oracle.com" , "urezki@gmail.com" , "zhengqi.arch@bytedance.com" , "gerald.schaefer@linux.ibm.com" , "jiayuan.chen@shopee.com" , "lenb@kernel.org" , "osalvador@suse.de" , "pavel@kernel.org" , "rafael@kernel.org" , "vannapurve@google.com" , "jackmanb@google.com" , "aneesh.kumar@kernel.org" , "patrick.roy@linux.dev" , "Thomson, Jack" , "Itazuri, Takahiro" , "Manwaring, Derek" References: <20260317141031.514-1-kalyazin@amazon.com> <20260317141031.514-4-kalyazin@amazon.com> Content-Language: en-US From: Nikita Kalyazin Autocrypt: addr=kalyazin@amazon.com; keydata= xjMEY+ZIvRYJKwYBBAHaRw8BAQdA9FwYskD/5BFmiiTgktstviS9svHeszG2JfIkUqjxf+/N JU5pa2l0YSBLYWx5YXppbiA8a2FseWF6aW5AYW1hem9uLmNvbT7CjwQTFggANxYhBGhhGDEy BjLQwD9FsK+SyiCpmmTzBQJp2NfjBQkGQlIzAhsDBAsJCAcFFQgJCgsFFgIDAQAACgkQr5LK IKmaZPPNDAEAvsw8vEWj8ArWQ1QJNufjrvobU/cE8MLKdBxbSE8CyZQA/0BldKxNAtAwG4qw wCLxsZ5vBL3Zkh/PdvtFCj/VGscGzjgEY+ZIvRIKKwYBBAGXVQEFAQEHQCqd7/nb2tb36vZt ubg1iBLCSDctMlKHsQTp7wCnEc4RAwEIB8J+BBgWCAAmFiEEaGEYMTIGMtDAP0Wwr5LKIKma ZPMFAmnY1+MFCQZCUjMCGwwACgkQr5LKIKmaZPPQKgD/f3FtERbJ+LYHLSG/ZbLNAOLngUlQ qo5VfIyJOzeLzC0BAP2PIUFIHo7vmia/PXEmT+ve4c5rx+EkH/Dx1GRpjWoI In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: EX19D005EUB004.ant.amazon.com (10.252.51.126) To EX19D027UEC003.ant.amazon.com (10.252.137.250) On 23/03/2026 18:46, Ackerley Tng wrote: > "Kalyazin, Nikita" writes: > >> From: Nikita Kalyazin >> >> Signed-off-by: Nikita Kalyazin >> --- >> mm/secretmem.c | 8 ++------ >> 1 file changed, 2 insertions(+), 6 deletions(-) >> >> diff --git a/mm/secretmem.c b/mm/secretmem.c >> index fd29b33c6764..27b176af8fc4 100644 >> --- a/mm/secretmem.c >> +++ b/mm/secretmem.c >> @@ -53,7 +53,6 @@ static vm_fault_t secretmem_fault(struct vm_fault *vmf) >> struct inode *inode = file_inode(vmf->vma->vm_file); >> pgoff_t offset = vmf->pgoff; >> gfp_t gfp = vmf->gfp_mask; >> - unsigned long addr; >> struct folio *folio; >> vm_fault_t ret; >> int err; >> @@ -72,7 +71,7 @@ static vm_fault_t secretmem_fault(struct vm_fault *vmf) >> goto out; >> } >> >> - err = set_direct_map_invalid_noflush(folio_address(folio)); >> + err = folio_zap_direct_map(folio); >> if (err) { >> folio_put(folio); >> ret = vmf_error(err); >> @@ -87,7 +86,7 @@ static vm_fault_t secretmem_fault(struct vm_fault *vmf) >> * already happened when we marked the page invalid >> * which guarantees that this call won't fail >> */ >> - set_direct_map_default_noflush(folio_address(folio)); >> + folio_restore_direct_map(folio); >> folio_put(folio); >> if (err == -EEXIST) >> goto retry; >> @@ -95,9 +94,6 @@ static vm_fault_t secretmem_fault(struct vm_fault *vmf) >> ret = vmf_error(err); >> goto out; >> } >> - >> - addr = (unsigned long)folio_address(folio); >> - flush_tlb_kernel_range(addr, addr + PAGE_SIZE); >> } >> >> vmf->page = folio_file_page(folio, vmf->pgoff); >> -- >> 2.50.1 > > Reviewed-by: Ackerley Tng Thank you.