From: Paolo Abeni <pabeni@redhat.com>
To: Lee Trager <lee@trager.us>,
Alexander Duyck <alexanderduyck@fb.com>,
Jakub Kicinski <kuba@kernel.org>,
kernel-team@meta.com, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Jacob Keller <jacob.e.keller@intel.com>,
Mohsin Bashir <mohsin.bashr@gmail.com>,
Sanman Pradhan <sanman.p211993@gmail.com>,
Su Hui <suhui@nfschina.com>, Al Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 5/5] eth: fbnic: Add devlink dev flash support
Date: Thu, 15 May 2025 12:58:47 +0200 [thread overview]
Message-ID: <4cc7aeff-e90d-4e95-a84d-b874fbb47d4a@redhat.com> (raw)
In-Reply-To: <20250512190109.2475614-6-lee@trager.us>
On 5/12/25 8:54 PM, Lee Trager wrote:
> +static int
> +fbnic_flash_start(struct fbnic_dev *fbd, struct pldmfw_component *component)
> +{
> + struct fbnic_fw_completion *cmpl;
> + int err;
> +
> + cmpl = kzalloc(sizeof(*cmpl), GFP_KERNEL);
> + if (!cmpl)
> + return -ENOMEM;
> +
> + fbnic_fw_init_cmpl(cmpl, FBNIC_TLV_MSG_ID_FW_START_UPGRADE_REQ);
Minor note for a possible follow-up: since completion allocation is
always followed by fbnic_fw_init_cmpl(), you could boundle the 2 in some
helper.
No need to repost for this.
/P
next prev parent reply other threads:[~2025-05-15 10:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 18:53 [PATCH net-next v5 0/5] eth: fbnic: Add devlink dev flash support Lee Trager
2025-05-12 18:53 ` [PATCH net-next v5 1/5] pldmfw: Don't require send_package_data or send_component_table to be defined Lee Trager
2025-05-12 19:08 ` Jacob Keller
2025-05-12 18:53 ` [PATCH net-next v5 2/5] eth: fbnic: Accept minimum anti-rollback version from firmware Lee Trager
2025-05-12 18:53 ` [PATCH net-next v5 3/5] eth: fbnic: Add support for multiple concurrent completion messages Lee Trager
2025-05-12 19:08 ` Jacob Keller
2025-05-12 18:54 ` [PATCH net-next v5 4/5] eth: fbnic: Add mailbox support for PLDM updates Lee Trager
2025-05-12 18:54 ` [PATCH net-next v5 5/5] eth: fbnic: Add devlink dev flash support Lee Trager
2025-05-12 19:13 ` Jacob Keller
2025-05-13 13:45 ` Simon Horman
2025-05-15 10:58 ` Paolo Abeni [this message]
2025-05-15 11:54 ` [PATCH net-next v5 0/5] " Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cc7aeff-e90d-4e95-a84d-b874fbb47d4a@redhat.com \
--to=pabeni@redhat.com \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=lee@trager.us \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sanman.p211993@gmail.com \
--cc=suhui@nfschina.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).